New issue
Advanced search Search tips

Issue 893279 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Create expectation based unit tests for Find-It dependencies on recipes.

Project Member Reported by erikc...@chromium.org, Oct 8

Issue description

Find-it runs as a separate service that consumes buildbucket/tryjob/recipe output to determine flaky tests and compile/test failures.

Find-it depends on recipes emitting a specific series of steps, in a specific order, with specific substrings.

Some examples of implicit dependencies:
https://cs.chromium.org/chromium/infra/appengine/findit/services/flake_detection/flaky_tests.cq_false_rejection.sql?l=175

https://cs.chromium.org/chromium/infra/go/src/infra/appengine/test-results/frontend/builders.go?q=infra/appengine/test-results/frontend/builders.g&g=0&l=267

Each dependency should have corresponding tests in the appropriate recipes. They should use explicit expectations:
https://cs.chromium.org/chromium/infra/recipes-py/recipe_engine/post_process.py?l=11

rather than just emitting a JSON expectations file. This will reduce the frequency that recipe changes break find it.

 

Sign in to add a comment