New issue
Advanced search Search tips

Issue 893276 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 24
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

mash: implement screen.orientation.lock

Project Member Reported by est...@chromium.org, Oct 8

Issue description

Status: Fixed (was: Started)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f96e813b4cd956aaad1550d122a02ecd160c70b2

commit f96e813b4cd956aaad1550d122a02ecd160c70b2
Author: Evan Stade <estade@chromium.org>
Date: Thu Oct 18 18:55:38 2018

Mash: Implement ScreenOrientationDelegateChromeos

Test: put in tablet mode, go to [1], press Lock in Current Orientation

[1] https://whatwebcando.today/screen-orientation.html

Bug:   889981  
Change-Id: I2a4381b511c260a3845fbfd42a597cafe581fb43
Reviewed-on: https://chromium-review.googlesource.com/c/1250097
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600845}
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/ash/display/screen_orientation_controller.h
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/ash/display/screen_orientation_controller_test_api.h
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/ash/public/interfaces/ash_window_manager.mojom
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/ash/wm/splitview/split_view_divider.h
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/ash/ws/ash_window_manager.cc
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/ash/ws/ash_window_manager.h
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/chrome/browser/ui/ash/DEPS
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/chrome/browser/ui/ash/screen_orientation_delegate_chromeos.cc
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/chrome/browser/ui/ash/screen_orientation_delegate_chromeos.h
[add] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/chrome/browser/ui/ash/screen_orientation_delegate_chromeos_browsertest.cc
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/chrome/test/BUILD.gn
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/content/browser/screen_orientation/screen_orientation_provider.cc
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/content/browser/screen_orientation/screen_orientation_provider.h
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/content/public/test/browser_test_utils.h
[modify] https://crrev.com/f96e813b4cd956aaad1550d122a02ecd160c70b2/services/ws/window_tree.h

Sign in to add a comment