New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 893270 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 893267



Sign in to add a comment

make Android test runner support isolated-script-test-... cmd flag aliases

Project Member Reported by chanli@chromium.org, Oct 8

Issue description

Findit plans to support a set of cmd flag aliases, so we need Android test runner to support them as well.

The aliases are:
1. --isolated-script-test-filter=A::B::C
  a. Current cmd flag(alias) is: --gtest_filter=A:B:C
2. --isolated-script-test-repeat=30
  a. Current cmd flag(alias) is:--gtest_repeat=30
  b. To be consistent with currently supported test types, the exec 
     order should be ABCABCABC...
3. --isolated-script-test-launcher-retry-limit=0
  a. Current cmd flag(alias) is:--test-launcher-retry-limit=0
4. --isolated-script-test-also-run-disabled-tests
  a. Current cmd flag(alias) is:--gtest_also_run_disabled_tests
 
As you noted, this is supported via the gtest syntax. Why do you want it to support the isolated script one?

If you're trying to unify on a single command-line syntax, I'd expect to see a design doc...
The context for this request is:
1. In the bug(https://bugs.chromium.org/p/chromium/issues/detail?id=836413) we agree to unify the cmd flags to the same names and accepted value format.
2. In this doc (https://docs.google.com/document/d/1XZrAecLT33sJng9JTHsWCNpcBVU_BT7weLE76nwsTXA/edit#heading=h.wu11faryhx35) we agree to make changes at test runners' side so that Findit can eventually only support one set of cmd flags.

I assume the required changes here are
  1. adding aliases
  2. make test runner to know how to handle test list in the format like 'A::B::C'

Are there any more significant changes? What kind of design doc are you expecting?
:(

I disagree w/ Dirk in #13 of issue 836413 but I'll go along with it. As for the doc, what you've listed is sufficient.
Cc: robertma@chromium.org
Since we are on the same page to adding these new aliases and it's a quick change, do you have cycle to do it next week?

Robert Ma and I will do the same for webkit and gtest. Findit needs to wait for all three changes before switch over.
Should be able to do it this week.
Robert, will you be able to do the same this week?
er, to clarify a bit here: the filter string syntax in #0 appears to be different than the standard gtest filter syntax; is that intentional?
Re #7, if you are referring to the '::' instead of ':' between test names, yes that's intentional. IIRC, some Telemetry test names will contain ':' themselves so a single ':' will not work in that case.
#8: yep, that's what I was referring to, and that's... inconvenient. Is it otherwise the same as gtest?
I think so, yes.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a58dd0098069015ef5cfc0dfcd7ebaa56158c789

commit a58dd0098069015ef5cfc0dfcd7ebaa56158c789
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Oct 09 18:07:45 2018

android: add 3 --isolated-script-* aliases to test runner arguments.

This adds:
  --isolated-script-test-repeat=N
  --isolated-script-test-launcher-retry-limit=N
  --isolated-script-test-also-run-disabled-tests

Support for --isolated-script-test-filter will be added separately.

Bug: 893270
Change-Id: I2dbea5fd413189aab11986fc511ee15e4218ded3
Reviewed-on: https://chromium-review.googlesource.com/c/1271115
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597991}
[modify] https://crrev.com/a58dd0098069015ef5cfc0dfcd7ebaa56158c789/build/android/test_runner.py

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bd33d7dc57ec5eb6145b018f9c79d81bf0b1949

commit 7bd33d7dc57ec5eb6145b018f9c79d81bf0b1949
Author: John Budorick <jbudorick@chromium.org>
Date: Wed Oct 10 00:42:44 2018

android: add support for --isolated-script-test-filter

Bug: 893270
Change-Id: Id65ade126ebaad6691a1ce3a73103df9ddf6cf70
Reviewed-on: https://chromium-review.googlesource.com/c/1271885
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598151}
[modify] https://crrev.com/7bd33d7dc57ec5eb6145b018f9c79d81bf0b1949/build/android/pylib/utils/test_filter.py
[modify] https://crrev.com/7bd33d7dc57ec5eb6145b018f9c79d81bf0b1949/build/android/pylib/utils/test_filter_test.py
[modify] https://crrev.com/7bd33d7dc57ec5eb6145b018f9c79d81bf0b1949/build/android/test_runner.py

Status: Started (was: Assigned)
-also-run-disabled-tests doesn't work for junit tests. Otherwise, this is done.

Sign in to add a comment