New issue
Advanced search Search tips

Issue 893241 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Oct 10
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

GN cannot generate ninja script for MSVC link.exe

Reported by lilo...@gmail.com, Oct 8 
When linking with link.exe from MSVC, //chrome/browser:browser will be split into multiple libraries, like //chrome/browser:browser_0, //chrome/browser:browser_1, etc. (see //build/split_static_library.gni). It depends on //chrome/browser/apps/platform_apps/api:api, but the latter only declares visibility to //chrome/browser which implies //chrome/browser:browser, not including //chrome/browser:browser_0.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96bb4251d3991ebda18e0c6ec52e5f364f812081

commit 96bb4251d3991ebda18e0c6ec52e5f364f812081
Author: Tom Tan <Tom.Tan@microsoft.com>
Date: Wed Oct 10 01:01:18 2018

Fix visibility to //chrome/browser when not linking with LLD

Bug:  893241 
Change-Id: I784747c76b995e6a7a13ddb9961d4dfcad76fd0e
Reviewed-on: https://chromium-review.googlesource.com/c/1269177
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598156}
[modify] https://crrev.com/96bb4251d3991ebda18e0c6ec52e5f364f812081/AUTHORS
[modify] https://crrev.com/96bb4251d3991ebda18e0c6ec52e5f364f812081/chrome/browser/apps/platform_apps/api/BUILD.gn

Comment 2 by dtapu...@chromium.org, Oct 10

Status: Fixed (was: Unconfirmed)
►

Sign in to add a comment