This will be a fairly large and annoying refactor. I've made some progress on this, it should be doable.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/62c34e6a2d3e09327d23944287dd0b3542b6b79e commit 62c34e6a2d3e09327d23944287dd0b3542b6b79e Author: Stephen Martinis <martiniss@chromium.org> Date: Mon Oct 08 20:55:05 2018 Fix pylint issues for /scripts/slave/recipe_modules/chromite This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I31aa342513dba8372f6ca33d01edee55e8c0c05d Reviewed-on: https://chromium-review.googlesource.com/c/1268778 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/62c34e6a2d3e09327d23944287dd0b3542b6b79e/scripts/slave/README.recipes.md [modify] https://crrev.com/62c34e6a2d3e09327d23944287dd0b3542b6b79e/scripts/slave/recipe_modules/chromite/api.py [modify] https://crrev.com/62c34e6a2d3e09327d23944287dd0b3542b6b79e/scripts/slave/recipe_modules/chromite/config.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/dd65dea95be01f958d0b6031832016c7f7d324d6 commit dd65dea95be01f958d0b6031832016c7f7d324d6 Author: Stephen Martinis <martiniss@chromium.org> Date: Mon Oct 08 21:05:08 2018 Fix pylint issues for /scripts/slave/recipe_modules/chromium This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I3816428566fc0763011d4207c7cdef59d06257b2 Reviewed-on: https://chromium-review.googlesource.com/c/1268781 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/dd65dea95be01f958d0b6031832016c7f7d324d6/scripts/slave/README.recipes.md [modify] https://crrev.com/dd65dea95be01f958d0b6031832016c7f7d324d6/scripts/slave/recipe_modules/chromium/gclient_config.py [modify] https://crrev.com/dd65dea95be01f958d0b6031832016c7f7d324d6/scripts/slave/recipe_modules/chromium/config.py [modify] https://crrev.com/dd65dea95be01f958d0b6031832016c7f7d324d6/scripts/slave/recipe_modules/chromium/api.py [modify] https://crrev.com/dd65dea95be01f958d0b6031832016c7f7d324d6/scripts/slave/recipe_modules/chromium/tests/compile.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/5240323e02d1aede9fa676c071560e6d83561cf1 commit 5240323e02d1aede9fa676c071560e6d83561cf1 Author: Stephen Martinis <martiniss@chromium.org> Date: Mon Oct 08 21:55:04 2018 Fix pylint issues for /scripts/slave/recipe_modules/chromium_tests/tests This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I7af9a530ee1b59cb180ff14170e28c04bf6a7425 Reviewed-on: https://chromium-review.googlesource.com/c/1269475 Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/5240323e02d1aede9fa676c071560e6d83561cf1/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.py [modify] https://crrev.com/5240323e02d1aede9fa676c071560e6d83561cf1/scripts/slave/recipe_modules/chromium_tests/tests/api/prepare_checkout.py [modify] https://crrev.com/5240323e02d1aede9fa676c071560e6d83561cf1/scripts/slave/recipe_modules/chromium_tests/tests/steps/web_view_cts_test.py [modify] https://crrev.com/5240323e02d1aede9fa676c071560e6d83561cf1/scripts/slave/recipe_modules/chromium_tests/tests/builders.py [modify] https://crrev.com/5240323e02d1aede9fa676c071560e6d83561cf1/scripts/slave/recipe_modules/chromium_tests/tests/api/wrap_chromium_tests.py [modify] https://crrev.com/5240323e02d1aede9fa676c071560e6d83561cf1/scripts/slave/recipe_modules/chromium_tests/tests/steps/experimental_test.py [modify] https://crrev.com/5240323e02d1aede9fa676c071560e6d83561cf1/scripts/slave/recipe_modules/chromium_tests/tests/api/main_waterfall_steps.py [modify] https://crrev.com/5240323e02d1aede9fa676c071560e6d83561cf1/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/00f0d96f08d8455e03ed63cda9bb6d44a10bca74 commit 00f0d96f08d8455e03ed63cda9bb6d44a10bca74 Author: Stephen Martinis <martiniss@chromium.org> Date: Mon Oct 08 22:14:59 2018 Fix pylint issues for /scripts/slave/recipe_modules/codesearch This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I78efa8652a7ef73dace8041ab486d07d501496d5 Reviewed-on: https://chromium-review.googlesource.com/c/1269477 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org> [modify] https://crrev.com/00f0d96f08d8455e03ed63cda9bb6d44a10bca74/scripts/slave/recipe_modules/codesearch/api.py [modify] https://crrev.com/00f0d96f08d8455e03ed63cda9bb6d44a10bca74/scripts/slave/recipe_modules/codesearch/resources/sync_generated_files.py [modify] https://crrev.com/00f0d96f08d8455e03ed63cda9bb6d44a10bca74/scripts/slave/recipe_modules/codesearch/config.py [modify] https://crrev.com/00f0d96f08d8455e03ed63cda9bb6d44a10bca74/scripts/slave/README.recipes.md [modify] https://crrev.com/00f0d96f08d8455e03ed63cda9bb6d44a10bca74/scripts/slave/recipe_modules/codesearch/resources/package_index_test.py [modify] https://crrev.com/00f0d96f08d8455e03ed63cda9bb6d44a10bca74/scripts/slave/recipe_modules/codesearch/resources/sync_generated_files_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/672b87f2d6db94780de0a9a94789e09f7ed78da1 commit 672b87f2d6db94780de0a9a94789e09f7ed78da1 Author: Stephen Martinis <martiniss@chromium.org> Date: Mon Oct 08 22:26:57 2018 Fix pylint issues for /scripts/slave/recipe_modules/crrev This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I0a345741ca83985f6ea77f42c6eade17e143e76f Reviewed-on: https://chromium-review.googlesource.com/c/1269681 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/672b87f2d6db94780de0a9a94789e09f7ed78da1/scripts/slave/recipe_modules/crrev/resources/crrev_client.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/b369d04e76ddc026a7f9ebf0dd9f65ab1de89109 commit b369d04e76ddc026a7f9ebf0dd9f65ab1de89109 Author: Stephen Martinis <martiniss@chromium.org> Date: Mon Oct 08 22:43:07 2018 Fix pylint issues for /scripts/slave/recipe_modules/findit This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. R=chanli@chromium.org Bug: 893240 Change-Id: I82152dbcc4dd93c79c1252f020888aa0661f817b Reviewed-on: https://chromium-review.googlesource.com/c/1269689 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/b369d04e76ddc026a7f9ebf0dd9f65ab1de89109/scripts/slave/recipe_modules/findit/api.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/c22f50c594904c6b41f8736e26c0508ed4a967c4 commit c22f50c594904c6b41f8736e26c0508ed4a967c4 Author: Stephen Martinis <martiniss@chromium.org> Date: Mon Oct 08 22:45:37 2018 Fix pylint issues for /scripts/slave/recipe_modules/chromium_tests This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: Ifd54e971156c32b6f52e5b6e7b46408b4bf5b9a9 Reviewed-on: https://chromium-review.googlesource.com/c/1269476 Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/c22f50c594904c6b41f8736e26c0508ed4a967c4/scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py [modify] https://crrev.com/c22f50c594904c6b41f8736e26c0508ed4a967c4/scripts/slave/recipe_modules/chromium_tests/steps.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/9618cac4000ed0da27578b15c1e4b9ded2712955 commit 9618cac4000ed0da27578b15c1e4b9ded2712955 Author: Stephen Martinis <martiniss@chromium.org> Date: Mon Oct 08 22:57:37 2018 Fix pylint issues for /scripts/slave/recipe_modules/ios This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. R=smut@google.com Bug: 893240 Change-Id: I166192ecfca0da7cb7206f710e0942709f08622a Reviewed-on: https://chromium-review.googlesource.com/c/1269693 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Commit-Queue: smut <smut@google.com> Reviewed-by: smut <smut@google.com> [modify] https://crrev.com/9618cac4000ed0da27578b15c1e4b9ded2712955/scripts/slave/recipe_modules/ios/api.py [modify] https://crrev.com/9618cac4000ed0da27578b15c1e4b9ded2712955/scripts/slave/recipe_modules/ios/examples/full.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/210364c101012a926f4b72f3e0a5089a0aa38b86 commit 210364c101012a926f4b72f3e0a5089a0aa38b86 Author: Stephen Martinis <martiniss@chromium.org> Date: Mon Oct 08 23:11:43 2018 Fix pylint issues for /scripts/slave/recipe_modules/luci_config This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: Id711d56a3f0ee32e39816444de969ae156e34e43 Reviewed-on: https://chromium-review.googlesource.com/c/1270017 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/210364c101012a926f4b72f3e0a5089a0aa38b86/scripts/slave/recipe_modules/luci_config/config.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/943df9bcb6456aa6730eb017563ea51b7ee8bea7 commit 943df9bcb6456aa6730eb017563ea51b7ee8bea7 Author: Stephen Martinis <martiniss@chromium.org> Date: Mon Oct 08 23:12:23 2018 Fix pylint issues for /scripts/slave/recipe_modules/ndk This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I02ca2a58229bf24303f9379cac4d3f3a8f141a29 Reviewed-on: https://chromium-review.googlesource.com/c/1270018 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/943df9bcb6456aa6730eb017563ea51b7ee8bea7/scripts/slave/recipe_modules/ndk/chromite_config.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/fbc33f64d6db6fc85222b05238a96cb2fa3edd84 commit fbc33f64d6db6fc85222b05238a96cb2fa3edd84 Author: Stephen Martinis <martiniss@chromium.org> Date: Mon Oct 08 23:56:49 2018 Fix pylint issues for /scripts/slave/recipe_modules/swarming_client This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. R=vadimsh@chromium.org Bug: 893240 Change-Id: Id869ba811cb7e6a702b95328f8fa05c4f3fcbf30 Reviewed-on: https://chromium-review.googlesource.com/c/1270021 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/fbc33f64d6db6fc85222b05238a96cb2fa3edd84/scripts/slave/recipe_modules/swarming_client/api.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/a99d64dc3720e8d13b66e98748f1e508bc1e9207 commit a99d64dc3720e8d13b66e98748f1e508bc1e9207 Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Oct 09 00:48:38 2018 Fix pylint issues for /scripts/slave/recipe_modules/isolate This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I00d3c8756592690606ae7a6f89045d2438bcffa8 Reviewed-on: https://chromium-review.googlesource.com/c/1269694 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/a99d64dc3720e8d13b66e98748f1e508bc1e9207/scripts/slave/README.recipes.md [modify] https://crrev.com/a99d64dc3720e8d13b66e98748f1e508bc1e9207/scripts/slave/recipe_modules/chromium_tests/api.py [modify] https://crrev.com/a99d64dc3720e8d13b66e98748f1e508bc1e9207/scripts/slave/recipe_modules/isolate/api.py [modify] https://crrev.com/a99d64dc3720e8d13b66e98748f1e508bc1e9207/scripts/slave/recipe_modules/isolate/examples/full.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/55f0fc73072dc4c888257db1167cfc10ca26edf3 commit 55f0fc73072dc4c888257db1167cfc10ca26edf3 Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Oct 09 00:54:53 2018 Fix pylint issues for /scripts/slave/recipe_modules/filter This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: Ic7788bf94fcf7221b3f7950aecabd4af10c14ac1 Reviewed-on: https://chromium-review.googlesource.com/c/1269688 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/55f0fc73072dc4c888257db1167cfc10ca26edf3/scripts/slave/README.recipes.md [modify] https://crrev.com/55f0fc73072dc4c888257db1167cfc10ca26edf3/scripts/slave/recipe_modules/filter/tests/analyze.py [modify] https://crrev.com/55f0fc73072dc4c888257db1167cfc10ca26edf3/scripts/slave/recipe_modules/filter/api.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/eb0f7ac9cd5933e3438c288666cdc4f82ebd498d commit eb0f7ac9cd5933e3438c288666cdc4f82ebd498d Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Oct 09 02:17:37 2018 Fix pylint issues for /scripts/slave/recipe_modules/goma This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: Id1875a9d692e6a13448a7945395439c41f8eb011 Reviewed-on: https://chromium-review.googlesource.com/c/1269691 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> [modify] https://crrev.com/eb0f7ac9cd5933e3438c288666cdc4f82ebd498d/scripts/slave/README.recipes.md [modify] https://crrev.com/eb0f7ac9cd5933e3438c288666cdc4f82ebd498d/scripts/slave/recipe_modules/goma/api.py [modify] https://crrev.com/eb0f7ac9cd5933e3438c288666cdc4f82ebd498d/scripts/slave/recipe_modules/goma/examples/full.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/81005054f47ac4f524b55daa74e4ca12747f8d5a commit 81005054f47ac4f524b55daa74e4ca12747f8d5a Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Oct 09 07:18:51 2018 Fix pylint issues for /scripts/slave/recipe_modules/docker This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I4c5558aaa4f632d75f3f7cb26b42b079fc8d5abe Reviewed-on: https://chromium-review.googlesource.com/c/1269685 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/81005054f47ac4f524b55daa74e4ca12747f8d5a/scripts/slave/README.recipes.md [modify] https://crrev.com/81005054f47ac4f524b55daa74e4ca12747f8d5a/scripts/slave/recipe_modules/docker/api.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/950814979f68299dabfb96ac838e6f42f4fd9e75 commit 950814979f68299dabfb96ac838e6f42f4fd9e75 Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Oct 09 09:22:56 2018 Fix pylint issues for /scripts/slave/recipe_modules/libyuv This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I396d5c56b3718ae6d9ac61562f863faa7a240b4f Reviewed-on: https://chromium-review.googlesource.com/c/1270016 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> [modify] https://crrev.com/950814979f68299dabfb96ac838e6f42f4fd9e75/scripts/slave/README.recipes.md [modify] https://crrev.com/950814979f68299dabfb96ac838e6f42f4fd9e75/scripts/slave/recipe_modules/libyuv/api.py [modify] https://crrev.com/950814979f68299dabfb96ac838e6f42f4fd9e75/scripts/slave/recipe_modules/libyuv/chromium_android_config.py [modify] https://crrev.com/950814979f68299dabfb96ac838e6f42f4fd9e75/scripts/slave/recipe_modules/libyuv/gclient_config.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/b9a10b83e4d4fdf232f6e314b00b7300e09b487a commit b9a10b83e4d4fdf232f6e314b00b7300e09b487a Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Oct 09 09:44:21 2018 Fix pylint issues for /scripts/slave/recipe_modules/dart This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I731b5329659e2a2cf539a427d21cc9c24d49eece Reviewed-on: https://chromium-review.googlesource.com/c/1269684 Commit-Queue: William Hesse <whesse@google.com> Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by: William Hesse <whesse@google.com> [modify] https://crrev.com/b9a10b83e4d4fdf232f6e314b00b7300e09b487a/scripts/slave/recipe_modules/dart/api.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/ff0e9a5c40d11f276d607ae891b3358f1ea0e12b commit ff0e9a5c40d11f276d607ae891b3358f1ea0e12b Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Oct 09 15:55:46 2018 Fix pylint issues for /scripts/slave/recipe_modules/webrtc This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I13a7493f3a1ec3624c0c16e7d20094128e75e5aa Reviewed-on: https://chromium-review.googlesource.com/c/1270030 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Oleh Prypin <oprypin@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/ff0e9a5c40d11f276d607ae891b3358f1ea0e12b/scripts/slave/recipe_modules/webrtc/config.py [modify] https://crrev.com/ff0e9a5c40d11f276d607ae891b3358f1ea0e12b/scripts/slave/recipe_modules/webrtc/chromium_android_config.py [modify] https://crrev.com/ff0e9a5c40d11f276d607ae891b3358f1ea0e12b/scripts/slave/README.recipes.md [modify] https://crrev.com/ff0e9a5c40d11f276d607ae891b3358f1ea0e12b/scripts/slave/recipe_modules/webrtc/steps.py [modify] https://crrev.com/ff0e9a5c40d11f276d607ae891b3358f1ea0e12b/scripts/slave/recipe_modules/webrtc/gclient_config.py [modify] https://crrev.com/ff0e9a5c40d11f276d607ae891b3358f1ea0e12b/scripts/slave/recipe_modules/webrtc/api.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/be1eb42fca7fb139d656c955db30d7dc416ab098 commit be1eb42fca7fb139d656c955db30d7dc416ab098 Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Oct 09 15:58:47 2018 Fix pylint issues for /scripts/slave/recipe_modules/chromium_tests/chromium_perf.py This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: Icc776fe1f8b053c9fd2ce8711e1f61918afd1066 Reviewed-on: https://chromium-review.googlesource.com/c/1268782 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/be1eb42fca7fb139d656c955db30d7dc416ab098/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/5dd9648c3b2bc2cdbd9ccc9fa98d68689cd0dc77 commit 5dd9648c3b2bc2cdbd9ccc9fa98d68689cd0dc77 Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Oct 09 15:59:36 2018 Fix pylint issues for /scripts/slave/recipe_modules/gatekeeper This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I85190424b3fd6dc1658287c17749361e7612367e Reviewed-on: https://chromium-review.googlesource.com/c/1269690 Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/5dd9648c3b2bc2cdbd9ccc9fa98d68689cd0dc77/scripts/slave/recipe_modules/gatekeeper/config.py [modify] https://crrev.com/5dd9648c3b2bc2cdbd9ccc9fa98d68689cd0dc77/scripts/slave/recipe_modules/gatekeeper/api.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/a59b8ffeebac60cd3027ebd6c72daea72f312d95 commit a59b8ffeebac60cd3027ebd6c72daea72f312d95 Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Oct 09 16:42:21 2018 Fix pylint issues for /scripts/slave/recipe_modules/bisect_tester* This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: Ifd94039dad207cd5ae3df9f74ea4c3f8168b0fb1 Reviewed-on: https://chromium-review.googlesource.com/c/1268777 Reviewed-by: Simon Hatch <simonhatch@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/a59b8ffeebac60cd3027ebd6c72daea72f312d95/scripts/slave/recipe_modules/bisect_tester_staging/parse_metric.py [modify] https://crrev.com/a59b8ffeebac60cd3027ebd6c72daea72f312d95/scripts/slave/recipe_modules/bisect_tester/perf_test.py [modify] https://crrev.com/a59b8ffeebac60cd3027ebd6c72daea72f312d95/scripts/slave/recipe_modules/bisect_tester/parse_metric.py [modify] https://crrev.com/a59b8ffeebac60cd3027ebd6c72daea72f312d95/scripts/slave/recipe_modules/bisect_tester_staging/perf_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/c442ae3a7235c741a7e5970561bd21dec8747660 commit c442ae3a7235c741a7e5970561bd21dec8747660 Author: Stephen Martinis <martiniss@chromium.org> Date: Wed Oct 10 03:50:26 2018 Fix pylint issues for /scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I3df19f399d623ac8f257c6ef32d906a93ff47bdf Reviewed-on: https://chromium-review.googlesource.com/c/1268783 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/c442ae3a7235c741a7e5970561bd21dec8747660/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/d6456deb6ac79d1973111c60543380b93e1404bc commit d6456deb6ac79d1973111c60543380b93e1404bc Author: Stephen Martinis <martiniss@chromium.org> Date: Wed Oct 10 04:04:06 2018 Fix pylint issues for /scripts/slave/recipe_modules/swarming This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I32f89ff93c836f97edc8009b13621077f251447a Reviewed-on: https://chromium-review.googlesource.com/c/1270022 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/d6456deb6ac79d1973111c60543380b93e1404bc/scripts/slave/recipe_modules/swarming/unittests/standard_isolated_script_merge_test.py [modify] https://crrev.com/d6456deb6ac79d1973111c60543380b93e1404bc/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json [modify] https://crrev.com/d6456deb6ac79d1973111c60543380b93e1404bc/scripts/slave/recipe_modules/swarming/api.py [modify] https://crrev.com/d6456deb6ac79d1973111c60543380b93e1404bc/scripts/slave/README.recipes.md [modify] https://crrev.com/d6456deb6ac79d1973111c60543380b93e1404bc/scripts/slave/recipe_modules/swarming/unittests/collect_task_test.py [modify] https://crrev.com/d6456deb6ac79d1973111c60543380b93e1404bc/scripts/slave/recipe_modules/swarming/examples/full.py [modify] https://crrev.com/d6456deb6ac79d1973111c60543380b93e1404bc/scripts/slave/recipe_modules/swarming/resources/merge_api.py [modify] https://crrev.com/d6456deb6ac79d1973111c60543380b93e1404bc/scripts/slave/recipe_modules/swarming/unittests/standard_gtest_merge_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/1818af87754b2e3deda3cc58b2d7b086fa325e22 commit 1818af87754b2e3deda3cc58b2d7b086fa325e22 Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Oct 11 03:46:54 2018 Fix pylint issues for /scripts/slave/recipe_modules/emulator This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I0f5d9f865680efaf236ba6d812e6d8e27e0a6dc5 Reviewed-on: https://chromium-review.googlesource.com/c/1269686 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/1818af87754b2e3deda3cc58b2d7b086fa325e22/scripts/slave/recipe_modules/emulator/config.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/671902215d78f0cd4649d5503f7d32270fa281e9 commit 671902215d78f0cd4649d5503f7d32270fa281e9 Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Oct 11 04:41:44 2018 Fix pylint issues for /scripts/slave/recipe_modules/test_utils This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I9a67d87042d32448ffb66d7cf92711b8f4eed5c1 Reviewed-on: https://chromium-review.googlesource.com/c/1270026 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/671902215d78f0cd4649d5503f7d32270fa281e9/scripts/slave/README.recipes.md [modify] https://crrev.com/671902215d78f0cd4649d5503f7d32270fa281e9/scripts/slave/recipe_modules/test_utils/test_api.py [modify] https://crrev.com/671902215d78f0cd4649d5503f7d32270fa281e9/scripts/slave/recipe_modules/test_utils/api.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/8a9af6392c7bcc679a0d1bf051d32e38d2a1cf38 commit 8a9af6392c7bcc679a0d1bf051d32e38d2a1cf38 Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Oct 11 18:16:22 2018 Fix pylint issues for /scripts/slave/recipe_modules/perf_try* This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: Ib6ab9df7379b6ca2d6a8cf62fff8b460087741c6 Reviewed-on: https://chromium-review.googlesource.com/c/1270020 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/8a9af6392c7bcc679a0d1bf051d32e38d2a1cf38/scripts/slave/README.recipes.md [modify] https://crrev.com/8a9af6392c7bcc679a0d1bf051d32e38d2a1cf38/scripts/slave/recipe_modules/perf_try/api.py [modify] https://crrev.com/8a9af6392c7bcc679a0d1bf051d32e38d2a1cf38/scripts/slave/recipe_modules/perf_try_staging/build_state.py [modify] https://crrev.com/8a9af6392c7bcc679a0d1bf051d32e38d2a1cf38/scripts/slave/recipe_modules/perf_try/build_state.py [modify] https://crrev.com/8a9af6392c7bcc679a0d1bf051d32e38d2a1cf38/scripts/slave/recipe_modules/perf_try_staging/api.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/e3fae3fcac7862596bc8972fc504fe529d543d72 commit e3fae3fcac7862596bc8972fc504fe529d543d72 Author: Stephen Martinis <martiniss@chromium.org> Date: Mon Oct 15 22:11:19 2018 Fix pylint issues for /scripts/slave/recipe_modules/test_results This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. R=iannucci@chromium.org Bug: 893240 Change-Id: I32d688fa56dc39c4ccb7b34e29fc1956f0f8d59b Reviewed-on: https://chromium-review.googlesource.com/c/1270024 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/e3fae3fcac7862596bc8972fc504fe529d543d72/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py [modify] https://crrev.com/e3fae3fcac7862596bc8972fc504fe529d543d72/scripts/slave/recipe_modules/test_results/config.py [modify] https://crrev.com/e3fae3fcac7862596bc8972fc504fe529d543d72/scripts/slave/recipe_modules/test_results/resources/tests/json_results_generator_unittest.py [modify] https://crrev.com/e3fae3fcac7862596bc8972fc504fe529d543d72/scripts/slave/recipe_modules/test_results/api.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/b69be5a6f9c743599b351a55a78eff1ad7af70ec commit b69be5a6f9c743599b351a55a78eff1ad7af70ec Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Oct 16 19:33:03 2018 Fix pylint issues for /scripts/slave/recipe_modules/chromium_android This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I59c8f16278ae1489a5e879913f5e91ebb6526b73 Reviewed-on: https://chromium-review.googlesource.com/c/1268780 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> [delete] https://crrev.com/f839e9e6f10ccf4674526536a6b6c9502b820f5e/scripts/slave/recipe_modules/chromium_android/examples/full.expected/restart_usb_builder_basic.json [modify] https://crrev.com/b69be5a6f9c743599b351a55a78eff1ad7af70ec/scripts/slave/recipe_modules/chromium_android/tests/run_webview_cts_test.py [modify] https://crrev.com/b69be5a6f9c743599b351a55a78eff1ad7af70ec/scripts/slave/recipe_modules/chromium_android/examples/full.py [modify] https://crrev.com/b69be5a6f9c743599b351a55a78eff1ad7af70ec/scripts/slave/README.recipes.md [modify] https://crrev.com/b69be5a6f9c743599b351a55a78eff1ad7af70ec/scripts/slave/recipe_modules/chromium_android/config.py [modify] https://crrev.com/b69be5a6f9c743599b351a55a78eff1ad7af70ec/scripts/slave/recipe_modules/chromium_android/api.py [modify] https://crrev.com/b69be5a6f9c743599b351a55a78eff1ad7af70ec/scripts/slave/recipe_modules/chromium_android/chromium_config.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/bb3e66265b38dc80b7fdd260bc713a915aa455af commit bb3e66265b38dc80b7fdd260bc713a915aa455af Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Oct 16 19:50:35 2018 Fix pylint issues for /scripts/slave/recipe_modules/cronet This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. # Need to manually roll, since this removes an argument. Recipe-Nontrivial-Roll: build_limited_scripts_slave Bug: 893240 Change-Id: I0ba8297af59b591de730396f70046e64fcd5d5fb Reviewed-on: https://chromium-review.googlesource.com/c/1269675 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> [modify] https://crrev.com/bb3e66265b38dc80b7fdd260bc713a915aa455af/scripts/slave/README.recipes.md [modify] https://crrev.com/bb3e66265b38dc80b7fdd260bc713a915aa455af/scripts/slave/recipes/cronet.py [modify] https://crrev.com/bb3e66265b38dc80b7fdd260bc713a915aa455af/scripts/slave/recipe_modules/cronet/tests/run_tests.py [modify] https://crrev.com/bb3e66265b38dc80b7fdd260bc713a915aa455af/scripts/slave/recipe_modules/cronet/api.py [modify] https://crrev.com/bb3e66265b38dc80b7fdd260bc713a915aa455af/scripts/slave/recipe_modules/cronet/examples/full.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/dedf6db26932357848350c105ae18dd063ccc099 commit dedf6db26932357848350c105ae18dd063ccc099 Author: Stephen Martinis <martiniss@google.com> Date: Tue Oct 16 20:25:56 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/2b556c0f0bfc9938b24912cbb69e9140720f8735 commit 2b556c0f0bfc9938b24912cbb69e9140720f8735 Author: Stephen Martinis <martiniss@google.com> Date: Wed Oct 17 18:07:07 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/e0d330924a6b8659761e28e5e10951d0c82d6676 commit e0d330924a6b8659761e28e5e10951d0c82d6676 Author: Stephen Martinis <martiniss@chromium.org> Date: Wed Oct 17 21:01:13 2018 Fix pylint issues for /scripts/slave/recipe_modules This CL fixes pylint issues in this directory. It is part of a large refactor; pylint will be required for recipe modules once most of the existing issues have been fixed. This CL was uploaded by git cl split. Bug: 893240 Change-Id: I4ba243b1187e39746269a344c7514bbeac024bf0 Reviewed-on: https://chromium-review.googlesource.com/c/1270032 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/e0d330924a6b8659761e28e5e10951d0c82d6676/scripts/slave/README.recipes.md [modify] https://crrev.com/e0d330924a6b8659761e28e5e10951d0c82d6676/scripts/slave/recipe_modules/archive/resources/zip_archive.py [modify] https://crrev.com/e0d330924a6b8659761e28e5e10951d0c82d6676/scripts/slave/recipe_modules/archive/api.py [modify] https://crrev.com/e0d330924a6b8659761e28e5e10951d0c82d6676/scripts/slave/recipe_modules/git_clone_bundler/api.py [modify] https://crrev.com/e0d330924a6b8659761e28e5e10951d0c82d6676/scripts/slave/recipe_modules/archive/resources/filter_build_files.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/5a33c68595688b43f93d922f78f44a4e0d25fd76 commit 5a33c68595688b43f93d922f78f44a4e0d25fd76 Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Oct 18 00:09:29 2018 Fix pylint issues These have landed since I fixed other pylint issues in these files previously. Bug: 893240 Change-Id: Id2f8273222ce17d4331239ca7dceec231987bab3 Reviewed-on: https://chromium-review.googlesource.com/c/1284441 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org> [modify] https://crrev.com/5a33c68595688b43f93d922f78f44a4e0d25fd76/scripts/slave/recipe_modules/swarming/examples/full.py [modify] https://crrev.com/5a33c68595688b43f93d922f78f44a4e0d25fd76/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py [modify] https://crrev.com/5a33c68595688b43f93d922f78f44a4e0d25fd76/scripts/slave/recipe_modules/ios/api.py [modify] https://crrev.com/5a33c68595688b43f93d922f78f44a4e0d25fd76/scripts/slave/recipe_modules/chromium_tests/steps.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/308f581eca2af8866cd3967c8080e7ea95e65298 commit 308f581eca2af8866cd3967c8080e7ea95e65298 Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Oct 18 21:46:28 2018 Enable pylint for recipe_modules This was previously disabled. I've been fixing most of the pylint issues we have in other CLs. Once those CLs land, I'll land this CL. Bug: 893240 Change-Id: Ief1c2482b25b34714d81d82f97bfdea6e119affa Reviewed-on: https://chromium-review.googlesource.com/c/1270033 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Garrett Beaty <gbeaty@chromium.org> [modify] https://crrev.com/308f581eca2af8866cd3967c8080e7ea95e65298/scripts/slave/recipe_modules/webrtc/api.py [modify] https://crrev.com/308f581eca2af8866cd3967c8080e7ea95e65298/PRESUBMIT.py [modify] https://crrev.com/308f581eca2af8866cd3967c8080e7ea95e65298/scripts/slave/recipe_modules/webrtc/steps.py
I did it!
Comment 1 by bugdroid1@chromium.org
, Oct 8