New issue
Advanced search Search tips

Issue 893238 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 8
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Eos] Work item - Add headers to fetch catalog request

Project Member Reported by petewil@chromium.org, Oct 8

Issue description

We should add headers to the get catalog request.

X-Device-Scale-Factor will be the header name.  The value will be a floating point for the display density (for instance, 1.0 on a device with 160 DPI resolution)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a4a2d1f1bc4aa754b56ab16c07cf12a58e0589b

commit 7a4a2d1f1bc4aa754b56ab16c07cf12a58e0589b
Author: Pete Williamson <petewil@chromium.org>
Date: Mon Oct 08 19:04:10 2018

[EoS] Add scale factor header  to catalog request.

This adds the scale factor of the android device into a new header
called "X-Device-Scale-Factor". The scale factor is derived from
android.util.DisplayMetrics.density.

Change-Id: Ia8f26435fdc780354e753f87632aca03811c144a

Bug:  893238 
Change-Id: Ia8f26435fdc780354e753f87632aca03811c144a
Reviewed-on: https://chromium-review.googlesource.com/c/1260208
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597636}
[modify] https://crrev.com/7a4a2d1f1bc4aa754b56ab16c07cf12a58e0589b/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
[modify] https://crrev.com/7a4a2d1f1bc4aa754b56ab16c07cf12a58e0589b/chrome/browser/android/explore_sites/explore_sites_bridge.cc
[modify] https://crrev.com/7a4a2d1f1bc4aa754b56ab16c07cf12a58e0589b/chrome/browser/android/explore_sites/explore_sites_bridge.h
[modify] https://crrev.com/7a4a2d1f1bc4aa754b56ab16c07cf12a58e0589b/chrome/browser/android/explore_sites/explore_sites_fetcher.cc
[modify] https://crrev.com/7a4a2d1f1bc4aa754b56ab16c07cf12a58e0589b/chrome/browser/android/explore_sites/explore_sites_fetcher.h
[modify] https://crrev.com/7a4a2d1f1bc4aa754b56ab16c07cf12a58e0589b/chrome/browser/android/explore_sites/explore_sites_fetcher_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment