make r-w-t support isolated-script-test-... cmd flag aliases |
|||||
Issue description
Findit plans to support a set of cmd flag aliases, so we need r-w-t to support them as well.
The aliases are:
1. --isolated-script-test-filter=A::B::C
a. Current cmd flag(alias) is: --gtest_filter=A:B:C
2. --isolated-script-test-repeat=30
a. Current cmd flag(alias) is:--gtest_repeat=30
b. To be consistent with currently supported test types, the exec
order should be ABCABCABC...
3. --isolated-script-test-launcher-retry-limit=0
a. Current cmd flag(alias) is:--test-launcher-retry-limit=0
4. --isolated-script-test-also-run-disabled-tests
a. Current cmd flag(alias) is:--gtest_also_run_disabled_tests
,
Oct 8
Keep in mind that Findit needs to wait for 2+ weeks after the new flags are added, since Findit uses isolates of pretty old revisions Please file a bug for me on the gtest launcher, and another one on Android test runner for jbudorick@. Robert, John, and I need to work on this around the same time, so that we could switch over sooner.
,
Oct 8
Please create a meta bug for this effort, and make these bugs block it
,
Oct 8
,
Oct 10
@robertma: John and I are almost done with the change for Android test runner and gtest runner. It would be great if we could start the change on r-w-t as well.
,
Oct 10
Understood. The description looks good. I'll tweak the flags.
,
Oct 10
Many thanks!
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b57f8cdf347d74620fc047ad7ff37bc7088d229 commit 6b57f8cdf347d74620fc047ad7ff37bc7088d229 Author: Robert Ma <robertma@chromium.org> Date: Thu Oct 11 15:49:50 2018 [blinkpy] Add some flag aliases to r-w-t FindIt is moving away from always using the --gtest* flags to a new set of unified flags for all isolated script tests. This change adds the new flags (as aliases to existing flags). The old --gtest* aliases will be removed when FindIt no longer uses them. Bug: 893235 Change-Id: I728c1377fb5f43a37b2cea7392c455af7b4a0e73 Reviewed-on: https://chromium-review.googlesource.com/c/1273886 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#598778} [modify] https://crrev.com/6b57f8cdf347d74620fc047ad7ff37bc7088d229/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py [modify] https://crrev.com/6b57f8cdf347d74620fc047ad7ff37bc7088d229/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests_unittest.py
,
Oct 11
Chan, could you give me a heads up when FindIt no longer uses the --gtest* flags? (Or which bug shall I subscribe to?)
,
Oct 11
Thank you so much for the quick change! Please refer to issue 894485, after that bug is closed, feel free to remove --gtest_xxx cmd flags in r-w-t. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by chanli@chromium.org
, Oct 8