Tapping borderds of the launcher doesn't deactivate the searchbox. |
||||||||
Issue descriptionChrome Version: 71.3567.0 What steps will reproduce the problem? (1) Activate searchbox (2) tap edges of launcher (not app grid view) What is the expected result? Sbox deactivates What happens instead? Sbox does not deactivate We need tests for this regression IMO.
,
Oct 11
,
Oct 17
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62162751f2e30bac3c591068326e6a2df5c69ebe commit 62162751f2e30bac3c591068326e6a2df5c69ebe Author: Kevin Strohbehn <ginko@google.com> Date: Thu Oct 18 00:07:43 2018 Simplifies Tap/Long-Press handling in AppsGridView These events were being sent up to AppListView, then back to AppsGridView. In reality, these events can all be handled before letting them pass through, just based on the nearest tile. Bug: 893216 Change-Id: I9fee2bd9be03efb54a90b07d87bcf9f1a772d6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1286129 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#600611} [modify] https://crrev.com/62162751f2e30bac3c591068326e6a2df5c69ebe/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/62162751f2e30bac3c591068326e6a2df5c69ebe/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/62162751f2e30bac3c591068326e6a2df5c69ebe/ash/app_list/views/apps_container_view.cc [modify] https://crrev.com/62162751f2e30bac3c591068326e6a2df5c69ebe/ash/app_list/views/apps_grid_view.cc [modify] https://crrev.com/62162751f2e30bac3c591068326e6a2df5c69ebe/ash/app_list/views/apps_grid_view.h
,
Oct 18
,
Oct 18
,
Oct 19
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb60658b4846c51296249badb5fe24b233fe11f6 commit fb60658b4846c51296249badb5fe24b233fe11f6 Author: Kevin Strohbehn <ginko@google.com> Date: Fri Oct 19 21:23:41 2018 Merge Approved M71: Simplifies Tap/Long-Press handling in AppsGridView These events were being sent up to AppListView, then back to AppsGridView. In reality, these events can all be handled before letting them pass through, just based on the nearest tile. Bug: 893216 Change-Id: I9fee2bd9be03efb54a90b07d87bcf9f1a772d6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1286129 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600611}(cherry picked from commit 62162751f2e30bac3c591068326e6a2df5c69ebe) Reviewed-on: https://chromium-review.googlesource.com/c/1292594 Cr-Commit-Position: refs/branch-heads/3578@{#172} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/fb60658b4846c51296249badb5fe24b233fe11f6/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/fb60658b4846c51296249badb5fe24b233fe11f6/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/fb60658b4846c51296249badb5fe24b233fe11f6/ash/app_list/views/apps_container_view.cc [modify] https://crrev.com/fb60658b4846c51296249badb5fe24b233fe11f6/ash/app_list/views/apps_grid_view.cc [modify] https://crrev.com/fb60658b4846c51296249badb5fe24b233fe11f6/ash/app_list/views/apps_grid_view.h
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb60658b4846c51296249badb5fe24b233fe11f6 Commit: fb60658b4846c51296249badb5fe24b233fe11f6 Author: ginko@google.com Commiter: weidongg@chromium.org Date: 2018-10-19 21:23:41 +0000 UTC Merge Approved M71: Simplifies Tap/Long-Press handling in AppsGridView These events were being sent up to AppListView, then back to AppsGridView. In reality, these events can all be handled before letting them pass through, just based on the nearest tile. Bug: 893216 Change-Id: I9fee2bd9be03efb54a90b07d87bcf9f1a772d6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1286129 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600611}(cherry picked from commit 62162751f2e30bac3c591068326e6a2df5c69ebe) Reviewed-on: https://chromium-review.googlesource.com/c/1292594 Cr-Commit-Position: refs/branch-heads/3578@{#172} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by newcomer@chromium.org
, Oct 9