New issue
Advanced search Search tips

Issue 893207 link

Starred by 1 user
Status: Fixed
Owner:
xingliu@chromium.org
Closed: Oct 22
Cc:
qin...@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Android video thumbnail may crash in utility process when processing no media file

Project Member Reported by xingliu@chromium.org, Oct 8 
Chrome Version: 71.*
OS:Android.

VideoFrameExtractor::ReadVideoFrame may return null for invalid video file, the following code will crash when accessing the pointer of the AVPacket.

Comment 1 by xingliu@chromium.org, Oct 8

Cc: dtrainor@chromium.org qin...@chromium.org
Labels: M-71

Comment 2 by xingliu@chromium.org, Oct 8 

Also VideoDecoderConfig in the mojo file should be VideoDecoderConfig? (IDL to const base::Optional<VideoDecoderConfig>&). Or serialization will fail on invalid media file and utility process will be killed abnormally.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/514809123e6d11e890b6eb234bb89b0335010fe4

commit 514809123e6d11e890b6eb234bb89b0335010fe4
Author: Xing Liu <xingliu@chromium.org>
Date: Thu Oct 11 17:22:12 2018

Android video thumbnail: Better error handling.

This CL fixes two crash in video thumbnail flow.

1. VideoFrameExtractor::ReadVideoFrame can return nullptr, and should
report error.

2. Invalid media::VideoDecoderConfig will cause mojo serialization
failure, instead we can use optional to gracefully handle this case.

TBR=dcheng@chromium.org

Bug:  893207 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0dc3115c1a25231535c0743723103d870cbe59fd
Reviewed-on: https://chromium-review.googlesource.com/c/1269724
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598814}
[modify] https://crrev.com/514809123e6d11e890b6eb234bb89b0335010fe4/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadMediaParserTest.java
[modify] https://crrev.com/514809123e6d11e890b6eb234bb89b0335010fe4/chrome/browser/android/download/download_media_parser.cc
[modify] https://crrev.com/514809123e6d11e890b6eb234bb89b0335010fe4/chrome/browser/android/download/download_media_parser.h
[modify] https://crrev.com/514809123e6d11e890b6eb234bb89b0335010fe4/chrome/services/media_gallery_util/media_parser_android.cc
[modify] https://crrev.com/514809123e6d11e890b6eb234bb89b0335010fe4/chrome/services/media_gallery_util/media_parser_android_unittest.cc
[modify] https://crrev.com/514809123e6d11e890b6eb234bb89b0335010fe4/chrome/services/media_gallery_util/public/mojom/media_parser.mojom
[modify] https://crrev.com/514809123e6d11e890b6eb234bb89b0335010fe4/media/filters/android/video_frame_extractor.cc
[modify] https://crrev.com/514809123e6d11e890b6eb234bb89b0335010fe4/media/filters/android/video_frame_extractor_unittest.cc

Comment 4 by xingliu@chromium.org, Oct 22

Status: Fixed (was: Started)
►

Sign in to add a comment