New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 893196 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue v8:8271
issue v8:8272



Sign in to add a comment

Migrate ICU to 63.1

Project Member Reported by ftang@chromium.org, Oct 8

Issue description

ICU 63 should be released soon. Let's update ICU in Chrome. 

folding from 
https://bugs.chromium.org/p/v8/issues/detail?id=8271
and
https://bugs.chromium.org/p/v8/issues/detail?id=8272
as a chromium bug

 
Blocking: v8:8271 v8:8272
Until a better / mor elegant way is figured out to deal with git "partial mirroring" (I'll talk to Chrome-infra), I'll use git-equivalent of 'svn export' in my update.sh script. 

https://stackoverflow.com/questions/160608/do-a-git-export-like-svn-export

git archive --format=tar \
--remote=ssh://remote_server/remote_repository master | tar -xf -


To export particular path inside the repo add as many paths as you wish as last argument to git, e.g.:

git archive --format=tar \
--remote=ssh://remote_server/remote_repository master path1/ path2/ | tar -xv

I'll also file an upstream bug to exclude .gitattributes, .gitignore from archiving. 

Components: UI>Internationalization
Blockedon: 854387
Blockedon: -854387
github does not support 'git archive' protocol. And, the method in comment 5 does not allow downloading icu4c only. (the whole thing has to be downloaded). 

However, github supports 'svn' (viewing git repos as svn repo). See https://stackoverflow.com/questions/9609835/git-export-from-github-remote-repository  . 

So, I can just change the svn url in my update script to point to a new location. 
 

Canary builds pass all the tests for Chrome and v8. We're good to go. 

The only bot failing is Node.js bot and that's a known issue (it happens everytime ICU is updated).  

https://chromium-review.googlesource.com/c/chromium/src/+/1289168

https://chromium-review.googlesource.com/c/v8/v8/+/1289369 
Cc: ftang@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/deps/icu.git/+/42d5027992a0946942839b8821765e1512afbc21

commit 42d5027992a0946942839b8821765e1512afbc21
Author: Jungshik Shin <jshin@chromium.org>
Date: Wed Oct 24 08:31:46 2018

Update ICU to 63.1 + Chromium patches


What's new in ICU 63.1:
  - CLDR 34 locale data
    http://cldr.unicode.org/index/downloads/cldr-34-1
  - Curreny/Number range format
  - Better/more support for field iterator in formatters - necessary
    for v8's Ecma 402 implementation
  - Better/safer locale APIs
  - See http://site.icu-project.org/download/62 for more details.

The update steps are recorded :
  https://chromium.googlesource.com/chromium/deps/icu/+log/ccad447..b0bb170

* Update update.sh to point to ICU's new repo location

* Import the pristine copy of ICU 63.1 and update BUILD
  files with update.sh

* Update and apply locale data patches
  - locale_google.patch
  - locale1.patch

* Adjust/apply/update brkiter related patches
  - In place of line_normal_fi.txt, add back
    line_loose.txt (Finnish tailoring is absorbed into
    root).
  - data/brkitr/* are adjusted accordingly
  - android/brkitr.patch and flutter/brkitr.patch
    are updated
  - Use 'normal-cj' for line-breaking in zh/ja locales by
    default
  - Apply cjdict.patch and khmerdict.patch

* Apply build-related patches
  {wpo,vscomp,data.build,data.build.win,data_symb}.patch

* Delete obsolete patches and apply still relevant patches
  {isvalidenum,doubleconversion}.patch

* Fix a Windows compilation issue with clang

* Drop pluralrange.res from flutter's data

* Update the timezone data update script and update the
  timezone data to 2018f

* Add VES (new Venezuelan currency) to and drop VEF
   - {scripts/android}/currencies.list

* ICU data files are rebuilt (up to 22kB increase)

   ICU 62      ICU 63   Platform
   6364832     6375056  android
   4907488     4916608  cast
  10246512    10268240  common
    884352      880512  flutter
   6351136     6361376  ios


TBR=ftang@chromium.org
Bug:  893196 ,  v8:8272 
Change-Id: Icac23f6c065f38a9b1b4ae397fbe0e6b62934f15
Reviewed-on: https://chromium-review.googlesource.com/c/1296893
Reviewed-by: Jungshik Shin <jshin@chromium.org>

[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/APIChangeReport.html
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/BUILD.gn
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/README.chromium
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/android/brkitr.patch
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/android/currencies.list
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/android/icudtl.dat
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/cast/icudtl.dat
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/common/icudtb.dat
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/common/icudtl.dat
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/flutter/brkitr.patch
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/flutter/flutter-removed-resources.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/flutter/icudtl.dat
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/icu.gyp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/icu.gypi
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/ios/icudtl.dat
[delete] https://crrev.com/b029971f1fc6b20d06887c47c7afebd5881f31ff/patches/arm_align.patch
[add] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/patches/atomic_win.patch
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/patches/data.build.win.patch
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/patches/data_symb.patch
[delete] https://crrev.com/b029971f1fc6b20d06887c47c7afebd5881f31ff/patches/decimalformat_align.patch
[delete] https://crrev.com/b029971f1fc6b20d06887c47c7afebd5881f31ff/patches/greek_lowercase.patch
[delete] https://crrev.com/b029971f1fc6b20d06887c47c7afebd5881f31ff/patches/langtag_bcp47.patch
[delete] https://crrev.com/b029971f1fc6b20d06887c47c7afebd5881f31ff/patches/langtag_uext.patch
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/patches/locale1.patch
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/patches/locale_google.patch
[delete] https://crrev.com/b029971f1fc6b20d06887c47c7afebd5881f31ff/patches/locid_map.patch
[delete] https://crrev.com/b029971f1fc6b20d06887c47c7afebd5881f31ff/patches/nf_maxsig.patch
[delete] https://crrev.com/b029971f1fc6b20d06887c47c7afebd5881f31ff/patches/reldate_quarter.patch
[delete] https://crrev.com/b029971f1fc6b20d06887c47c7afebd5881f31ff/patches/wintz_detection.patch
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/patches/wpo.patch
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/readme.html
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/scripts/currencies.list
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/scripts/data_files_to_preserve.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/scripts/make_data.sh
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/scripts/make_data_all.sh
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/scripts/update.sh
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/Doxyfile.in
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/Makefile.in
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/Makefile.in
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/bmpset.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/bytesinkutil.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/bytesinkutil.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/bytestriebuilder.cpp
[add] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/characterproperties.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/charstr.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/charstr.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/cmemory.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/dictbe.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/edits.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/loadednormalizer2impl.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/locdspnm.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/locid.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/mutex.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/norm2_nfc_data.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/normalizer2.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/normalizer2impl.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/normalizer2impl.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/propname_data.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/putil.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/putilimp.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/rbbi.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/rbbi_cache.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/rbbirb.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/rbbiscan.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/rbbitblb.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/rbbitblb.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/serv.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/sharedobject.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/stringtriebuilder.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ubidi.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ubiditransform.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucln_cmn.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucnv.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucnv2022.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucnv_ct.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucnv_u16.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucnv_u32.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucnv_u8.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucnvhz.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucnvmbcs.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucnvsel.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucol_swp.cpp
[add] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucptrie.cpp
[add] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucptrie_impl.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ucurr.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/udata.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/udataswp.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/uhash.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/uinvchar.h
[add] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ulayout_props_data.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/uloc.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/uloc_keytype.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/uloc_tag.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ulocimp.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/umapfile.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/umapfile.h
[add] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/umutablecptrie.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/umutex.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unames.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/bytestream.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/casemap.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/char16ptr.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/docmain.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/edits.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/enumset.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/filteredbrk.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/icuplug.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/locid.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/messagepattern.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/normalizer2.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/platform.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/ptypes.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/rbbi.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/stringoptions.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/stringtriebuilder.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/ubidi.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/ubiditransform.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/uchar.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/ucnv.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/uconfig.h
[add] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/ucpmap.h
[add] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/ucptrie.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/ucurr.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/uenum.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/umachine.h
[add] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/umutablecptrie.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/uniset.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/unistr.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/uobject.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/urename.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/uset.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/ustring.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/utf16.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/utypes.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unicode/uvernum.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unifiedcache.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/uniset.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/uniset_props.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/unistr.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/uprops.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/uprops.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/uresbund.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/uresdata.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ushape.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/usprep.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/ustrcase.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/utext.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/utrie.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/utrie2.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/utrie2.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/utrie2_builder.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/utrie2_impl.h
[add] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/utrie_swap.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/uts46.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/wintz.cpp
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/common/wintz.h
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/config/mh-mingw
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/config/mh-mingw64
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/configure
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/configure.ac
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/brkitr/brkfiles.mk
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/brkitr/brklocal.mk
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/brkitr/ja.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/brkitr/root.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/brkitr/rules/line.txt
[delete] https://crrev.com/b029971f1fc6b20d06887c47c7afebd5881f31ff/source/data/brkitr/rules/line_fi.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/brkitr/rules/line_loose.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/brkitr/rules/line_loose_cj.txt
[delete] https://crrev.com/b029971f1fc6b20d06887c47c7afebd5881f31ff/source/data/brkitr/rules/line_loose_fi.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/brkitr/rules/line_normal.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/brkitr/rules/line_normal_cj.txt
[delete] https://crrev.com/b029971f1fc6b20d06887c47c7afebd5881f31ff/source/data/brkitr/rules/line_normal_fi.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/brkitr/zh.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/brkitr/zh_Hant.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/build.xml
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/cldr-icu-readme.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/af.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/am.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/ar.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/as.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/az.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/be.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/bg.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/bn.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/bs.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/bs_Cyrl.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/ca.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/chr.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/colfiles.mk
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/cs.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/cy.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/da.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/de.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/de_AT.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/dsb.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/ee.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/el.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/en_US_POSIX.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/eo.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/es.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/et.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/fa.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/fa_AF.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/fi.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/fil.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/fo.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/fr_CA.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/gl.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/gu.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/ha.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/haw.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/he.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/hi.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/hr.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/hsb.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/hu.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/hy.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/ig.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/is.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/ja.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/ka.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/kk.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/kl.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/km.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/kn.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/ko.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/kok.txt
[add] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/ku.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/ky.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/lkt.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/ln.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/lo.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/lt.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/lv.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc21/source/data/coll/mk.txt
[modify] https://crrev.com/42d5027992a0946942839b8821765e1512afbc
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5afd3007276ae994a1c9fc5bb7da7363babb76e3

commit 5afd3007276ae994a1c9fc5bb7da7363babb76e3
Author: Jungshik Shin <jshin@chromium.org>
Date: Mon Oct 29 04:14:19 2018

Roll ICU to ICU 63.1 + Chromium patches

See https://chromium.googlesource.com/chromium/deps/icu/+/42d5027
for changes.

Change CurrencyFormatting unit test to be more robust against
CLDR data change in space characters (U+0020, U+00A0, U+202F).

Removes unnecessary/version-specific 'using namespace icu_62'.

    locale data update/addition in CLDR and the addition
    of line_loose rule for v8's Ecma 402 Intl.Segmenter
    implementation. ICU code size increase of 20kB is also
    necessary to support new character properties (Indic_*).  It can
    potentially save the code size elsewhere (e.g. Blink's shaping
    code). EcmaScrpt Unicode regex is likely to need them soon.

Binary-Size: ICU data increase of 9.8 kB is expected because of the
Bug:  893196 ,  v8:8272 
Test: *_unittests, layout_tests, webkit* tests
Change-Id: Ib9fd7f75a025dd0d727a1b8774849a13381f6e63
Reviewed-on: https://chromium-review.googlesource.com/c/1289168
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603410}
[modify] https://crrev.com/5afd3007276ae994a1c9fc5bb7da7363babb76e3/DEPS
[modify] https://crrev.com/5afd3007276ae994a1c9fc5bb7da7363babb76e3/chrome/android/javatests/src/org/chromium/chrome/browser/payments/CurrencyFormatterTest.java
[modify] https://crrev.com/5afd3007276ae994a1c9fc5bb7da7363babb76e3/components/payments/core/currency_formatter_unittest.cc
[modify] https://crrev.com/5afd3007276ae994a1c9fc5bb7da7363babb76e3/content/browser/font_unique_name_lookup/font_unique_name_lookup.cc
[modify] https://crrev.com/5afd3007276ae994a1c9fc5bb7da7363babb76e3/third_party/blink/common/font_unique_name_lookup/icu_fold_case_util.cc

Status: Fixed (was: Started)
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a46bc035913e012e47accdf8360713adfaff4fe5

commit a46bc035913e012e47accdf8360713adfaff4fe5
Author: Jungshik Shin <jshin@chromium.org>
Date: Tue Oct 30 05:01:18 2018

Prepare for ICU roll to 63.1

In Chromium tree, ICU is rolled to 63.1. And, auto-roller will soon
try to roll ICU in v8 to 63.1.  Due to a nodejs trybot issue,
autoroll needs a manual intervention. In the meantime, this CL
will get rid of other blocking issues for ICU update.

Prepare for the ICU roll by revising test/intl as following:

* Line breaking loose mode is now supported in the
Chromium's copy of ICU. Adjust the test expectation.

* ICU's uloc_* can handle overlong locale ids. Drop tests
that are not valid any more.

Once ICU is rolled, a couple of TSAN-suppressed tests can
be unsuppressed, but that has to be done in a separate CL.

Bug:  chromium:893196 , v8:8272 ,  v8:8110 
Test: intl/*, test262/test402/*
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I17f11457b61376b1e8d41bbbc951fa6cd3355a54
Reviewed-on: https://chromium-review.googlesource.com/c/1289369
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57105}
[modify] https://crrev.com/a46bc035913e012e47accdf8360713adfaff4fe5/test/intl/general/invalid-locale.js
[modify] https://crrev.com/a46bc035913e012e47accdf8360713adfaff4fe5/test/intl/segmenter/segment-line-following-modes.js

Sign in to add a comment