New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 893188 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Oct 9
Cc:
█ chromium...@skia-public.iam.gserviceaccount.com
wangxianzhu@chromium.org
uwyiming@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

393.5% regression in rendering.mobile/frame_times at 596786:596997

Project Member Reported by wangxianzhu@chromium.org, Oct 8 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 8 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=893188

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=26a5e13d9931aa4b109439d59ddb36a981a6a046a36d5b4849b0ff292cd63ec8


Bot(s) for this bug's original alert(s):

Android Nexus6 WebView Perf

rendering.mobile - Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Oct 8

Cc: chromium...@skia-public.iam.gserviceaccount.com
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1285aa96e40000

Roll src/third_party/catapult e3b37a4725a0..1b6e81b579f3 (1 commits) by chromium-autoroll@skia-public.iam.gserviceaccount.com
https://chromium.googlesource.com/chromium/src/+/08b8a680b62a8d79006145c1d6e739fd7f7f3a64
frame_times: 209.1 → 962.7 (+753.6)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Oct 8 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/13367318e40000

Roll src/third_party/catapult e3b37a4725a0..1b6e81b579f3 (1 commits) by chromium-autoroll@skia-public.iam.gserviceaccount.com
https://chromium.googlesource.com/chromium/src/+/08b8a680b62a8d79006145c1d6e739fd7f7f3a64
frame_times: 209.4 → 253.3 (+43.87)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/rendering-benchmarks

Comment 7 by wangxianzhu@chromium.org, Oct 9

Cc: -chromium...@skia-public.iam.gserviceaccount.com uwyiming@google.com
Status: WontFix (was: Assigned)
This seems an expected outcome of the culprit change.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Oct 9

Cc: chromium...@skia-public.iam.gserviceaccount.com
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/135f7118e40000

Roll src/third_party/catapult e3b37a4725a0..1b6e81b579f3 (1 commits) by chromium-autoroll@skia-public.iam.gserviceaccount.com
https://chromium.googlesource.com/chromium/src/+/08b8a680b62a8d79006145c1d6e739fd7f7f3a64
frame_times: 201.3 → No values

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/rendering-benchmarks

Comment 9 by uwyiming@google.com, Nov 2 

This is strange. My change fixes an error in Web Page Replay Go where wpr replay does not inject scripts correctly. May I inquire to what this test does and what the test page looks like?

Comment 10 by wangxianzhu@google.com, Nov 5 

I think the pages are defined in https://cs.chromium.org/chromium/src/tools/perf/page_sets/data/rendering_mobile.json?q=rendering.mobile&sq=package:chromium&dr=C.

I thought the test frame_times became more accurate because the CL made injected scripts correct. Isn't it the case?
►

Sign in to add a comment