New issue
Advanced search Search tips

Issue 893187 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

TabDragging/DetachToBrowserTabDragControllerTest.DragToSeparateWindow/0 is flaky on SingleProcessMash

Project Member Reported by mukai@chromium.org, Oct 8

Issue description

It is failing several times on the FYI bot.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b417202473ac5b5cd16d41cbe4e71152747855bf

commit b417202473ac5b5cd16d41cbe4e71152747855bf
Author: Jun Mukai <mukai@chromium.org>
Date: Wed Oct 10 21:45:20 2018

Reform TopmostWindowObserver's Add/RemoveObserver

It seems current AddObserver / RemoveObserver logic is wrong and
that seems causing test flakiness of  crbug.com/893187 .

This CL fixes the logic a bit to be more redundant. Added a new
test file to cover those patterns.

BUG= 893187 
TEST=services_unittests covers

Change-Id: I33193e174bc72fc82d9c19990face9a59ca545c8
Reviewed-on: https://chromium-review.googlesource.com/c/1269999
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598521}
[modify] https://crrev.com/b417202473ac5b5cd16d41cbe4e71152747855bf/services/ws/BUILD.gn
[modify] https://crrev.com/b417202473ac5b5cd16d41cbe4e71152747855bf/services/ws/test_window_service_delegate.cc
[modify] https://crrev.com/b417202473ac5b5cd16d41cbe4e71152747855bf/services/ws/test_window_service_delegate.h
[modify] https://crrev.com/b417202473ac5b5cd16d41cbe4e71152747855bf/services/ws/topmost_window_observer.cc
[modify] https://crrev.com/b417202473ac5b5cd16d41cbe4e71152747855bf/services/ws/topmost_window_observer.h
[add] https://crrev.com/b417202473ac5b5cd16d41cbe4e71152747855bf/services/ws/topmost_window_observer_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment