New issue
Advanced search Search tips

Issue 893183 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature



Sign in to add a comment

Omnibox Pedal Suggestions

Project Member Reported by orinj@chromium.org, Oct 8

Issue description

Feature description: Omnibox Pedals accelerate the user's ability to get things done within Chrome by suggesting navigations and actions when queries suggest that the user intends to embark on any of a specific set of user journeys.
 
Thanks. Can you add a comment listing the CLs that have already landed when you get a chance?
Changes landed before this bug was created:

* crrev.com/c/1235200 : Create field trial feature for omnibox pedal suggestions
* crrev.com/c/1235205 : Create chrome://flags entry for omnibox pedal suggestion feature
* crrev.com/c/1235208 : [omnibox] Enhance tab switch button to support alternative strings
* crrev.com/c/1247223 : Add new omnibox_pedal* code and related changes for a single Pedal

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76893bb36cffd276951b4209df61a5fe93b64e1d

commit 76893bb36cffd276951b4209df61a5fe93b64e1d
Author: Orin Jaworski <orinj@chromium.org>
Date: Mon Oct 08 18:12:54 2018

[omnibox] Connect first omnibox Pedal into autocomplete system

This CL modifies a few sections of code related to autocomplete to
introduce the OmniboxPedalProvider and get its first Pedal working.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I3847a7bf60768cf043da3b3b5a15e651f379dc1a

Bug: 893183
Change-Id: I3847a7bf60768cf043da3b3b5a15e651f379dc1a
Reviewed-on: https://chromium-review.googlesource.com/c/1247192
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597610}
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/chrome/browser/autocomplete/chrome_autocomplete_provider_client.h
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/chrome/browser/ui/app_list/search/omnibox_result.cc
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/autocomplete_controller.cc
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/autocomplete_match.h
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/autocomplete_match_type.cc
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/autocomplete_match_type.h
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/autocomplete_provider_client.h
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/autocomplete_result.cc
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/autocomplete_result.h
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/mock_autocomplete_provider_client.cc
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/mock_autocomplete_provider_client.h
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/omnibox_metrics_provider.cc
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/omnibox_pedal.cc
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/omnibox_pedal.h
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/components/omnibox/browser/omnibox_popup_model.cc
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.h
[modify] https://crrev.com/76893bb36cffd276951b4209df61a5fe93b64e1d/ios/chrome/browser/ui/omnibox/omnibox_util.mm

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79644173d907d8999eeca46b94d590809867d767

commit 79644173d907d8999eeca46b94d590809867d767
Author: Orin Jaworski <orinj@chromium.org>
Date: Mon Oct 08 23:58:04 2018

[omnibox] Add more simple navigation Pedals

This CL adds the following navigation Pedals which navigate much like
ClearBrowsingData: ChangeSearchEngine, ManagePasswords, ChangeHomePage,
and UpdateCreditCard.

Change-Id: I5464d1b7f64da7c90917b3ebd6cfa5f00b04df31

Bug: 893183
Change-Id: I5464d1b7f64da7c90917b3ebd6cfa5f00b04df31
Reviewed-on: https://chromium-review.googlesource.com/c/1266200
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597742}
[modify] https://crrev.com/79644173d907d8999eeca46b94d590809867d767/components/omnibox/browser/omnibox_pedal.cc
[modify] https://crrev.com/79644173d907d8999eeca46b94d590809867d767/components/omnibox/browser/omnibox_pedal.h
[modify] https://crrev.com/79644173d907d8999eeca46b94d590809867d767/components/omnibox/browser/omnibox_pedal_provider.cc
[modify] https://crrev.com/79644173d907d8999eeca46b94d590809867d767/components/omnibox_strings.grdp

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caedc10e2263a0f337bc163ee821efbb32f381d4

commit caedc10e2263a0f337bc163ee821efbb32f381d4
Author: Orin Jaworski <orinj@chromium.org>
Date: Tue Oct 09 22:59:43 2018

[omnibox] Encapsulate Pedal implementations with registration function

This is a refactoring CL that moves Pedal implementations into their
own omnibox_pedal_implementations.cc file.

Bug: 893183
Change-Id: I6b3802cbeb53919b8b2d421146cb5a33371f58ab
Reviewed-on: https://chromium-review.googlesource.com/c/1271581
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598119}
[modify] https://crrev.com/caedc10e2263a0f337bc163ee821efbb32f381d4/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/caedc10e2263a0f337bc163ee821efbb32f381d4/components/omnibox/browser/omnibox_pedal.cc
[modify] https://crrev.com/caedc10e2263a0f337bc163ee821efbb32f381d4/components/omnibox/browser/omnibox_pedal.h
[add] https://crrev.com/caedc10e2263a0f337bc163ee821efbb32f381d4/components/omnibox/browser/omnibox_pedal_implementations.cc
[add] https://crrev.com/caedc10e2263a0f337bc163ee821efbb32f381d4/components/omnibox/browser/omnibox_pedal_implementations.h
[modify] https://crrev.com/caedc10e2263a0f337bc163ee821efbb32f381d4/components/omnibox/browser/omnibox_pedal_provider.cc
[modify] https://crrev.com/caedc10e2263a0f337bc163ee821efbb32f381d4/components/omnibox/browser/omnibox_pedal_provider.h
[modify] https://crrev.com/caedc10e2263a0f337bc163ee821efbb32f381d4/components/omnibox/browser/omnibox_pedal_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88278acbe665dd77c5e0352b537e47be1459ff3e

commit 88278acbe665dd77c5e0352b537e47be1459ff3e
Author: Orin Jaworski <orinj@chromium.org>
Date: Wed Oct 10 22:11:12 2018

[omnibox] Fix invalid classifications on Pedal matches

A DCHECK was triggering because the classifications from the
source AutocompleteMatch were not appropriate for the new
contents after ApplyPedal, so the fix was to reset them.

Bug: 893183
Change-Id: I0b77dc310fd4733cab57c9eb58c8daba18f8653f
Reviewed-on: https://chromium-review.googlesource.com/c/1274061
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598533}
[modify] https://crrev.com/88278acbe665dd77c5e0352b537e47be1459ff3e/components/omnibox/browser/autocomplete_match.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/117ee57cfa6f55fea10bb429719080f1dc1bee74

commit 117ee57cfa6f55fea10bb429719080f1dc1bee74
Author: Orin Jaworski <orinj@chromium.org>
Date: Thu Oct 11 20:15:23 2018

[omnibox] Add translation Pedal; reset/revert omnibox on Execute

The translation Pedal prompts user for page translation when executed.
This is an action Pedal that does not result in navigation, so now
the omnibox is also reset/reverted when any Pedal executes.

Bug: 893183
Change-Id: Ib9d3e31489ab740045e823e57786ef05b61d0916
Reviewed-on: https://chromium-review.googlesource.com/c/1274458
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598909}
[modify] https://crrev.com/117ee57cfa6f55fea10bb429719080f1dc1bee74/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
[modify] https://crrev.com/117ee57cfa6f55fea10bb429719080f1dc1bee74/chrome/browser/ui/omnibox/chrome_omnibox_client.h
[modify] https://crrev.com/117ee57cfa6f55fea10bb429719080f1dc1bee74/components/omnibox/browser/omnibox_client.h
[modify] https://crrev.com/117ee57cfa6f55fea10bb429719080f1dc1bee74/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/117ee57cfa6f55fea10bb429719080f1dc1bee74/components/omnibox/browser/omnibox_pedal.cc
[modify] https://crrev.com/117ee57cfa6f55fea10bb429719080f1dc1bee74/components/omnibox/browser/omnibox_pedal_implementations.cc
[modify] https://crrev.com/117ee57cfa6f55fea10bb429719080f1dc1bee74/components/omnibox_strings.grdp

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e4bcd0c5bcb8d0bf4f3e8d3e7bf29d64059f43d

commit 5e4bcd0c5bcb8d0bf4f3e8d3e7bf29d64059f43d
Author: Orin Jaworski <orinj@chromium.org>
Date: Tue Oct 16 19:35:05 2018

[omnibox] Add Pedal to launch incognito window

This CL introduces another experimental action Pedal to launch
an incognito tab in a new browser window.

Bug: 893183
Change-Id: I9b0a671f80037ee646a8bfa6401474d9315e430d
Reviewed-on: https://chromium-review.googlesource.com/c/1274204
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600082}
[modify] https://crrev.com/5e4bcd0c5bcb8d0bf4f3e8d3e7bf29d64059f43d/chrome/browser/chrome_main_browsertest.cc
[modify] https://crrev.com/5e4bcd0c5bcb8d0bf4f3e8d3e7bf29d64059f43d/chrome/browser/signin/chrome_signin_helper.cc
[modify] https://crrev.com/5e4bcd0c5bcb8d0bf4f3e8d3e7bf29d64059f43d/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/5e4bcd0c5bcb8d0bf4f3e8d3e7bf29d64059f43d/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/5e4bcd0c5bcb8d0bf4f3e8d3e7bf29d64059f43d/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/5e4bcd0c5bcb8d0bf4f3e8d3e7bf29d64059f43d/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
[modify] https://crrev.com/5e4bcd0c5bcb8d0bf4f3e8d3e7bf29d64059f43d/chrome/browser/ui/omnibox/chrome_omnibox_client.h
[modify] https://crrev.com/5e4bcd0c5bcb8d0bf4f3e8d3e7bf29d64059f43d/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/5e4bcd0c5bcb8d0bf4f3e8d3e7bf29d64059f43d/components/omnibox/browser/omnibox_client.h
[modify] https://crrev.com/5e4bcd0c5bcb8d0bf4f3e8d3e7bf29d64059f43d/components/omnibox/browser/omnibox_pedal_implementations.cc
[modify] https://crrev.com/5e4bcd0c5bcb8d0bf4f3e8d3e7bf29d64059f43d/components/omnibox_strings.grdp

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f65e09ce096a1376b15b4db2d7fc4e6ce2ed11c8

commit f65e09ce096a1376b15b4db2d7fc4e6ce2ed11c8
Author: Orin Jaworski <orinj@chromium.org>
Date: Wed Oct 17 20:50:18 2018

[omnibox] Add Pedal to update Chrome by restarting browser

This CL adds another experimental omnibox Pedal to restart Chrome,
intended to help the user update Chrome.

Bug: 893183
Change-Id: I3371f053044bae6dd9fe0c46a63a6b394695201c
Reviewed-on: https://chromium-review.googlesource.com/c/1281162
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600545}
[modify] https://crrev.com/f65e09ce096a1376b15b4db2d7fc4e6ce2ed11c8/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
[modify] https://crrev.com/f65e09ce096a1376b15b4db2d7fc4e6ce2ed11c8/chrome/browser/ui/omnibox/chrome_omnibox_client.h
[modify] https://crrev.com/f65e09ce096a1376b15b4db2d7fc4e6ce2ed11c8/components/omnibox/browser/omnibox_client.h
[modify] https://crrev.com/f65e09ce096a1376b15b4db2d7fc4e6ce2ed11c8/components/omnibox/browser/omnibox_pedal_implementations.cc
[modify] https://crrev.com/f65e09ce096a1376b15b4db2d7fc4e6ce2ed11c8/components/omnibox_strings.grdp

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abf577a725e9b5e4b7f12f998b55821433ecdebc

commit abf577a725e9b5e4b7f12f998b55821433ecdebc
Author: Orin Jaworski <orinj@chromium.org>
Date: Fri Nov 09 02:23:24 2018

[omnibox] Connect PedalProvider to AutocompleteClientProvider

Some Pedals need to be filtered by application state regardless
of whether a query suggestion triggers the Pedal suggestion, and
to do this requires a context that can inform the Pedal system
during autocomplete time (as opposed to the later execution time).
AutocompleteClientProvider is the abstract base class for this purpose,
and works well, so it is used by this CL for the first instance
of Pedal filtering: the UpdateChrome Pedal is filtered when no
update is ready.

Bug: 893183
Change-Id: I3344b26600188c0c952ea81dba1e90a6b4133318
Reviewed-on: https://chromium-review.googlesource.com/c/1297587
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606701}
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/chrome/browser/autocomplete/chrome_autocomplete_provider_client.h
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/chrome/browser/upgrade_detector/upgrade_detector.h
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/components/omnibox/browser/BUILD.gn
[add] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/components/omnibox/browser/autocomplete_provider_client.cc
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/components/omnibox/browser/autocomplete_provider_client.h
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/components/omnibox/browser/mock_autocomplete_provider_client.cc
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/components/omnibox/browser/mock_autocomplete_provider_client.h
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/components/omnibox/browser/omnibox_pedal.cc
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/components/omnibox/browser/omnibox_pedal.h
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/components/omnibox/browser/omnibox_pedal_implementations.cc
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/components/omnibox/browser/omnibox_pedal_provider.cc
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/components/omnibox/browser/omnibox_pedal_provider.h
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/components/omnibox/browser/omnibox_pedal_provider_unittest.cc
[modify] https://crrev.com/abf577a725e9b5e4b7f12f998b55821433ecdebc/components/omnibox/browser/omnibox_pedal_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/531370c7df21709cfeeb2d01fca61a6c482effa4

commit 531370c7df21709cfeeb2d01fca61a6c482effa4
Author: Orin Jaworski <orinj@chromium.org>
Date: Mon Nov 12 22:34:52 2018

[omnibox] Use two-line suggestion styling for Pedals

Pedal suggestions are styled like new answers and entities
with this CL. The logic for deciding layout is also clarified.

Bug: 893183
Change-Id: Id7f4ad9e8a0d6aeffcbe623db65f29107aa79b52
Reviewed-on: https://chromium-review.googlesource.com/c/1330709
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607356}
[modify] https://crrev.com/531370c7df21709cfeeb2d01fca61a6c482effa4/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
[modify] https://crrev.com/531370c7df21709cfeeb2d01fca61a6c482effa4/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.h
[modify] https://crrev.com/531370c7df21709cfeeb2d01fca61a6c482effa4/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/531370c7df21709cfeeb2d01fca61a6c482effa4/components/omnibox/browser/autocomplete_match.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cda1d4006f79296014f2fbacbc5323c5d04daaa

commit 4cda1d4006f79296014f2fbacbc5323c5d04daaa
Author: Orin Jaworski <orinj@chromium.org>
Date: Wed Nov 14 22:23:25 2018

[omnibox] Enable AutocompleteMatch instance to select its vector icon

This CL makes vector icon selection for AutocompleteMatch instances more
direct and simple by moving some of the complexity out of a static
method that was increasingly requiring callers to examine fields of the
instance to compose the call.  By empowering instances to use available
state for icon selection, it is now easy to specialize.  This was done
first for Drive document icons, and will also be used to differentiate
Pedals.  This CL only specializes one using an omnibox icon but all
Pedals will get their own.

Bug: 893183
Change-Id: I460c6202f1220b18091a9178f471464943190072
Reviewed-on: https://chromium-review.googlesource.com/c/1329895
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608144}
[modify] https://crrev.com/4cda1d4006f79296014f2fbacbc5323c5d04daaa/chrome/browser/android/vr/autocomplete_controller.cc
[modify] https://crrev.com/4cda1d4006f79296014f2fbacbc5323c5d04daaa/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/4cda1d4006f79296014f2fbacbc5323c5d04daaa/components/omnibox/browser/autocomplete_match.h
[modify] https://crrev.com/4cda1d4006f79296014f2fbacbc5323c5d04daaa/components/omnibox/browser/omnibox_pedal.cc
[modify] https://crrev.com/4cda1d4006f79296014f2fbacbc5323c5d04daaa/components/omnibox/browser/omnibox_pedal.h
[modify] https://crrev.com/4cda1d4006f79296014f2fbacbc5323c5d04daaa/components/omnibox/browser/omnibox_pedal_implementations.cc
[modify] https://crrev.com/4cda1d4006f79296014f2fbacbc5323c5d04daaa/components/omnibox/browser/omnibox_popup_model.cc
[modify] https://crrev.com/4cda1d4006f79296014f2fbacbc5323c5d04daaa/components/omnibox/browser/omnibox_view.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c409ed974927e2da7357ffe09eaf1a750edd205

commit 6c409ed974927e2da7357ffe09eaf1a750edd205
Author: Orin Jaworski <orinj@chromium.org>
Date: Thu Jan 17 02:42:35 2019

[omnibox] Improve Pedal triggering with natural concept detection

The first method of triggering Pedals used small sets of known
match suggestions, and did not cover most of the possible ways
that users might indicate their intention.  This CL dramatically
expands the space of acceptable queries by checking match text
against small sets of concepts.  When all required concepts
are present, with or without non-required concepts, with no
extraneous text uncovered by the concept set, the Pedal triggers.
This approach efficiently represents large sets of trigger
suggestions without wasting a lot of space on string structures.

Bug: 893183
Change-Id: I75a8ce1510a732c3ea38088ec21b7b3e828c1617
Reviewed-on: https://chromium-review.googlesource.com/c/1402026
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623530}
[modify] https://crrev.com/6c409ed974927e2da7357ffe09eaf1a750edd205/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/6c409ed974927e2da7357ffe09eaf1a750edd205/components/omnibox/browser/omnibox_pedal.cc
[modify] https://crrev.com/6c409ed974927e2da7357ffe09eaf1a750edd205/components/omnibox/browser/omnibox_pedal.h
[modify] https://crrev.com/6c409ed974927e2da7357ffe09eaf1a750edd205/components/omnibox/browser/omnibox_pedal_implementations.cc
[modify] https://crrev.com/6c409ed974927e2da7357ffe09eaf1a750edd205/components/omnibox/browser/omnibox_pedal_implementations.h
[add] https://crrev.com/6c409ed974927e2da7357ffe09eaf1a750edd205/components/omnibox/browser/omnibox_pedal_implementations_unittest.cc
[modify] https://crrev.com/6c409ed974927e2da7357ffe09eaf1a750edd205/components/omnibox/browser/omnibox_pedal_provider.h
[modify] https://crrev.com/6c409ed974927e2da7357ffe09eaf1a750edd205/components/omnibox/browser/omnibox_pedal_unittest.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4caa328720e40e61dbee085f45d49ba2c3cb8640

commit 4caa328720e40e61dbee085f45d49ba2c3cb8640
Author: Orin Jaworski <orinj@chromium.org>
Date: Fri Jan 18 00:18:17 2019

[omnibox] Add exhaustive unit test for Pedal concept matching

This CL adds a unit test to check possible interactions between
synonym groups and Pedals for all existing implementations. The
test documents and ensures that exactly one Pedal is triggered
for each literal expression, regardless of synonym order.

Bug: 893183
Change-Id: I35e93e7511a504c260d498186b04d0a81bf3d804
Reviewed-on: https://chromium-review.googlesource.com/c/1416973
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623925}
[modify] https://crrev.com/4caa328720e40e61dbee085f45d49ba2c3cb8640/components/omnibox/browser/omnibox_pedal.h
[modify] https://crrev.com/4caa328720e40e61dbee085f45d49ba2c3cb8640/components/omnibox/browser/omnibox_pedal_implementations_unittest.cc

Sign in to add a comment