New issue
Advanced search Search tips

Issue 893153 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 8
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

Flaky Compile Failure - obj/chrome/browser/apps/platform_apps/api/api_registration/generated_api_registration.obj

Project Member Reported by waff...@chromium.org, Oct 8

Issue description

FAILED:
[61302/75808] CXX obj/chrome/browser/apps/platform_apps/api/api_registration/generated_api_registration.obj
  FAILED: obj/chrome/browser/apps/platform_apps/api/api_registration/generated_api_registration.obj 
  C:\b\swarming\w\ir\cache\goma\client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes  -imsvc..\..\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\win_sdk\Include\10.0.17134.0\um -imsvc..\..\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\win_sdk\Include\10.0.17134.0\shared -imsvc..\..\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\win_sdk\Include\10.0.17134.0\winrt -imsvc..\..\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\win_sdk\Include\10.0.17134.0\ucrt -imsvc..\..\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\include -imsvc..\..\third_party\depot_tools\win_toolchain\vs_files\3bc0ec615cf20ee342f3bc29bc991b5ad66d8d2c\VC\Tools\MSVC\14.14.26428\atlmfc\include -DV8_DEPRECATION_WARNINGS -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED "-DCR_CLANG_REVISION=\"343342-1\"" -D_HAS_NODISCARD -D_HAS_EXCEPTIONS=0 -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000002 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DENABLE_IPC_FUZZER -DWEBP_EXTERN=extern -DUSE_EGL -DTOOLKIT_VIEWS=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=wchar_t -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_WIN -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 "-DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\"" -DGR_GL_FUNCTION_TYPE=__stdcall -DLEVELDB_PLATFORM_CHROMIUM=1 -DDeleteFile=DeleteFileW -DLEVELDB_PLATFORM_CHROMIUM=1 -DV8_DEPRECATION_WARNINGS -I../.. -Igen -Igen -I../../third_party/libyuv/include -I../../third_party/libwebp/src -I../../third_party/wtl/include -I../../third_party/khronos -I../../gpu -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/webrtc_overrides -I../../third_party/webrtc -I../../third_party/abseil-cpp -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/docs -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/pathops -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/codec -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/skia/modules/skottie/include -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/libwebm/source -I../../v8/include -Igen/v8/include -Igen -I../../third_party/perfetto/include -Igen/third_party/perfetto/protos -Igen/third_party/perfetto/protos -Igen/third_party/perfetto/protos -I../../third_party/flatbuffers/src/include /utf-8 /X -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -fcomplete-member-pointers /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- -fmsc-version=1911 -m32 /Brepro /W4 -Wimplicit-fallthrough -Wthread-safety /WX /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 /wd4200 /wd4201 /wd4204 /wd4221 /wd4245 /wd4267 /wd4305 /wd4389 /wd4702 /wd4701 /wd4703 /wd4661 /wd4706 /wd4715 /wd4267 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -Wno-defaulted-function-deleted /O1 /Ob2 /Oy- /Zc:inline /Gw /Oi /MT -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-inconsistent-missing-override -Wno-exit-time-destructors /TP /wd4577 /GR- /c gen/chrome/browser/apps/platform_apps/api/generated_api_registration.cc /Foobj/chrome/browser/apps/platform_apps/api/api_registration/generated_api_registration.obj /Fd"obj/chrome/browser/apps/platform_apps/api/api_registration_cc.pdb"
  In file included from gen/chrome/browser/apps/platform_apps/api/generated_api_registration.cc:7:
  ../..\chrome/browser/apps/platform_apps/api/media_galleries/media_galleries_api.h(23,10):  fatal error: 'chrome/common/apps/platform_apps/api/media_galleries.h' file not found
  #include "chrome/common/apps/platform_apps/api/media_galleries.h"
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  1 error generated.


Passes on following build, where I notice
  [3170/75808] CXX obj/chrome/common/apps/platform_apps/api/generated_api_types/media_galleries.obj
is in the output (media_galleries.obj was never built in the failing build).

I suspect a dependency is undeclared after https://chromium-review.googlesource.com/c/chromium/src/+/1255584 and the build fails whenever ninja runs the api_registration before the generated_api_types.

Devlin: Should chrome/browser/apps/platform_apps/api:api_registration declare a dependency on chrome/common/apps/platform_apps/api? (In order to pick up the chrome/common/apps/platform_apps/api:generated_api_types?)

I don't really understand this stuff, so that's just my best guess.
 
Status: Started (was: Untriaged)
On it.

The dependency right now is that the api_registration target is including the API files, but not depending on them.  Even though the immediate error is for the generated_api_types include, the right fix here is to add chrome/browser/apps/platform_apps/api as a dependency of chrome/browser/apps/platform_apps/api_registration (c/b/a/platform_apps/api already has a dependency of c/b/c/platform_apps/api, which will cause the generated types to be built).

Thanks for filing!  Are you just seeing this locally?  I haven't seen any bot failures for it.  (Definitely still needs to be fixed, but weighing if we can add the dep vs revert the change)
I found it because it closed the tree and I am sheriff today:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/4034

But I think the flakiness is fairly rare (assuming I am right and it started on Oct 2nd), so if adding the dep can be done within a few hours I advocate adding the dep rather than reverting.
> if adding the dep can be done within a few hours I advocate adding the dep rather than reverting.

Should be doable.  Drafting a CL now.  Thanks!
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b5bc563eeaaea9333f3f9ff2a2dca059486798d

commit 4b5bc563eeaaea9333f3f9ff2a2dca059486798d
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Mon Oct 08 16:48:55 2018

[Platform Apps] Fix dependency chain

The platform apps api_registration target builds the generated
registration for all the Apps-related API functions. This results in a
dependency on those API functions, defined in the
chrome/browser/apps/platform_apps/api target.

Add an explicit dependency from c/b/a/platform_apps/api_registration on
chrome/browser/apps/platform_apps/api. This results in circular
dependencies from c/b/chromeos and c/b/ui; allow these circular includes
as we do for extensions. (Ideally, we can cull some of these, but for
now, let's get the compile working again).

Bug:  893153 
TBR=dominickn@chromium.org

Change-Id: Ia43c135ab6c642e47e04aa3c7f7eecedbc7b871e
Reviewed-on: https://chromium-review.googlesource.com/c/1268517
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597585}
[modify] https://crrev.com/4b5bc563eeaaea9333f3f9ff2a2dca059486798d/chrome/browser/apps/platform_apps/api/BUILD.gn
[modify] https://crrev.com/4b5bc563eeaaea9333f3f9ff2a2dca059486798d/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/4b5bc563eeaaea9333f3f9ff2a2dca059486798d/chrome/browser/ui/BUILD.gn

Status: Fixed (was: Started)
Should be fixed.  Let me know if it crops up again!

Sign in to add a comment