New issue
Advanced search Search tips

Issue 893141 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 10
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 893133



Sign in to add a comment

Componentize SigninTracker unittest

Project Member Reported by blundell@chromium.org, Oct 8

Issue description

I just noticed that this unittest still lives in //chrome. In addition to it just being a bad thing for a test to live in //chrome once the production code has been componentized, in this case the //chrome-level dependencies would impede  crbug.com/893133 . To the componentization mobile!
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20ff9f2bf64d2ecc8c7aaadef12abf8f2d716fa2

commit 20ff9f2bf64d2ecc8c7aaadef12abf8f2d716fa2
Author: Colin Blundell <blundell@chromium.org>
Date: Wed Oct 10 12:43:08 2018

Prepare SigninTracker unittest for componentization

I just noticed that this unittest still lives in //chrome. In addition
to it just being a bad thing for a test to live in //chrome once the
production code has been componentized, in this case the //chrome-level
dependencies would impede  crbug.com/893133 . To the componentization
mobile!

This CL strips the test of all //chrome-level dependencies. A followup
will do the actual move.

Bug:  893141 
Change-Id: I5e1d5f5732252e909d89dfda79928ace42a3a596
Reviewed-on: https://chromium-review.googlesource.com/c/1268279
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598291}
[modify] https://crrev.com/20ff9f2bf64d2ecc8c7aaadef12abf8f2d716fa2/chrome/browser/signin/signin_tracker_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28af7b09ab23d62fb89453a0191c47a1f18c34f5

commit 28af7b09ab23d62fb89453a0191c47a1f18c34f5
Author: Colin Blundell <blundell@chromium.org>
Date: Wed Oct 10 14:32:52 2018

Componentize SigninTracker unittest

https://chromium-review.googlesource.com/c/chromium/src/+/1268279
stripped the test of //chrome-level dependencies, so this is just a
straight file move (and corresponding BUILD.gn change).

Bug:  893141 
Change-Id: I82b8bd6fc339e9d27b26654df182809c80cfbf7a
Reviewed-on: https://chromium-review.googlesource.com/c/1268281
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598316}
[modify] https://crrev.com/28af7b09ab23d62fb89453a0191c47a1f18c34f5/chrome/test/BUILD.gn
[modify] https://crrev.com/28af7b09ab23d62fb89453a0191c47a1f18c34f5/components/signin/core/browser/BUILD.gn
[rename] https://crrev.com/28af7b09ab23d62fb89453a0191c47a1f18c34f5/components/signin/core/browser/signin_tracker_unittest.cc

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43163591383aae707bc56e9af92a3401c1397762

commit 43163591383aae707bc56e9af92a3401c1397762
Author: Colin Blundell <blundell@chromium.org>
Date: Wed Oct 10 16:30:35 2018

Address comments from SigninTracker unittest componentization

Bug:  893141 
Change-Id: I47470bc298e9edc62de40cc9b478f20d5536d256
Reviewed-on: https://chromium-review.googlesource.com/c/1273067
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598358}
[modify] https://crrev.com/43163591383aae707bc56e9af92a3401c1397762/components/signin/core/browser/signin_tracker_unittest.cc

Sign in to add a comment