media::CoreAudioUtil::IsSupported called from browser process when running audio service out of process |
||||||||||
Issue descriptionmedia::CoreAudioUtil::IsSupported is called by SystemMessageWindowWin::DeviceNotifications and SpeechRecognizerImpl::StartRecording from browser process. When running out of process AudioManager is initialized in the audio process So in the browser process media::CoreAudioUtil::IsSupported is not called on the AudioManager thread before being called in other places. What are the consequences? Are these crashes due to that: http://crash/browse?q=STRPOS%28product_name%2C+%27Chrome%27%29+%3E+0+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+EXISTS+%28SELECT+1+FROM+UNNEST%28CrashedStackTrace.StackFrame%29+WHERE+STRPOS%28FunctionName%2C+%27media%3A%3ACoreAudioUtil%3A%3AIsSupported%27%29+%3E+0%29+AND+product_name%3D%27Chrome%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27beta%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27media%3A%3ACoreAudioUtil%3A%3AIsSupported%27#samplereports
,
Oct 8
,
Oct 8
Assigning to Guido for #1 question.
,
Oct 8
,
Oct 8
All the work I did in this area was in M68. Maybe we should remove all calls to Core Audio from the browser process when the audio process is active? Assigning back to marinaciocea@
,
Oct 8
Could it be that it is being called from a task runner that does not have the right traits to make COM calls?
,
Oct 8
#7 then it would always be failing, isn't it? If audio runs out of process, we'll call IsSupported here https://cs.chromium.org/chromium/src/content/browser/browser_main_loop.cc?type=cs&q=system_message_window_&g=0&l=1320
,
Oct 8
,
Oct 8
,
Oct 17
,
Oct 17
,
Oct 22
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by marinaciocea@chromium.org
, Oct 8