New issue
Advanced search Search tips

Issue 893108 link

Starred by 1 user
Status: Duplicate
Merged: issue 807036
Owner: ----
Closed: Oct 8
Cc:
qyears...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SpellChecker re-triggered for every change, even when only changing the description

Project Member Reported by foolip@chromium.org, Oct 8 
https://tricium-prod.appspot.com/run/6542354785763328

This comment:
https://chromium-review.googlesource.com/c/chromium/src/+/1262716/6/third_party/WebKit/LayoutTests/resources/testharness.js#757

Was triggered by my change of the commit message in PS6, but testharness.js didn't change. Moreover, just after, I uploaded a change to testharness.js which did fix the typo.

Having the same typo reported over and over was too much.

Like other review comments, perhaps the same issue, if it still applies, could simply be left as the original comment, unresolved, or at most adding a comment there saying "problem still applies".

Comment 1 by qyears...@chromium.org, Oct 8

Mergedinto: 807036
Status: Duplicate (was: Untriaged)
Thanks for the feedback :-)

This is kind of a combination of:
 - bug 807036 Only run analysis for non-trivial revisions (basically, not on CL description changes)
 - bug 890545 Silence repeated identical warnings on consecutive patchsets.

(I think the latter one should maybe have more thought on how it should be done exactly, but the former one is probably more straightforward.)
►

Sign in to add a comment