Regression :[Print Preview]Invalid page range error message is not displayed on entering invalid range.
Reported by
rp...@etouch.net,
Oct 8
|
||||||
Issue descriptionChrome version: 71.0.3573.0 (Official Build)Revision 540477605ecd461a31985e4fcd67e8786e895802-refs/branch-heads/3573@{#1}(32/64-bit) OS: Windows(7,8,8.1,10),Mac(10.12.6 , 10.13.1 , 10.14.1) and Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, navigate to NTP and press 'Ctrl + p' to open print preview 2. Click on Pages text field and press 'Space bar' key and enter '1' again press 'Space bar' key and enter second value,observe Actual Result: Invalid page range error message is not displayed on entering invalid range. Expected Result: Invalid page range error message should be displayed on entering invalid range. This is regression issue broken in ‘M-71’ and will soon update other info: Good build: 71.0.3558.0 (Revision: 593043) Bad build : 71.0.3559.0 (Revision: 593399) You are probably looking for a change made after 593392 (known good), but no later than 593395 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/5abfe71f2b1de3267ca2fb2718b17c90816f2db0..2225b910dfeb2ee6d16be3a3d58b9f526d672a32?pretty=fuller&n=50 Suspecting: r593394? @rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. Provided suspect through 'Chromium bisect' script because unable to perform bisect using 'per-revision' bisect script. 2. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting error "RuntimeError: We don't have enough builds to bisect" 3. This issue is also reproducible on Dev #71.0.3569.0 Kindly review the attached screen-cast for reference. Thank you. Thank you.
,
Oct 9
,
Oct 9
jshin@, this seems unrelated to 854387. Is there a reason this is marked as blocking that issue?
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33d2f351e23d3db6fbbee5d0835aeaffd997e910 commit 33d2f351e23d3db6fbbee5d0835aeaffd997e910 Author: rbpotter <rbpotter@chromium.org> Date: Wed Oct 10 02:55:10 2018 Print Preview Refresh: Pages settings fixes Fixing: (1) Invalid inputs of form "1 2" were accepted (2) Focus lost when transitioning from invalid to valid input (3) Up/down arrow keys changed the radio button when custom input was focused. (4) Clicking repeatedly on the error message caused the custom radio button to show the ripple animation on each click. Also adding tests to validate issues (1) - (3). Bug: 893106 , 893091 , 893075 , 893066 Change-Id: Iae7fb684b2877f1a72c31f458355e260f2c8edc4 Reviewed-on: https://chromium-review.googlesource.com/c/1270100 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#598192} [modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/browser/resources/print_preview/new/pages_settings.html [modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/browser/resources/print_preview/new/pages_settings.js [modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/browser/resources/print_preview/new/print_preview_shared_css.html [modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/test/data/webui/print_preview/pages_settings_test.js [modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js
,
Oct 11
Update : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.1,10.13.6,10.14.1) using latest Canary build : 71.0.3577.0 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast. Thank you..!!
,
Oct 11
,
Oct 11
[Auto-generated comment by a script] We noticed that this issue is targeted for M-71; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-71 label, otherwise remove Merge-TBD label. Thanks.
,
Oct 11
This landed in 71 as verified by TE in comment 5. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nyerramilli@google.com
, Oct 8