[NTP] Focus ring appears on two places for single field.
Reported by
sanyam.g...@etouch.net,
Oct 8
|
||||||||||
Issue descriptionChrome Version: 71.0.3573.0 (Official Build) 540477605ecd461a31985e4fcd67e8786e895802-refs/branch-heads/3573@{#1} (32/64-bit) OS: Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14.1) & Linux(14.04 LTS) OS. Pre-condition: 1. Enable 'Enable using the Google local NTP', 'New Tab Page Background Selection' and 'New Tab Page Custom Links' under chrome://flags and relaunch the browser. 2. Add few shortcuts and apply background from chrome background. What steps will reproduce the problem? 1. Open NTP, navigate to 'chrome://settings/fonts' and change Minimum font size to 'Huge'. 2. Navigate to NTP, bring focus to 'gear icon' by pressing tab key and press enter. 3. Press tab key on 'Customize this Page' overlay to traverse the focus and observe. Actual Result : Focus ring appears on two places for single field. Expected Result: Focus ring should not appear on two places for single field. This is Non-Regression issue seen from ‘M-69’ from build #69.0.3461.0 , as Focus traversing the options on 'Customize This page' was introduced from this build. Kindly review the attached screen-cast for reference. Thank you..!!
,
Oct 9
,
Oct 9
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c22429999a552e9400ce5fc66a08c2ac38a31cec commit c22429999a552e9400ce5fc66a08c2ac38a31cec Author: Kyle Milka <kmilka@chromium.org> Date: Tue Oct 09 19:56:41 2018 [NTP] Fix menu when font size is huge When font size was set to huge the menu text didn't properly truncate and instead wrapped, distorting the menu/focus rings. To prevent this give each entry a max width. Bug: 893094 Change-Id: I9250ad4765243ef9356cc339416e079fcf629826 Reviewed-on: https://chromium-review.googlesource.com/c/1270948 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#598050} [modify] https://crrev.com/c22429999a552e9400ce5fc66a08c2ac38a31cec/chrome/browser/resources/local_ntp/custom_backgrounds.css
,
Oct 9
,
Oct 11
Update : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.1,10.13.6,10.14.1) using latest Canary build : 71.0.3577.0 and the issue is Fixed. Hence adding TE Verified Labels. Kindly refer the attached screen cast. Thank you..!!
,
Nov 15
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by ramyan@chromium.org
, Oct 8Labels: -Pri-2 Pri-3
Owner: kmilka@chromium.org