New issue
Advanced search Search tips

Issue 893091 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Oct 11
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : In print preview, unnecessarily error message and area below the error message is clickable.

Reported by avsha...@etouch.net, Oct 8 
Chrome Version : 71.0.3573.0 (Official Build) 540477605ecd461a31985e4fcd67e8786e895802-refs/branch-heads/3573@{#1} 32/64 bit
OS : Windows(7, 8, 8.1 ,10), Mac(10.12.6, 10.13.1, 10.14.1, 10.13.6), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and hit 'Ctrl + P' keys to open print preview.
2. In print preview, enter any invalid number in Pages>>Custom text field. (Error message is seen)
3. Click on 'Custom' radio button and then click on error message (or below the error message)
4. Observe.

Actual Result : Unnecessarily error message and area below the error message is clickable.

Expected Result : Error message and area below the error message should not be clickable in print preview.

This is a regression issue broken in ‘M-71’ and below is the bisect information:
Good Build : 71.0.3571.0 (Revision : 596951)
Bad Build : 71.0.3572.0 (Revision : 597445)

Chromium bisect URL :
https://chromium.googlesource.com/chromium/src/+log/f260ed4fe3e452bc85273cbce2701d7e4f00cc4b..e976e2d37125e29e5a916d558232997f809ebb46

Suspect : r597125 ?

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Unable to provide 'per-revision' bisect as it shows "RuntimeError : We don't have enough builds to bisect..." error message for above range. (tried on other machines but still getting the same error)
2. Hence provided suspect through 'Chromium bisect'.

Thank you..!
Actual_Result.mp4
573 KB View Download
Expected_Result.mp4
423 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33d2f351e23d3db6fbbee5d0835aeaffd997e910

commit 33d2f351e23d3db6fbbee5d0835aeaffd997e910
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Oct 10 02:55:10 2018

Print Preview Refresh: Pages settings fixes

Fixing:
(1) Invalid inputs of form "1 2" were accepted
(2) Focus lost when transitioning from invalid to valid input
(3) Up/down arrow keys changed the radio button when custom input was
    focused.
(4) Clicking repeatedly on the error message caused the custom radio
    button to show the ripple animation on each click.

Also adding tests to validate issues (1) - (3).

Bug:  893106 ,  893091 ,  893075 ,  893066 
Change-Id: Iae7fb684b2877f1a72c31f458355e260f2c8edc4
Reviewed-on: https://chromium-review.googlesource.com/c/1270100
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598192}
[modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
[modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/test/data/webui/print_preview/pages_settings_test.js
[modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js

Comment 2 by rbpotter@chromium.org, Oct 11

Status: Fixed (was: Assigned)
The animation now only appears when you first change focus from the text field, rather than repeatedly, which seems like a reasonable behavior here. Marking this fixed.
►

Sign in to add a comment