New issue
Advanced search Search tips

Issue 893081 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Tab focus is seen missing on 'Close' icon at 'Caution : These files are temporary...' message in Guest Files App

Project Member Reported by mmanchala@chromium.org, Oct 8

Issue description

Chrome Version:  71.0.3567.0/11136.0.0 dev channel  Celes, Gnawty & Peppy
OS: Chrome

What steps will reproduce the problem?
(1)Browse as Guest ->Now go to Files App -> observe 'Caution : These files are temporary...' message is seen  
(2)Press 'Tab' until focus is on 'Learn more' link at message -> now again press 'Tab' and observe focus is seen missing on 'Close' icon at message
(Please refer Video)

Expected: Tab focus should be seen on 'Close' icon at message 
Actual: Instead Tab focus is seen missing on 'Close' icon

This is Non-Regression Issue seen from M-62


 
 
Actual_NoTabFocusOnCloseIcon.mp4
15.6 MB Download
Labels: -M-71 CrOSFilesCategory-UI
Status: Available (was: Untriaged)
Labels: Files-Fixit-2018
Owner: sa...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08b514350963b82a26a58a913934b592501c64c2

commit 08b514350963b82a26a58a913934b592501c64c2
Author: Sam McNally <sammc@chromium.org>
Date: Mon Nov 19 04:24:13 2018

Set tabIndex on the low space banner close button.

Bug:  893081 
Change-Id: I0d5e38e3bdb7666252e8dc4d943f40af831fdbcb
Reviewed-on: https://chromium-review.googlesource.com/c/1341443
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609178}
[modify] https://crrev.com/08b514350963b82a26a58a913934b592501c64c2/ui/file_manager/file_manager/foreground/js/ui/banners.js

Status: Fixed (was: Assigned)

Sign in to add a comment