New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 893078 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: ----



Sign in to add a comment

webui_polymer2_interactive_ui_tests (experimental) on flaky on chromium.win/Win10 Tests x64 (dbg)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 8

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of olka@google.com

Dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webui_polymer2_interactive_ui_tests&builder=chromium.win%3AWin10%20Tests%20x64%20(dbg)

Failing tests (they are either all pass, or all fail):
CrSettingsSyncPageTest.All
CrElementsProfileAvatarSelectorFocusTest.All
CrSettingsFocusRowBehavior.FocusTest
PrintPreviewPagesSettingsTest.TabOrder
CrElementsCheckboxTest.All
PrintPreviewPagesSettingsTest.ClearInput
CrSettingsAnimatedPagesTest.All
CrElementsToggleTest.All
CrElementsActionMenuTest.All
PrintPreviewDestinationDialogInteractiveTest.EscapeSearchBox
MaterialHistoryFocusTest.All
PrintPreviewPagesSettingsTest.ValidPageRanges
PrintPreviewPagesSettingsTest.InvalidPageRanges
PrintPreviewNumberSettingsSectionInteractiveTest.BlurResetsEmptyInput
MaterialBookmarksFocusTest.All
CrElementsInputTest.All
PrintPreviewPrintHeaderInteractiveTest.FocusPrintOnReady
PrintPreviewPagesSettingsTest.NupChangesPages
PrintPreviewDestinationDialogInteractiveTest.FocusSearchBox

Example failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933264679385731056/+/steps/webui_polymer2_interactive_ui_tests__experimental__on_Windows-10-15063/0/stdout

Builders failed on: 
- Win10 Tests x64 (dbg): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29


 
Blocking: 875443
May be related to Issue 876224.
Labels: Test-Flaky
Labels: OS-Windows
Owner: dpa...@chromium.org
Cc: rbpotter@chromium.org
Blocking: -875443
Removing blocking label as this does not represent new failures with Polymer 2 vs Polymer 1 and the tests are already marked as experimental. interactive_ui_tests (non-Polymer2) is flaky and marked experimental on this bot (see https://crbug.com/850343), which is why we made the Polymer 2 version also experimental.
Labels: -Sheriff-Chromium
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec52747a5abc25a862843edca761104b3c319764

commit ec52747a5abc25a862843edca761104b3c319764
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Jan 14 16:16:49 2019

[ui_controls] Unflake Send*NotifyWhenDone() on Windows

ui_controls::Send*NotifyWhenDone() can be flaky when invoked after
ui_controls::Send*() as the former can decide to notify based on
observing a yet-to-be-processed event from the latter (or even a
yet-to-be-processed event emitted by unrelated code) and thus notify too
early, resuming and testing conditions that have yet to be met.

Solution: defer the notification if the system queue has pending events
of the same type awaiting dispatch.

Note: mouse move can be repeated indefinitely during a drag, as such we
consider a mouse move complete when it hits the target regardless of
remaining mouse move messages in the queue.

@ BUG OWNERS : This might unflake many currently disabled tests. I've
CC'ed interactive_ui_tests + Windows bugs, please try to re-enable your
test after this CL if you think it might be related.

Bug:  892228 , 640996, 897801,893078,876224,875443,873110,852786,850343,848049,846695,840369,798492,756338,751031,665296,651906,499858,468660,419468,238347,131612,106489,97777,92467
Change-Id: I548856a3948ff71a145435799b4ba3e689561f14
Reviewed-on: https://chromium-review.googlesource.com/c/1392178
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622470}
[modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
[modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/ui/base/test/ui_controls_internal_win.cc

Sign in to add a comment