New issue
Advanced search Search tips

Issue 893067 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 853794



Sign in to add a comment

Only display keyboard accessory on password fields

Project Member Reported by ioanap@chromium.org, Oct 8

Issue description

Instead of showing the accessory every time the keyboard is shown, we limit the scope only to password fields. This ensures that the accessory is displayed in a context for which it can have data and avoids bugs where the accessory sheet is empty.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c7a9771ebb78473ec18a14e664bc76c440bfae8

commit 9c7a9771ebb78473ec18a14e664bc76c440bfae8
Author: Ioana Pandele <ioanap@chromium.org>
Date: Thu Oct 11 11:06:07 2018

[Android] Only show the keyboard accessory on password fields

This CL adds logic to request showing and hiding the KA from the native
side and uses it to limit the KA display only to password fields.

Bug:  893067 
Change-Id: Ic2caf4f3eb483cc13d74b8721159aa39b62764dd
Reviewed-on: https://chromium-review.googlesource.com/c/1268056
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598720}
[modify] https://crrev.com/9c7a9771ebb78473ec18a14e664bc76c440bfae8/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
[modify] https://crrev.com/9c7a9771ebb78473ec18a14e664bc76c440bfae8/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java
[modify] https://crrev.com/9c7a9771ebb78473ec18a14e664bc76c440bfae8/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java
[modify] https://crrev.com/9c7a9771ebb78473ec18a14e664bc76c440bfae8/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java
[modify] https://crrev.com/9c7a9771ebb78473ec18a14e664bc76c440bfae8/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingTestHelper.java
[modify] https://crrev.com/9c7a9771ebb78473ec18a14e664bc76c440bfae8/chrome/browser/android/password_manager/password_accessory_view_android.cc
[modify] https://crrev.com/9c7a9771ebb78473ec18a14e664bc76c440bfae8/chrome/browser/android/password_manager/password_accessory_view_android.h
[modify] https://crrev.com/9c7a9771ebb78473ec18a14e664bc76c440bfae8/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/9c7a9771ebb78473ec18a14e664bc76c440bfae8/chrome/browser/password_manager/password_accessory_controller.cc
[modify] https://crrev.com/9c7a9771ebb78473ec18a14e664bc76c440bfae8/chrome/browser/password_manager/password_accessory_controller.h
[modify] https://crrev.com/9c7a9771ebb78473ec18a14e664bc76c440bfae8/chrome/browser/password_manager/password_accessory_controller_unittest.cc
[modify] https://crrev.com/9c7a9771ebb78473ec18a14e664bc76c440bfae8/chrome/browser/password_manager/password_accessory_view_interface.h

Status: Fixed (was: Started)

Sign in to add a comment