New issue
Advanced search Search tips

Issue 893066 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Oct 11
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Unnecesary focus moves around radio buttons under 'Pages' section.

Reported by dchau...@etouch.net, Oct 8 
Chrome Version: 71.0.3573.0 (Official Build) Revision	540477605ecd461a31985e4fcd67e8786e895802-refs/branch-heads/3573@{#1} (32/64-bit)
OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14.1) and Linux(14.04 LTs).

What steps will reproduce the problem?
1. Launch Chrome and give print command on any webpage.
2. Keep focus on 'All' radio button using 'Tab' key.
3. Now press & hold the down arrow key from keyboard and observe. 

Actual: Unnecessary focus moves around radio buttons and it doesn't stay in text-field after press & hold the down arrow key.
Expected: Focus should stay on 'Pages' text-field.

This is a regression issue, broken in M-71 series, below is manual regression range:

Good build: 71.0.3564.0 (Revision: 594950)
Bad build: 71.0.3565.0 	(Revision: 595251)

You are probably looking for a change made after 594970 (known good), but no later than 594975 (first known bad).

CHANGE-LOG URL:
https://chromium.googlesource.com/chromium/src/+log/44a2e6f192177bd280e7aaec12bfdd20f2cf6641..57f98fb51e315fc4fd03bc3391c8b5865d4138f4

Suspecting: https://chromium.googlesource.com/chromium/src/+/311f9860ef228835607ad94d32504b71d58d58d3

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE:
1. Provided suspect through 'Chromium bisect' script because unable to perform bisect using 'per-revision' bisect script.
2. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting error "RuntimeError: We don't have enough builds to bisect"
3. This issue is also reproducible on Dev #71.0.3569.0

Kindly review the attached screen-cast for reference.

Thank you.
Actual behavior.mp4
680 KB View Download
Expected behavior.mp4
447 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33d2f351e23d3db6fbbee5d0835aeaffd997e910

commit 33d2f351e23d3db6fbbee5d0835aeaffd997e910
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Oct 10 02:55:10 2018

Print Preview Refresh: Pages settings fixes

Fixing:
(1) Invalid inputs of form "1 2" were accepted
(2) Focus lost when transitioning from invalid to valid input
(3) Up/down arrow keys changed the radio button when custom input was
    focused.
(4) Clicking repeatedly on the error message caused the custom radio
    button to show the ripple animation on each click.

Also adding tests to validate issues (1) - (3).

Bug:  893106 ,  893091 ,  893075 ,  893066 
Change-Id: Iae7fb684b2877f1a72c31f458355e260f2c8edc4
Reviewed-on: https://chromium-review.googlesource.com/c/1270100
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598192}
[modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
[modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/test/data/webui/print_preview/pages_settings_test.js
[modify] https://crrev.com/33d2f351e23d3db6fbbee5d0835aeaffd997e910/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js

Comment 2 by rbpotter@chromium.org, Oct 11

Status: Fixed (was: Assigned)
Tested with Canary 71.0.3577.0 on Windows 10 and this is now fixed.
►

Sign in to add a comment