Canvas opacity & UseSurfaceLayerForVideoMS |
|||||||
Issue descriptionChrome Version : 71.0.3567.0 OS Version: 11135.0.0 Is it expected that canvas opacity is always opaque with UseSurfaceLayerForVideoMS? Left: with flag enabled Right: with flag disabled Try it at https://beaufortfrancois.github.io/sandbox/media/picture-in-picture-playground
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72909afdfa5b0708af7e1b9490d1623c61f99173 commit 72909afdfa5b0708af7e1b9490d1623c61f99173 Author: CJ DiMeglio <lethalantidote@chromium.org> Date: Tue Oct 23 21:42:09 2018 Passes opacity information on EnableSubmission. We had incorrectly obmitted an update to the opacity when we first start sending frames. This CL adds that necessary call, and also neatens up the logic to update opacity and rotation, making the effect of these calls clearer. Bug: 893056 Change-Id: I1b6edb4292f1a3a25aa22b61e82c20381d395eb7 Reviewed-on: https://chromium-review.googlesource.com/c/1275525 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602112} [modify] https://crrev.com/72909afdfa5b0708af7e1b9490d1623c61f99173/content/renderer/media/stream/webmediaplayer_ms.cc
,
Oct 23
So this fixes literally just the surfaces opacity problem, but there's still an unrelated issue with PiP that will be addressed separately (still need to make a bug for it based on an email thread)
,
Oct 25
Should I merge this into m71?
,
Oct 29
Picture-in-Picture for media streams is launching in M71 so we should probably have this bug fix in it indeed.
,
Oct 29
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 29
Approving merge to M71 Chrome OS.
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de4c528fddf7ab4feb186fd3e29609844524ede4 Commit: de4c528fddf7ab4feb186fd3e29609844524ede4 Author: lethalantidote@chromium.org Commiter: mlamouri@chromium.org Date: 2018-10-30 16:13:45 +0000 UTC Passes opacity information on EnableSubmission. We had incorrectly obmitted an update to the opacity when we first start sending frames. This CL adds that necessary call, and also neatens up the logic to update opacity and rotation, making the effect of these calls clearer. Bug: 893056 Change-Id: I1b6edb4292f1a3a25aa22b61e82c20381d395eb7 Reviewed-on: https://chromium-review.googlesource.com/c/1275525 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602112}(cherry picked from commit 72909afdfa5b0708af7e1b9490d1623c61f99173) Reviewed-on: https://chromium-review.googlesource.com/c/1307444 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#395} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 30
I merged this as it was conflicting with another merge.
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de4c528fddf7ab4feb186fd3e29609844524ede4 commit de4c528fddf7ab4feb186fd3e29609844524ede4 Author: CJ DiMeglio <lethalantidote@chromium.org> Date: Tue Oct 30 16:13:45 2018 Passes opacity information on EnableSubmission. We had incorrectly obmitted an update to the opacity when we first start sending frames. This CL adds that necessary call, and also neatens up the logic to update opacity and rotation, making the effect of these calls clearer. Bug: 893056 Change-Id: I1b6edb4292f1a3a25aa22b61e82c20381d395eb7 Reviewed-on: https://chromium-review.googlesource.com/c/1275525 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602112}(cherry picked from commit 72909afdfa5b0708af7e1b9490d1623c61f99173) Reviewed-on: https://chromium-review.googlesource.com/c/1307444 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#395} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/de4c528fddf7ab4feb186fd3e29609844524ede4/content/renderer/media/stream/webmediaplayer_ms.cc
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56bc9448d006eb5bc72f90b010cf38a13313b1ee Commit: 56bc9448d006eb5bc72f90b010cf38a13313b1ee Author: liberato@chromium.org Commiter: liberato@chromium.org Date: 2018-10-30 20:43:18 +0000 UTC Revert "Passes opacity information on EnableSubmission." This reverts commit de4c528fddf7ab4feb186fd3e29609844524ede4. Reason for revert: beta build break (had to revert 9b481b8d22752 first) Original change's description: > Passes opacity information on EnableSubmission. > > We had incorrectly obmitted an update to the opacity when we first start > sending frames. This CL adds that necessary call, and also neatens up > the logic to update opacity and rotation, making the effect of these > calls clearer. > > Bug: 893056 > Change-Id: I1b6edb4292f1a3a25aa22b61e82c20381d395eb7 > Reviewed-on: https://chromium-review.googlesource.com/c/1275525 > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#602112}(cherry picked from commit 72909afdfa5b0708af7e1b9490d1623c61f99173) > Reviewed-on: https://chromium-review.googlesource.com/c/1307444 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#395} > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} TBR=mlamouri@chromium.org,lethalantidote@chromium.org Change-Id: If48f5f7b3d5c57bad62a3477caba3eca2a35893d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893056 Reviewed-on: https://chromium-review.googlesource.com/c/1308595 Reviewed-by: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#417} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56bc9448d006eb5bc72f90b010cf38a13313b1ee commit 56bc9448d006eb5bc72f90b010cf38a13313b1ee Author: Frank Liberato <liberato@chromium.org> Date: Tue Oct 30 20:43:18 2018 Revert "Passes opacity information on EnableSubmission." This reverts commit de4c528fddf7ab4feb186fd3e29609844524ede4. Reason for revert: beta build break (had to revert 9b481b8d22752 first) Original change's description: > Passes opacity information on EnableSubmission. > > We had incorrectly obmitted an update to the opacity when we first start > sending frames. This CL adds that necessary call, and also neatens up > the logic to update opacity and rotation, making the effect of these > calls clearer. > > Bug: 893056 > Change-Id: I1b6edb4292f1a3a25aa22b61e82c20381d395eb7 > Reviewed-on: https://chromium-review.googlesource.com/c/1275525 > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#602112}(cherry picked from commit 72909afdfa5b0708af7e1b9490d1623c61f99173) > Reviewed-on: https://chromium-review.googlesource.com/c/1307444 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#395} > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} TBR=mlamouri@chromium.org,lethalantidote@chromium.org Change-Id: If48f5f7b3d5c57bad62a3477caba3eca2a35893d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893056 Reviewed-on: https://chromium-review.googlesource.com/c/1308595 Reviewed-by: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#417} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/56bc9448d006eb5bc72f90b010cf38a13313b1ee/content/renderer/media/stream/webmediaplayer_ms.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by fbeaufort@chromium.org
, Oct 12