New issue
Advanced search Search tips

Issue 893033 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

technical debt: md_bookmark undo shortcut duplicated across C++ And JS

Project Member Reported by chrishall@google.com, Oct 8

Issue description

The shortcut for undo (ctrl-z or command-z) is duplicated across these two files:
src/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
src/chrome/browser/resources/md_bookmarks/command_manager.js

The first is used to generate a text description of the shortcut for accessibility technology, the second handles the keyboard events.

We should consider moving the shortcut definitions out of Javascript and entirely into C++, with C++ then passing them to Javascript for binding and handling.
 
Cc: calamity@chromium.org sky@chromium.org
This duplication was introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/1229737

Sign in to add a comment