[Desktop PWAs] Show CCT UI when out-of-scope in the same origin |
||
Issue descriptionChrome Version: 72 OS: All desktop What steps will reproduce the problem? (After https://crrev.com/c/1242727) (1) Run with --enable-features=kDesktopPWAsStayInWindowName (2) Install PWA https://killer-marmot.appspot.com/web/ (3) Open in a window. (4) Click "Home" link. What is the expected result? The CCT UI should show, because you're out of scope, but on the same origin. What happens instead? The CCT UI (location bar) doesn't show, because you're on the same origin (despite being out of scope). Ideally this would be in M71 at the same time as https://crrev.com/c/1242727 (the CL that adds this flag).
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfd5545986e880096986e4e86d58d61f923821e9 commit cfd5545986e880096986e4e86d58d61f923821e9 Author: Jay Harris <harrisjay@chromium.org> Date: Wed Oct 10 00:47:53 2018 Desktop PWAs show location bar when out-of-scope on the same origin Bug: 893011 Change-Id: I2c8f6d8a0068b8872c744a7def5f41afaacec2bc Reviewed-on: https://chromium-review.googlesource.com/c/1267577 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#598153} [modify] https://crrev.com/cfd5545986e880096986e4e86d58d61f923821e9/chrome/browser/ui/extensions/hosted_app_browser_controller.cc [modify] https://crrev.com/cfd5545986e880096986e4e86d58d61f923821e9/chrome/browser/ui/extensions/hosted_app_browsertest.cc
,
Oct 12
|
||
►
Sign in to add a comment |
||
Comment 1 by mgiuca@chromium.org
, Oct 8