ML Service: Add model load & inference metrics |
||||
Issue descriptionMetrics framework and some basic process-wide metrics were added in crbug.com/881186 . Now we need to add metrics covering TFLite-related events: Remaining metrics needed are: - For model load - For graph executor creation - For inference For each of the above, record: Events enum: requested, success, failures Resource cost: cpu time Resource cost: maybe delta of memory usage
,
Oct 7
,
Oct 7
,
Oct 15
Reassigning to Alan as good starter project :D Alan, viewed from far above, plan is: 1. Do https://chromium.googlesource.com/chromiumos/docs/+/master/developer_guide.md 2. Do this bug :D Let's talk about all the details in the person.
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/54a012d42c5f377ede60f42f640cb2f37f6b0001 commit 54a012d42c5f377ede60f42f640cb2f37f6b0001 Author: Alanlxl <alanlxl@google.com> Date: Thu Nov 01 23:24:47 2018 ml: reassign metrics from amoylan to alanlxl modify the ml/README.md file BUG=chromium:892999 TEST=None Change-Id: Icef1360d94c8604cc19cf104d58cde1af19ce663 Reviewed-on: https://chromium-review.googlesource.com/1297212 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Xinglong Luan <alanlxl@chromium.org> Reviewed-by: Andrew Moylan <amoylan@chromium.org> [modify] https://crrev.com/54a012d42c5f377ede60f42f640cb2f37f6b0001/ml/README.md
,
Dec 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f89281475888972670ed892d7314e538f5273bac commit f89281475888972670ed892d7314e538f5273bac Author: alanlxl <alanlxl@chromium.org> Date: Sun Dec 16 23:41:08 2018 Add histograms for ML Service pre-request metrics Add suffix-based histograms for the following metrics added in Chrome OS CL crrev.com/c/1312494. * Numerical histograms for elapsed time, CPU time and RAM usage of LoadModel, CreateGraphExecutor and Execute * Enum histogram for LoadModel, CreateGraphExecutor and Execute events Bug: 892999 Change-Id: Idba5227aaec328e0f13fbc9116d88f47dc72a452 Reviewed-on: https://chromium-review.googlesource.com/c/1370150 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#617026} [modify] https://crrev.com/f89281475888972670ed892d7314e538f5273bac/tools/metrics/histograms/enums.xml [modify] https://crrev.com/f89281475888972670ed892d7314e538f5273bac/tools/metrics/histograms/histograms.xml
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/cb1f8566b8a889768a5d7013534875a4f57288c1 commit cb1f8566b8a889768a5d7013534875a4f57288c1 Author: alanlxl <alanlxl@chromium.org> Date: Wed Dec 19 09:12:44 2018 ml: add generic metrics to machine learning service Add generic metrics to machine learning service, to log event(success or fail), time_cost, cpu_time_cost and memory_usage BUG=chromium:892999 TEST=Tested with chromium browser by adding fake event in it and monitoring the histograms Change-Id: I3fbc364b18c21fd4f093427670624ced0dd1984b Reviewed-on: https://chromium-review.googlesource.com/1312494 Commit-Ready: Xinglong Luan <alanlxl@chromium.org> Tested-by: Xinglong Luan <alanlxl@chromium.org> Reviewed-by: Andrew Moylan <amoylan@chromium.org> [modify] https://crrev.com/cb1f8566b8a889768a5d7013534875a4f57288c1/ml/graph_executor_impl.cc [modify] https://crrev.com/cb1f8566b8a889768a5d7013534875a4f57288c1/ml/mojom/machine_learning_service.mojom [modify] https://crrev.com/cb1f8566b8a889768a5d7013534875a4f57288c1/ml/mojom/model.mojom [modify] https://crrev.com/cb1f8566b8a889768a5d7013534875a4f57288c1/ml/README.md [modify] https://crrev.com/cb1f8566b8a889768a5d7013534875a4f57288c1/ml/machine_learning_service_impl.cc [modify] https://crrev.com/cb1f8566b8a889768a5d7013534875a4f57288c1/ml/machine_learning_service_impl.h [modify] https://crrev.com/cb1f8566b8a889768a5d7013534875a4f57288c1/ml/model_impl.cc [modify] https://crrev.com/cb1f8566b8a889768a5d7013534875a4f57288c1/ml/mojom/graph_executor.mojom [add] https://crrev.com/cb1f8566b8a889768a5d7013534875a4f57288c1/ml/request_metrics.h |
||||
►
Sign in to add a comment |
||||
Comment 1 by amoylan@chromium.org
, Oct 7