luci-go unable to parse anaconda python versions
Reported by
bhavayan...@gmail.com,
Oct 6
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36 Steps to reproduce the problem: 1. run download_from_google_storage.py 2. 3. What is the expected behavior? What went wrong? When installing v8 via GN using an Anaconda bundled python, luci-go throws an exception. See: https://github.com/denoland/deno/issues/542 I believe this is a bug in luci-go since it's trying to parse the python version (major.minor.patch) from the command: $ python --version On my OSX system python this is "Python 2.7.12" but for Anaconda it's "Python 2.7.15 :: Continuum Analytics, Inc.". Similarly on Windows for which the bug report came in from. Hence there's an exception when parsed by luci-go: "non-canonical Python version string". I believe the fix is to use platform.python_version instead of --version e.g. $ python -c 'import platform; print(platform.python_version())' 2.7.15 Perhaps I am missing something, and please correct me if this is the wrong thread. I am happy to attempt a patch if that's an acceptable/desired fix. Thanks, Bhavay Did this work before? N/A Does this work in other browsers? N/A Chrome version: 69.0.3497.100 Channel: stable OS Version: OS X 10.13.3 Flash Version:
,
Oct 8
,
Oct 8
,
Oct 10
Thanks for filing the issue! From comment#0 it is understood that the issue seems to be triaged by installing v8 via GN using an Anaconda bundled python which is out of scope for us to triage it from our end, hence adding label "TE-NeedsTriageHelp" and requesting some one from respective team to have a look into this and help in further triaging it.
,
Nov 30
This was separately reported in the chromium-discuss ML.
,
Nov 30
Note that we don't recommend anaconda python; vpython is designed to solve a superset of the problem that anaconda python is designed to solve. I'll do some basic verification to see how well this will work after we solve the version parsing problem.
,
Nov 30
Ok, cool, looks like the version thing actually was the only needed change (anaconda seems to work correctly with the fixed vpython on my mac).
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/646290c8765bcebd278998e8c6a5aa55ca903b12 commit 646290c8765bcebd278998e8c6a5aa55ca903b12 Author: Robert Iannucci <iannucci@chromium.org> Date: Fri Nov 30 23:19:26 2018 [vpython] Use platform.python_version instead of --version. This should allow vpython to parse the version string of nonstandard python installations like anaconda. R=tandrii@chromium.org, vadimsh@chromium.org Bug: 892899 Change-Id: I6443178a6cd97ca9525cc13da26f170f9584dfca Reviewed-on: https://chromium-review.googlesource.com/c/1357246 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/646290c8765bcebd278998e8c6a5aa55ca903b12/vpython/application/probe.go [modify] https://crrev.com/646290c8765bcebd278998e8c6a5aa55ca903b12/vpython/python/find.go [modify] https://crrev.com/646290c8765bcebd278998e8c6a5aa55ca903b12/vpython/python/interpreter.go [modify] https://crrev.com/646290c8765bcebd278998e8c6a5aa55ca903b12/vpython/python/interpreter_test.go |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by krajshree@chromium.org
, Oct 7