New issue
Advanced search Search tips

Issue 892889 link

Starred by 1 user
Status: Fixed
Owner:
mcnee@chromium.org
Closed: Oct 31
Cc:
rdevlin....@chromium.org
lazyboy@chromium.org
msarda@chromium.org
lfg@chromium.org
wjmaclean@chromium.org
wfh@chromium.org
creis@chromium.org
mcnee@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Navigating to crashed chrome-signin page doesn't work

Project Member Reported by ekaramad@chromium.org, Oct 6 
Chrome Version: 71.0.3571.0 (Official Build) canary (64-bit)
OS: Desktop

What steps will reproduce the problem?
(1) Open a new tab and navigate to chrome://chrome-signin
(2) Crash the page (chrome://crash or task manager)
(3) Try reloading the page or loading chrome://chrome-signin in any other tab.

What is the expected result?
chrome://chrome-signin appears again.

What happens instead?
It does not.
chrome-signin.mov
6.5 MB View Download

Comment 1 by creis@chromium.org, Oct 8

Cc: rdevlin....@chromium.org msarda@chromium.org
Components: Platform>Extensions Platform>Apps>BrowserTag Services>SignIn
Labels: -Pri-3 Pri-2
Owner: lazyboy@chromium.org
Status: Assigned (was: Available)
Summary: Navigating to crashed chrome-signin page doesn't work (was: Navigating to crashed chrome-signin page)
Thanks for the report, ekaramad!  I can repro on both Mac and Windows.

This is not specific to Site Isolation, but I'll leave the component on there so that we CC interested folks.  (I can repro this even when Site Isolation is disabled.)

When reloading, there appears to be a renderer kill during extension function validation, which lazyboy@ worked on in r446865:
crash/39a79b5ac133ce41 (Mac)
crash/08cb3a0055fd6364 (Windows)

lazyboy@: Can you take a look?

Comment 2 by mcnee@chromium.org, Oct 10 

I notice that in GuestViewManager::RegisterViewDestructionCallback, the creation of an EmbedderRenderProcessHostObserver is commented out. If I uncomment it and have it use RenderProcessExited, then it appears to fix this problem.

Comment 3 by mcnee@chromium.org, Oct 11

Cc: lazyboy@chromium.org
Owner: mcnee@chromium.org
This is the source of the validation failure: https://cs.chromium.org/chromium/src/extensions/browser/api/web_request/web_request_api.cc?rcl=ef3a78ab8098151ac5b2f8e34c2f0e718f614bee&l=1509

So yeah, it seems like not performing the cleanup for guest views could explain this. I'll go ahead and take this as per c#2.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22ec3f76b3d938af34dcdc82f60055ceaa799408

commit 22ec3f76b3d938af34dcdc82f60055ceaa799408
Author: Kevin McNee <mcnee@chromium.org>
Date: Fri Oct 19 20:47:47 2018

Run guest view destruction callbacks on embedder process exit

The code for this was mostly already written, but its use was commented
out, so the callbacks weren't being run.

Also, we now use Bind{Once,Repeating} for these callbacks.

Bug:  892889 
Change-Id: I544de97a511286236cc9c4ad7a89e094aed202f5
Reviewed-on: https://chromium-review.googlesource.com/c/1283729
Reviewed-by: Paul Meyer <paulmeyer@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601289}
[modify] https://crrev.com/22ec3f76b3d938af34dcdc82f60055ceaa799408/components/guest_view/browser/guest_view_manager.cc
[modify] https://crrev.com/22ec3f76b3d938af34dcdc82f60055ceaa799408/components/guest_view/browser/guest_view_manager.h
[modify] https://crrev.com/22ec3f76b3d938af34dcdc82f60055ceaa799408/components/guest_view/browser/test_guest_view_manager.h

Comment 5 by mcnee@chromium.org, Oct 31

Status: Fixed (was: Assigned)
►

Sign in to add a comment