New issue
Advanced search Search tips

Issue 892881 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::PaintPropertyNode<blink::ClipPaintPropertyNode>::Unalias

Project Member Reported by ClusterFuzz, Oct 6

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4658583416078336

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000008
Crash State:
  blink::PaintPropertyNode<blink::ClipPaintPropertyNode>::Unalias
  blink::GeometryMapper::LocalToAncestorClipRect
  blink::ChunkToLayerMapper::SwitchToChunk
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=597364:597366

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4658583416078336

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 6

Components: Blink>Paint
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 6

Labels: Test-Predator-Auto-Owner
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/530ad69b3cfd119f40056f37be5c0b16772a4999 ([CI] Group HasLayer conditions together in NeedsEffect).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/163e1c94fb2aace377e70737382241962f215941

commit 163e1c94fb2aace377e70737382241962f215941
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sat Oct 06 20:55:35 2018

Revert "[CI] Group HasLayer conditions together in NeedsEffect"

This reverts commit 530ad69b3cfd119f40056f37be5c0b16772a4999.

Reason for revert: Caused clusterfuzz bugs

Bug:  892881 , 892882 

Original change's description:
> [CI] Group HasLayer conditions together in NeedsEffect
> 
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I10953860800adba8ee8aba894f3e2e099895589c
> Reviewed-on: https://chromium-review.googlesource.com/c/1265635
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597365}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

Change-Id: Ia5cc35d637d5d1dad8a0930c53256a4017e0a8e9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1267118
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597441}
[modify] https://crrev.com/163e1c94fb2aace377e70737382241962f215941/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc

Project Member

Comment 4 by ClusterFuzz, Oct 7

ClusterFuzz has detected this issue as fixed in range 597440:597441.

Detailed report: https://clusterfuzz.com/testcase?key=4658583416078336

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000008
Crash State:
  blink::PaintPropertyNode<blink::ClipPaintPropertyNode>::Unalias
  blink::GeometryMapper::LocalToAncestorClipRect
  blink::ChunkToLayerMapper::SwitchToChunk
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=597364:597366
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=597440:597441

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4658583416078336

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Oct 7

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4658583416078336 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment