New issue
Advanced search Search tips

Issue 892870 link

Starred by 0 users
Status: Verified
Owner:
paulmiller@chromium.org
Closed: Nov 1
Cc:
ntfschr@chromium.org
satyavat...@chromium.org
changwan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Allow WebView QA to see active variations experiments

Project Member Reported by paulmiller@chromium.org, Oct 6 
See "How can WebView QA work with Finch?" thread on the (internal) webview-finch-project mailing list for context.

QA needs to know what experiments are active on their test devices, to check whether experiments have anything to do with the bugs they find. This includes OEM devices where we can't set flags.

WebView has no UI to present this info (Chrome puts it in hashed form on chrome://version), and we also don't want to add logcat spam.

The current plan is to signal to WebView whether it should log this info by installing a dummy app. (We can't use SystemWebViewShell.apk for the dummy app because that's included on AOSP.)
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0740e23214b5ee442d3b1009bf1e084eae2281de

commit 0740e23214b5ee442d3b1009bf1e084eae2281de
Author: Paul Miller <paulmiller@google.com>
Date: Tue Oct 30 20:27:24 2018

WebView: Log field trials when a dummy app is present

Create an empty "WebView Log Verbosifier" app. When installed, WebView
will log all registered field trials and their assigned groups, for QA
purposes. Check for the dummy app asynchronously, because PackageManager
is slow.

Skipping presubmit for LOG(INFO).

BUG= 892870 
NOPRESUBMIT=true

Change-Id: Ia4fee870aec84a60e9e70642405c5ff8b07da7cf
Reviewed-on: https://chromium-review.googlesource.com/c/1266611
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603996}
[modify] https://crrev.com/0740e23214b5ee442d3b1009bf1e084eae2281de/BUILD.gn
[modify] https://crrev.com/0740e23214b5ee442d3b1009bf1e084eae2281de/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumAwInit.java
[add] https://crrev.com/0740e23214b5ee442d3b1009bf1e084eae2281de/android_webview/tools/webview_log_verbosifier/AndroidManifest.xml
[add] https://crrev.com/0740e23214b5ee442d3b1009bf1e084eae2281de/android_webview/tools/webview_log_verbosifier/BUILD.gn
[add] https://crrev.com/0740e23214b5ee442d3b1009bf1e084eae2281de/android_webview/tools/webview_log_verbosifier/README
[modify] https://crrev.com/0740e23214b5ee442d3b1009bf1e084eae2281de/base/android/field_trial_list.cc
[modify] https://crrev.com/0740e23214b5ee442d3b1009bf1e084eae2281de/base/android/java/src/org/chromium/base/FieldTrialList.java

Comment 2 by paulmiller@chromium.org, Oct 30

Cc: ntfschr@chromium.org
ntfschr@, did we ever resolve the new process for distributing APKs? This change creates a new APK for QA to use.

Comment 3 by ntfschr@chromium.org, Oct 30 

I think you're referring to http://go/webview-testapp.

The best you can do (generally speaking) would be:
 1. Setup a bot to regularly compile & archive this APK
 2. Download the archived APK manually, upload the APK to http://go/clank-webview/zzarchive/webview-manual-testing
 3. Email clank-webview-te@ after every update and ask them to download the new version manually

(1) is a general recommendation. Given this app contains no code, you could probably cheat by compiling locally. And (2) and (3) will just be one-time costs if this app never requires updates.

Comment 4 by paulmiller@chromium.org, Nov 1

Status: Fixed (was: Started)
Thanks!

Comment 5 by sbashyam@google.com, Nov 6 

Please add for manual verification steps if needed. Thanks

Comment 6 by paulmiller@chromium.org, Nov 13

Status: Verified (was: Fixed)
sbashyam@ and I saw this working in in various apps.
►

Sign in to add a comment