New issue
Advanced search Search tips

Issue 892861 link

Starred by 1 user
Status: Assigned
Owner:
schenney@chromium.org
Cc:
vmp...@chromium.org
chrishtr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Record lifecycle phases times in telemetry

Project Member Reported by vmp...@chromium.org, Oct 6 
It would be nice to expose the blink lifecycle phases to telemetry, in order to measure consistent pages and have reproducible results.

This bug tracks the implementation. 

Not sure if Blink>Paint is the correct component, so please reassign. Should we have Blink>Test or something?
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e8913f0275f2b9dcb1ac3115b3808c4485e3d27

commit 5e8913f0275f2b9dcb1ac3115b3808c4485e3d27
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Tue Oct 16 05:56:10 2018

Update LocalFrameView traces to reflect functions being called.

This patch updates the trace names to be Run*LifecyclePhase for each
lifecycle phase, making it easier to track via telemetry.

It also inlines a function called only from one spot.

R=schenney@chromium.org, chrishtr@chromium.org

Bug: 892861
Change-Id: I4224844532235d89671d79ed0408618b6203ed63
Reviewed-on: https://chromium-review.googlesource.com/c/1272258
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599875}
[modify] https://crrev.com/5e8913f0275f2b9dcb1ac3115b3808c4485e3d27/third_party/blink/perf_tests/paint/resources/paint.js
[modify] https://crrev.com/5e8913f0275f2b9dcb1ac3115b3808c4485e3d27/third_party/blink/perf_tests/test_data/color-changes-measure-frame-time.html
[modify] https://crrev.com/5e8913f0275f2b9dcb1ac3115b3808c4485e3d27/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/5e8913f0275f2b9dcb1ac3115b3808c4485e3d27/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/5e8913f0275f2b9dcb1ac3115b3808c4485e3d27/tools/perf/benchmarks/blink_perf_unittest.py
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8a077f10a84eb683272f77e6f801129a39bf658

commit f8a077f10a84eb683272f77e6f801129a39bf658
Author: Stephen Chenney <schenney@chromium.org>
Date: Thu Nov 08 20:18:05 2018

Improve testing and fix bugs for LocalFrameUKMAggregator

Add testing for the ratio metrics and fix bugs that were detected.

Rename the ratio metrics to be specific to MainFrame to prepare for future ratios.

R=pdr@chromium.org
BUG=892861

Change-Id: I01ad5d059d423366e118335ff9288e7eb2cdb339
Reviewed-on: https://chromium-review.googlesource.com/c/1320692
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606584}
[modify] https://crrev.com/f8a077f10a84eb683272f77e6f801129a39bf658/third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.cc
[modify] https://crrev.com/f8a077f10a84eb683272f77e6f801129a39bf658/third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.h
[modify] https://crrev.com/f8a077f10a84eb683272f77e6f801129a39bf658/third_party/blink/renderer/core/frame/local_frame_ukm_aggregator_test.cc
►

Sign in to add a comment