Open in loading view doesn't show at all |
|||
Issue descriptionSteps: Open any PDF tap to get the open in bar, tap on the open in button. Expected: Loading view should appear until the file download happens, then it will be dismissed and will show the share extension. (it also gives the user option to cancel downloading). Actual: No thing appears, and the user has to wait until the download is done. (they will probably think that the feature is just not working). I attached How it should look like when this feature is working properly
,
Oct 5
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd960d5ad293a140aeb3275f3b41606a0c7fdb4e commit cd960d5ad293a140aeb3275f3b41606a0c7fdb4e Author: mrefaat <mrefaat@chromium.org> Date: Mon Oct 08 10:14:57 2018 Fix a bug where open in doesn't show loading view It seems like with the switch to the new tab grid, this feature stopped to function properly. it used to use the rootview controller to present dialogs & views. using the base view for now to present the loading screen as a quick fix. The whole class should be refactored in the future to get a base view controller instead. Bug: 892839 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4eea25b3d3c5c329dd54865de1fbae68e05304e1 Reviewed-on: https://chromium-review.googlesource.com/c/1266205 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#597515} [modify] https://crrev.com/cd960d5ad293a140aeb3275f3b41606a0c7fdb4e/ios/chrome/browser/ui/open_in_controller.mm
,
Oct 29
,
Oct 29
pdf large enough to test the problem: http://wedocs.unep.org/bitstream/handle/20.500.11822/18357/The_Global_Forest_Resources_Assessment_2015_Ho.pdf?sequence=1&isAllowed=y |
|||
►
Sign in to add a comment |
|||
Comment 1 by mrefaat@chromium.org
, Oct 5