Missing build dependency in //chrome/services/isolated_xr_device:lib |
||
Issue descriptionThe target has code that uses "chrome/common/chrome_features.h", but doesn't depend on any target that provides it, resulting in flaky compile errors for chrome/common/buildflags.h not being generated in time.
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec6b03804ef838b5b9e85f6a1dc738cd4f5deade commit ec6b03804ef838b5b9e85f6a1dc738cd4f5deade Author: Bill Orr <billorr@chromium.org> Date: Mon Oct 08 18:43:28 2018 Fix missing build dependency in //chrome/services/isolated_xr_device:lib Chrome/services/isolated_xr_device depends on a feature flag in chrome/common. chrome/common/chrome_features.h then includes chrome/common/buildflags.h. Sometimes buildflags.h isn't available when isolated_xr_device is built. The fix is to add a dependency. BUG= 892836 Change-Id: I225dfff4158d7eca7f79ee54f5305a27eae71065 Reviewed-on: https://chromium-review.googlesource.com/c/1266596 Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597626} [modify] https://crrev.com/ec6b03804ef838b5b9e85f6a1dc738cd4f5deade/chrome/services/isolated_xr_device/BUILD.gn
,
Oct 22
|
||
►
Sign in to add a comment |
||
Comment 1 by waff...@chromium.org
, Oct 8