New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 892817 link

Starred by 3 users
Status: Available
Owner: ----
Cc:
█ krajshree@chromium.org
mstensho@chromium.org
robertma@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Compat



Sign in to add a comment

In multicol layout, the bottom margin of a spanner should not collapse with the top margin of the subsequent element

Reported by t...@mozilla.com, Oct 5 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36

Example URL:

Steps to reproduce the problem:
Open css/css-multicol/multicol-span-all-margin-bottom-001.xht
on wpt. The latest version of has been updated to match the spec in https://github.com/web-platform-tests/wpt/pull/13395/commits/f9155a299acf14df0d44d19dac6933351af6759f

What is the expected behavior?

What went wrong?
The bottom margin of a spanner is collapsed with the top margin of the subsequent element

Does it occur on multiple sites: No

Is it a problem with a plugin? No 

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 69.0.3497.100  Channel: stable
OS Version: OS X 10.13.6
Flash Version:

Comment 1 by krajshree@chromium.org, Oct 7

Labels: Needs-Triage-M69

Comment 2 by krajshree@chromium.org, Oct 8

Cc: krajshree@chromium.org
Components: Blink>Layout
Labels: Needs-Feedback Triaged-ET
tlin@ - Thanks for filing the issue...!!

Could you please provide a sample test file/url to test the issue from TE-end.
This will help us in triaging the issue further.

Thanks...!!

Comment 3 by mstensho@chromium.org, Oct 8

Components: -Blink>Layout Blink>Layout>MultiCol

Comment 4 by mstensho@chromium.org, Oct 8 

The margin doesn't really collapse, though. It's just ignored, because the element is at the start of a column. Margins collapse with column boundaries. The bug seems to be that we need to honor leading margins in the first columns in *every* row, while Blink only honors it at the first row.
tc.html
424 bytes View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c061254d3a548109f8877910ac649702783b042

commit 1c061254d3a548109f8877910ac649702783b042
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Mon Oct 08 11:58:50 2018

Dedicated bug for multicol-span-all-margin-bottom-001.xht failure.

TBR=eae@chromium.org

Bug: 892817
Change-Id: I5bf3d4caa0637863c329fffda7a8f27175256b12
Reviewed-on: https://chromium-review.googlesource.com/c/1268196
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597534}
[modify] https://crrev.com/1c061254d3a548109f8877910ac649702783b042/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by e...@chromium.org, Oct 8

Status: Available (was: Unconfirmed)

Comment 7 by mstensho@chromium.org, Nov 29

Cc: robertma@chromium.org mstensho@chromium.org
 Issue 892799  has been merged into this issue.
►

Sign in to add a comment