[Harmony Cast Dialog] Update the icons to the new MD ones |
|||||||||||
Issue descriptionThe icons should use the new MD style ones shown in the spec. The Meet icon should also use the colored one to match the spec.
,
Oct 10
Icons available here: https://drive.google.com/open?id=1-jIRH4p97aG8W6pX7LXMETLfJAgbKKL-&authuser=amyroberts@google.com
,
Oct 11
The following revision refers to this bug: https://chrome-internal.googlesource.com/cloudview-team/media-router/internal/+/5fa725b0fb3d9306aeea0a2f623ec9e515201cd8 commit 5fa725b0fb3d9306aeea0a2f623ec9e515201cd8 Author: John Williams <jrw@google.com> Date: Thu Oct 11 22:46:32 2018
,
Oct 15
We've landed the new icons, but we don't have the backend plumbing to actually render them for the right devices. That will require some additional MR feature work that won't make M71.
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ceaf65fa2f12145c42c1d3f30134844c3efef8e2 commit ceaf65fa2f12145c42c1d3f30134844c3efef8e2 Author: John Williams <jrw@google.com> Date: Wed Oct 17 21:26:07 2018 Updated Media Router icons to new Material Design versions. Bug: 892797 Change-Id: I6aee5aafb1f68f6eabc37adab8fd91b5ea11cd29 Reviewed-on: https://chromium-review.googlesource.com/c/1278139 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#600561} [modify] https://crrev.com/ceaf65fa2f12145c42c1d3f30134844c3efef8e2/chrome/app/vector_icons/input.icon [modify] https://crrev.com/ceaf65fa2f12145c42c1d3f30134844c3efef8e2/chrome/app/vector_icons/speaker.icon [modify] https://crrev.com/ceaf65fa2f12145c42c1d3f30134844c3efef8e2/chrome/app/vector_icons/speaker_group.icon [modify] https://crrev.com/ceaf65fa2f12145c42c1d3f30134844c3efef8e2/chrome/app/vector_icons/tv.icon
,
Oct 18
,
Oct 19
Pls apply applicable OSs label. Thank you.
,
Oct 19
,
Oct 19
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 21
Pls merge your change to M71 branch 3578 latest by 1:00 PM PT, Monday, 10/22 so we can pick it up for next week beta release. Thank you.
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e8dce8cbbeb64db9f506e72eb9e9072b1c826d0 commit 3e8dce8cbbeb64db9f506e72eb9e9072b1c826d0 Author: John Williams <jrw@google.com> Date: Mon Oct 22 16:49:50 2018 Updated Media Router icons to new Material Design versions. Bug: 892797 Change-Id: I6aee5aafb1f68f6eabc37adab8fd91b5ea11cd29 Reviewed-on: https://chromium-review.googlesource.com/c/1278139 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600561}(cherry picked from commit ceaf65fa2f12145c42c1d3f30134844c3efef8e2) Reviewed-on: https://chromium-review.googlesource.com/c/1294017 Cr-Commit-Position: refs/branch-heads/3578@{#219} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/3e8dce8cbbeb64db9f506e72eb9e9072b1c826d0/chrome/app/vector_icons/input.icon [modify] https://crrev.com/3e8dce8cbbeb64db9f506e72eb9e9072b1c826d0/chrome/app/vector_icons/speaker.icon [modify] https://crrev.com/3e8dce8cbbeb64db9f506e72eb9e9072b1c826d0/chrome/app/vector_icons/speaker_group.icon [modify] https://crrev.com/3e8dce8cbbeb64db9f506e72eb9e9072b1c826d0/chrome/app/vector_icons/tv.icon
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e8dce8cbbeb64db9f506e72eb9e9072b1c826d0 Commit: 3e8dce8cbbeb64db9f506e72eb9e9072b1c826d0 Author: jrw@google.com Commiter: takumif@chromium.org Date: 2018-10-22 16:49:50 +0000 UTC Updated Media Router icons to new Material Design versions. Bug: 892797 Change-Id: I6aee5aafb1f68f6eabc37adab8fd91b5ea11cd29 Reviewed-on: https://chromium-review.googlesource.com/c/1278139 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600561}(cherry picked from commit ceaf65fa2f12145c42c1d3f30134844c3efef8e2) Reviewed-on: https://chromium-review.googlesource.com/c/1294017 Cr-Commit-Position: refs/branch-heads/3578@{#219} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 29
Is updating the Meet icon the only remaining work here?
,
Nov 8
,
Nov 8
,
Dec 14
The following revision refers to this bug: https://chrome-internal.googlesource.com/cloudview-team/media-router/internal/+/ce8ac63d0d1adbad77d14ceb51741c0788a5355b commit ce8ac63d0d1adbad77d14ceb51741c0788a5355b Author: John Williams <jrw@google.com> Date: Wed Dec 12 21:08:31 2018
,
Jan 3
John, you probably need to update src-internal/DEPS to include the latest commit for it to take effect.
,
Jan 11
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by taku...@chromium.org
, Oct 8Status: Assigned (was: Available)