New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 892796 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
R70
R71


Participants' hotlists:
Cros-Hwsec-Ready


Sign in to add a comment

chapsd: "Attribute does not exist:297" log spew

Project Member Reported by djkurtz@google.com, Oct 5

Issue description

Chrome OS Version: 11097.0.0, 11125.0.0, R70-11021.13.0
Chrome OS Platform: careena & teemo

For teemo, see issue 890364 and feedback report: https://listnr.corp.google.com/product/208/report/85691036088

For careena, see:
https://listnr.corp.google.com/product/208/report/85705363576

R70-11021.13.0 Feedback report:
https://listnr.corp.google.com/product/208/report/85663631322

Steps To Reproduce:
(1) Boot
(2) Check file:///var/log/messages
(3)

Expected Result:
No "Attribute does not exist" messages from chapsd.

Actual Result:

2018-10-05T21:09:14.643180+00:00 INFO kernel: [   35.741659] arc0: renamed from slave_android
2018-10-05T21:09:14.932236+00:00 ERR chapsd[842]: Attribute does not exist: CKA_NSS_EMAIL
2018-10-05T21:09:14.941188+00:00 ERR chapsd[842]: Attribute does not exist: CKA_NSS_EMAIL
2018-10-05T21:09:14.953277+00:00 ERR chapsd[842]: Attribute does not exist: CKA_NSS_EMAIL
2018-10-05T21:09:14.956954+00:00 ERR chapsd[842]: message repeated 2 times: [ Attribute does not exist: CKA_NSS_EMAIL]
2018-10-05T21:09:14.959866+00:00 ERR chapsd[842]: Attribute does not exist: CKA_NSS_EMAIL
2018-10-05T21:09:14.974234+00:00 ERR chapsd[842]: Attribute does not exist: CKA_NSS_EMAIL
2018-10-05T21:09:14.977479+00:00 ERR chapsd[842]: Attribute does not exist: CKA_NSS_EMAIL
...
2018-10-05T21:09:15.390624+00:00 INFO mount-passthrough[2763]: libminijail[1]: mount '/run/arc/media/removable' -> '/mnt/dest' type 'none' flags 0x102e
2018-10-05T21:09:16.248932+00:00 ERR chapsd[842]: Attribute does not exist: 297
2018-10-05T21:09:16.345188+00:00 ERR chapsd[842]: Attribute does not exist: 297
2018-10-05T21:09:16.482031+00:00 INFO bluetoothd[1992]: adapter /org/bluez/hci0 set power to 1
2018-10-05T21:09:17.353132+00:00 ERR chapsd[842]: Attribute does not exist: 297
2018-10-05T21:09:17.368885+00:00 ERR chapsd[842]: Attribute does not exist: 297
2018-10-05T21:09:17.595338+00:00 ERR chapsd[842]: Attribute does not exist: 297
2018-10-05T21:09:17.091846+00:00 ERR chapsd[842]: Attribute does not exist: 297
2018-10-05T21:09:17.497568+00:00 ERR chapsd[842]: Attribute does not exist: 297
2018-10-05T21:09:17.568614+00:00 WARNING kernel: [   39.306788] [2814] netd: blocked syscall 357
2018-10-05T21:09:17.535533+00:00 ERR chapsd[842]: Attribute does not exist: 297
2018-10-05T21:09:17.852562+00:00 INFO chrome[1160]: [1160:1160:1005/150917.852367:INFO:remote_commands_service.cc(38)] Fetching remote commands.

How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?)
Unknown

What is the impact to the user, and is there a workaround? If so, what is it?
Unknown
 
Cc: derat@chromium.org ejcaruso@chromium.org apronin@chromium.org dkrahn@chromium.org
Owner: ----
I don't even really know what chapsd does, so I'm probably not the right owner for this. :-P

Adding people listed in platform2/chaps/OWNERS.
Owner: apronin@chromium.org
FWIW, I'm not opposed to pushing this log statement to a verbose log level.
Labels: -Pri-2 Pri-3
Status: Assigned (was: Unconfirmed)
1) 297 is CKA_PUBLIC_KEY_INFO.
2) Even if occasionally can be seen for a genuine error, there are many more cases when "Attribute does not exist" is not an indication of anything bad. Somebody asked an object if it has a particular attribute, and it doesn't. That's fine, especially if the caller (usually Chrome) just goes through a list of crudely filtered objects in search for the one it needs.
Indeed happens all the time with CKA_NSS_EMAIL. Not sure why we started seeing it for CKA_PUBLIC_KEY_INFO recently, something must have changed a few layers above chaps.
3) Indeed, makes sense to degrade to LOG(INFO) or better yet VLOG(1).
Components: OS>Systems>Security
Labels: Cros-Hwsec-Ready
Owner: ----
Status: Available (was: Assigned)
Removing myself from owners to mark as fully Cros-Hwsec-Ready.
Owner: menghuan@chromium.org
Status: Started (was: Available)
Just create 2 CL for this.

* Add CKA_PUBLIC_KEY_INFO to make chaps be able to display CKA_PUBLIC_KEY_INFO instead of 297.
* Change to verbose log level.

https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1412053
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1412054


Project Member

Comment 8 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1e10ab6f7be6b947f5fa54b93950b850f056c0ff

commit 1e10ab6f7be6b947f5fa54b93950b850f056c0ff
Author: Meng-Huan Yu <menghuan@chromium.org>
Date: Wed Jan 16 13:26:18 2019

chaps: Move the attribute not found error message to verbose log level

Since some object attribute is optional and we will always report
error when not found. Since it won't break the stuff, and it is normal.
It is good to put under verbose level.

BUG= chromium:892796 
TEST=passed unit test (no behavior change)

Change-Id: Ie57fe503c87517840d6bae2f54cff07337c629b3
Reviewed-on: https://chromium-review.googlesource.com/1412053
Commit-Ready: Meng-Huan Yu <menghuan@chromium.org>
Tested-by: Meng-Huan Yu <menghuan@chromium.org>
Reviewed-by: John  Chen <zuan@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/1e10ab6f7be6b947f5fa54b93950b850f056c0ff/chaps/object_impl.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/35ca5248bb51b3ac36af61c1c81fe9ff61f5c7b6

commit 35ca5248bb51b3ac36af61c1c81fe9ff61f5c7b6
Author: Meng-Huan Yu <menghuan@chromium.org>
Date: Thu Jan 17 20:18:23 2019

chaps: Manually add CKA_PUBLIC_KEY_INFO support to debug utility

Make AttributeToString supports to display CKA_PUBLIC_KEY_INFO for
debug message.

BUG= chromium:892796 
TEST=passed unit test (no behavior change)

Change-Id: I7d10c9cb4a6cc39db3b23d18e9ccb5c002e0c223
Reviewed-on: https://chromium-review.googlesource.com/1412054
Commit-Ready: Meng-Huan Yu <menghuan@chromium.org>
Tested-by: Meng-Huan Yu <menghuan@chromium.org>
Reviewed-by: Wei-Cheng Xiao <garryxiao@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/35ca5248bb51b3ac36af61c1c81fe9ff61f5c7b6/chaps/chaps_utility.cc

Comment 10 by menghuan@chromium.org, Jan 18 (5 days ago)

Status: Fixed (was: Started)

Sign in to add a comment