New issue
Advanced search Search tips

Issue 892792 link

Starred by 2 users
Status: Unconfirmed
Owner: ----
Cc:
iannu...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add a new way to express recipe failure

Project Member Reported by martiniss@chromium.org, Oct 5 
Currently, the main way that recipes express failures is by raising a step.StepFailure exception. This is somewhat overloaded, as seen by looking at the constructor of that exception.

Ideally, there would be two exception classes:
StepFailure, which is used when an actual step fails
RecipeFailure (name TBD), which will be used when something else fails, and the build needs to stop.

These would each have very simple constructors, and would also be able to be surfaced in the result proto very clearly.

The rollout of this change might be complicated, as there are many places that use StepFailure which probably should use RecipeFailure. https://cs.chromium.org/chromium/infra/recipes-py/recipe_modules/cipd/api.py?l=238 is an example of this.

Comment 1 by iannu...@google.com, Oct 5 

I think we actually want to go the other direction; It should just be Failure. The intent of both of your proposed exceptions is the same; something in the function you just called failed, so it didn't do what you asked it to do, sorry.

The fact that the StepFailure has a step attached to it is the bug (imo), and since most recipes already use the active_result thing, we should just remove that.

Comment 2 by iannu...@google.com, Oct 18

Cc: iannu...@google.com
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/ee0e2c37c03936c3683be03d215f58d47d04ee08

commit ee0e2c37c03936c3683be03d215f58d47d04ee08
Author: Stephen Martinis <martiniss@google.com>
Date: Tue Oct 30 21:56:42 2018

Always use new run logic

This will retrain every expectation which includes the '$result' entry,
which is almost all of them.

Some of the StepFailure test expectations don't give any useful information.
This is due to how step failures are used now; as a general way to fail
a build, even when an actual step didn't fail. crbug.com/892792 tracks an
attempt to fix this.

Bug: 646142, 892792
Recipe-Manual-Change: build
Recipe-Manual-Change: infra
Recipe-Manual-Change: skiabuildbot
Recipe-Manual-Change: skia
Recipe-Manual-Change: build_limited_scripts_slave
Recipe-Manual-Change: release_scripts
Recipe-Manual-Change: depot_tools
Change-Id: I2778cdc12118d295c6b569f9abf3b70cd398cf95
Reviewed-on: https://chromium-review.googlesource.com/c/1239574
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_engine/post_process.py
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/serialized buildbucket property.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/properties/examples/full.expected/lists.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/generator_script/examples/full.expected/bad_key.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, invalid revision.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/platform/examples/full.expected/win32.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/whitelist_steps.expected/all_steps.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/properties/examples/full.expected/buildbot_generic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/file/examples/symlink.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, patch_gerrit_url with unexpected scheme.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/depend_on/top.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/properties/examples/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/time/examples/full.expected/seed_and_step.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/path/examples/full.expected/linux_kitchen.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/service_account/examples/full.expected/json_key.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/README.recipes.md
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/generator_script/examples/full.expected/malformed_command.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/put.expected/gitiles commit.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/service_account/examples/full.expected/custom_scopes.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/undeclared_method.expected/attribute.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/examples/full.expected/infra_failure.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/cipd/examples/full.expected/win64.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/url/examples/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/examples/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/depend_on/bottom.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/generator_script/api.py
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/v1 build with id.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/cipd/examples/full.expected/describe-many-instances.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, HEAD revision.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/tests/defer.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, string issue.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/properties/examples/full.expected/buildbot_tryserver.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/tests/active_result.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/undeclared_method.expected/from_recipe.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/cipd/examples/full.expected/search-empty-result.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/functools_partial.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/v1 tags.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/depend_on/dont_need_properties_helper.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/step_stack_exhaustion.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/cipd/examples/full.expected/describe-failed.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/tests/stdio.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/put.expected/basic_experimental.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/file/examples/listdir.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, patch_gerrit_url without scheme.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/service_account/examples/full.expected/windows.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/scheduler/examples/emit_triggers.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, issue and patchset properties.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/platform/examples/full.expected/mac64.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/tests/inject_paths.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/module_injection_site.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/unicode.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, no project.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/depend_on/need_return_schema_helper.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/recipe_paths.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/generator_script/examples/full.expected/malformed_list.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/examples/full.expected/timeout.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/python/examples/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/path/examples/full.expected/mac_luci.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/context/tests/infra_step.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/file/examples/error.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/context/tests/increment_nest_level.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/v1 hidden tags.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/tests/nested.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/examples/full.expected/invalid_access.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change, string issue, not a number.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/file/examples/raw_copy.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/sort_properties.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/v1 created_by.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/path/examples/full.expected/linux_swarming.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/led/tests/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/path/examples/full.expected/mac_swarming.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_engine/test.py
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/examples/full.expected/warning.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/path/examples/full.expected/linux.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/examples/full.expected/exceptional.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/depend_on/bad_properties.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/examples/full.expected/bad_return.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/multi_test_data.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/cipd/examples/full.expected/pkg_bad_mode.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/tests/subannotations.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, parent_got_revision.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/url/tests/validate_url.expected/no_host.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/get.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/properties/examples/full.expected/buildbot_tryserver_gerrit.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/put.expected/custom buildset.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/v1 luci builder id.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/generator_script/examples/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/file/examples/copytree.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/depend_on/dont_need_properties.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/url/tests/join.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/missing_start_dir.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/tricium/examples/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/expect_exception.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/service_account/examples/full.expected/default.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/examples/full.expected/no_properties.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/time/examples/full.expected/defaults.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/platform/examples/full.expected/linux64.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/unittests/test_test.py
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/generator_script/examples/full.expected/presentation.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/generator_script/examples/full.expected/basic_python.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/uuid/examples/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change with revision.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/generator_script/examples/full.expected/always_run.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/v1 gitiles commit, invalid.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/json/examples/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/url/tests/validate_url.expected/no_scheme.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/buildbot gerrit change.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/depend_on/no_return.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/tests/inject_paths.expected/with_value.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_engine/unittests/run_test.py
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/url/tests/validate_url.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/put.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/path/examples/full.expected/mac_kitchen.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/properties/examples/full.expected/buildbot_tryserver_gerrit_override_both.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/cipd/examples/full.expected/basic_pkg.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/cipd/examples/full.expected/pkg_bad_verfile.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/cipd/examples/full.expected/basic_with_pkg_vars.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/nonexistent_command.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/path/examples/full.expected/mac.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/empty.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/properties/examples/full.expected/buildbot_git_scheduled.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/runtime/tests/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/platform/examples/full.expected/four_cores.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/cipd/examples/full.expected/mac64.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/cipd/examples/full.expected/pkg_bad_file.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/path/examples/full.expected/win.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/properties/examples/full.expected/buildbot_tryserver_gerrit_override_gerrit.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/examples/full.expected/catch_timeout.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/service_account/examples/full.expected/no_authutil.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/path/examples/full.expected/linux_luci.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/file/examples/copy.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_engine/common_args.py
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/unittests/errors_test.py
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/tests/defer.expected/one_fail.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/examples/full.expected/basic-try.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/v1 empty buildset.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/context/examples/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/file/examples/flatten_single_directories.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/path/examples/full.expected/win_kitchen.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/file/examples/glob.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/examples/full.expected/defer_results.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/properties/examples/full.expected/buildbot_scheduled.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/tests/step_call_args.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/tempfile/examples/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/v1 unknown buildset format.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/source_manifest/examples/simple.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/cipd/examples/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/cipd/examples/full.expected/basic_with_no_refs_or_tags.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/context/tests/env.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/bad_subprocess.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/url/tests/validate_url.expected/invalid_scheme.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/tests/trigger.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/v1 gerrit change.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/whitelist_steps.expected/result.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/context/tests/cwd.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/file/examples/truncate.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/path/examples/full.expected/win_luci.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/examples/full.expected/basic-ci-win.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/path/examples/full.expected/win_swarming.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/step/tests/timeout.expected/timeout.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/properties/examples/full.expected/buildbot_tryserver_gerrit_override_git.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/json/tests/add_json_log.expected/add_json_log.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/properties/examples/full.expected/exception.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/raw_io/examples/full.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/undeclared_method.expected/module.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/buildbot gitiles commit, both revision and parent_got_revision.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/v1 gitiles commit.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_engine/run.py
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipes/engine_tests/depend_on/need_return_schema.expected/basic.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/properties/examples/full.expected/dicts.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_modules/buildbucket/tests/build.expected/v1 buildbot builder id.json
[modify] https://crrev.com/ee0e2c37c03936c3683be03d215f58d47d04ee08/recipe_engine/recipe_api.py
►

Sign in to add a comment