New issue
Advanced search Search tips

Issue 892790 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Oct 11
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 754101


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

[Harmony Cast Dialog] Make tests pass with the field trial config enabled

Project Member Reported by taku...@chromium.org, Oct 5 
There are many tests failing when the ViewsCastDialog is enabled. We must make these tests pass -- if a test requires the WebUI dialog, it shouldn't be run or if possible, force the WebUI to be enabled.

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/202358
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/082734219e597835985741fb6a920a050c177e71

commit 082734219e597835985741fb6a920a050c177e71
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Wed Oct 10 21:12:41 2018

[Media Router] Force-enable WebUI for some browser tests

All of Media Router integration and e2e tests, and some of UI browser
tests depend on the WebUI Cast dialog. This CL force-enables the WebUI
dialog for those tests by disabling the ViewsCastDialog feature.

Bug:  892790 
Change-Id: I6217f14ecc2e014ad2d80f619542bafd0292dfe2
Reviewed-on: https://chromium-review.googlesource.com/c/1269109
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598508}
[modify] https://crrev.com/082734219e597835985741fb6a920a050c177e71/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[modify] https://crrev.com/082734219e597835985741fb6a920a050c177e71/chrome/test/media_router/media_router_base_browsertest.cc
[modify] https://crrev.com/082734219e597835985741fb6a920a050c177e71/chrome/test/media_router/media_router_base_browsertest.h

Comment 2 by taku...@chromium.org, Oct 11

Status: Fixed (was: Assigned)
►

Sign in to add a comment