New issue
Advanced search Search tips

Issue 892757 link

Starred by 1 user
Status: Fixed
Owner:
wzang@chromium.org
Closed: Oct 16
Cc:
cbiesin...@chromium.org
alemate@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 596743



Sign in to add a comment

Add min-height: 0 to all nested flexboxes in OOBE

Project Member Reported by wzang@chromium.org, Oct 5 
In short, because of CL https://chromium-review.googlesource.com/c/chromium/src/+/1252682 (currently reverted but needs to reland in M72), all nested flexboxes will have min-height: auto. Therefore OOBE code (and all other web-ui code using nested flexboxes) needs to explicitly add min-height: 0 to mitigate the effect.

alemate@: please suggest on where to look at.

See  issue 596743  and  issue 891988  for details.

Comment 1 by wzang@chromium.org, Oct 9

Cc: jdufault@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef298ae538d3b965b036fe68ace5592841cf15ae

commit ef298ae538d3b965b036fe68ace5592841cf15ae
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Tue Oct 16 03:20:01 2018

Add min-height: 0 to ChromeOS UI flexboxes

This is required before (re)landing a Flexbox change ( bug 596743  /
https://chromium-review.googlesource.com/c/chromium/src/+/1269235)

This fixes the previously found issues in the wallpaper manager and
the OOBE UI. This changes more than necessary, but this is easier
and should not be harmful.

Bug:  890100 ,  891988 ,  892757 
Change-Id: I745a22fadabd182d06d6b4c67b428d495c48bae4
Reviewed-on: https://chromium-review.googlesource.com/c/1281726
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599830}
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/api_keys_notice.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/discover/discover_app.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/discover/discover_card.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/enterprise_card_footer.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/gaia_card.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/gaia_header.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/md_top_header_bar.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/multidevice_setup_first_run.html
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/network_select_login.html
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/offline_gaia.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/oobe_a11y_option.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/oobe_change_picture.html
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/oobe_dialog_host.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/oobe_flex_layout.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/oobe_popup_overlay.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/oobe_screen.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/oobe_screen_auto_enrollment_check.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/oobe_screen_enable_debugging.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/oobe_screen_reset.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/oobe_screen_voice_interaction_value_prop.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/oobe_screen_wait_for_container_ready.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/screen_arc_kiosk_splash.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/screen_device_disabled.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/screen_gaia_signin.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/login/throbber_notice.css
[modify] https://crrev.com/ef298ae538d3b965b036fe68ace5592841cf15ae/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9758e26b1635411c98b27aba8589a8e98bc2457

commit c9758e26b1635411c98b27aba8589a8e98bc2457
Author: Alexander Alekseev <alemate@chromium.org>
Date: Tue Oct 16 22:10:53 2018

Chrome OS OOBE: Fix Polymer layout classes for OOBE.

This Cl prepares for  bug 596743  and has fixes to clear for
https://chromium-review.googlesource.com/c/chromium/src/+/1269235 landing.

Bug:  892757 
Change-Id: I9858ec633158310c805430f1f070b5cff730f94f
Reviewed-on: https://chromium-review.googlesource.com/c/1282462
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600149}
[modify] https://crrev.com/c9758e26b1635411c98b27aba8589a8e98bc2457/chrome/browser/resources/chromeos/login/discover/discover_card.html
[modify] https://crrev.com/c9758e26b1635411c98b27aba8589a8e98bc2457/chrome/browser/resources/chromeos/login/discover/discover_ui.html
[modify] https://crrev.com/c9758e26b1635411c98b27aba8589a8e98bc2457/chrome/browser/resources/chromeos/login/discover/discover_welcome.html
[modify] https://crrev.com/c9758e26b1635411c98b27aba8589a8e98bc2457/chrome/browser/resources/chromeos/login/discover/modules/discover_module_launch_help_app.html
[modify] https://crrev.com/c9758e26b1635411c98b27aba8589a8e98bc2457/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.html
[modify] https://crrev.com/c9758e26b1635411c98b27aba8589a8e98bc2457/chrome/browser/resources/chromeos/login/discover/modules/discover_module_redeem_offers.html
[modify] https://crrev.com/c9758e26b1635411c98b27aba8589a8e98bc2457/chrome/browser/resources/chromeos/login/discover/modules/discover_module_sync_files.html
[modify] https://crrev.com/c9758e26b1635411c98b27aba8589a8e98bc2457/chrome/browser/resources/chromeos/login/enrollment_license_card.html
[modify] https://crrev.com/c9758e26b1635411c98b27aba8589a8e98bc2457/chrome/browser/resources/chromeos/login/hd-iron-icon.html
[modify] https://crrev.com/c9758e26b1635411c98b27aba8589a8e98bc2457/chrome/browser/resources/chromeos/login/offline_ad_login.html
[modify] https://crrev.com/c9758e26b1635411c98b27aba8589a8e98bc2457/chrome/browser/resources/chromeos/login/oobe_a11y_option.html
[modify] https://crrev.com/c9758e26b1635411c98b27aba8589a8e98bc2457/chrome/browser/resources/chromeos/login/oobe_buttons.html
[add] https://crrev.com/c9758e26b1635411c98b27aba8589a8e98bc2457/chrome/browser/resources/chromeos/login/oobe_iron_flex_layout_fix.css

Comment 4 by alemate@chromium.org, Oct 16

Status: Fixed (was: Assigned)
►

Sign in to add a comment