New issue
Advanced search Search tips

Issue 892751 link

Starred by 1 user
Status: Fixed
Owner:
npm@chromium.org
Closed: Oct 9
Cc:
malaykeshav@chromium.org
panicker@chromium.org
yoavweiss@chromium.org
npm@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Consistent DCHECK failure

Project Member Reported by malaykeshav@chromium.org, Oct 5 
The following DCHECK keeps failing on Chrome OS 71.0.3571.0.
Not sure when this regressed.

static unsigned long long ToIntegerMilliseconds(TimeDelta duration) {
  DCHECK_GE(duration, TimeDelta());
  double clamped_seconds =
      Performance::ClampTimeResolution(duration.InSecondsF());
  return static_cast<unsigned long long>(clamped_seconds * 1000.0);
}


[https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/timing/performance_timing.cc?l=51]

Comment 1 by npm@chromium.org, Oct 5 

That version is higher than current Dev, so are you running a local build? Do you have a stacktrace? That DCHECK has been around for a while, so it's unclear what changed. We could remove the DCHECK but I'd like to understand why it's failing all of a sudden. I'll await for the bisect...

Comment 2 by malaykeshav@chromium.org, Oct 5 

I think its been failing for a while. I only reported it now since the webcontent is unusable and my current work needed webcontent for testing.

Comment 3 by npm@chromium.org, Oct 5 

If this is OS-specific problem then it sounds to me like ChromeOS is somehow providing broken timestamps in some cases, which causes the DCHECK to be hit. I can remove it but might need to investigate more on why it's getting hit.

Comment 4 by rtoy@chromium.org, Oct 6

Components: -Blink Blink>PerformanceAPIs
Setting component based on OWNERS for performance_timing.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01e413f07ef7d5ba3d66b2dd85c31ebffc038ea8

commit 01e413f07ef7d5ba3d66b2dd85c31ebffc038ea8
Author: Nicolas Pena <npm@chromium.org>
Date: Tue Oct 09 19:21:40 2018

Remove DCHECK from ToIntegerMilliseconds()

The DCHECK was reported to be hit in Chrome OS. This may be related to new use
cases of the method or broken timestamps.

Bug:  892751 
Change-Id: I4b9ace1aeeefa8467f42e78539b0fa286ee7c4e5
Reviewed-on: https://chromium-review.googlesource.com/c/1265905
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598033}
[modify] https://crrev.com/01e413f07ef7d5ba3d66b2dd85c31ebffc038ea8/third_party/blink/renderer/core/timing/performance_timing.cc

Comment 6 by npm@chromium.org, Oct 9

Status: Fixed (was: Assigned)
Work is left to dig into why some of these timestamps are negative, but I'll consider that out of the scope of this bug.
►

Sign in to add a comment