New issue
Advanced search Search tips

Issue 892749 link

Starred by 1 user
Status: Started
Owner:
cassew@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-VR
Proj-XR



Sign in to add a comment

Rename instances of "AR" and "VR" to "Ar" and "Vr" for consistency

Project Member Reported by lincolnfrog@chromium.org, Oct 5 
According to style guides, acronyms should be treated like words with respect to naming conventions:

https://google.github.io/styleguide/cppguide.html#General_Naming_Rules

We also have an inconsistency problem currently in the codebase with these namings of classes and APIs.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78c478cee8049a6915c1a5d8604e7125f0cf779e

commit 78c478cee8049a6915c1a5d8604e7125f0cf779e
Author: Max Rebuschatis <lincolnfrog@chromium.org>
Date: Mon Oct 08 18:36:18 2018

Rename "ARCore" to "ArCore" for consistency

Bug: 892749

Change-Id: If8c31124c68d3a247a0cb7eb96813ffff269bfde
Reviewed-on: https://chromium-review.googlesource.com/c/1259620
Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597624}
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/arcore.h
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/arcore_device.cc
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/arcore_device.h
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/arcore_device_provider.cc
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/arcore_device_provider.h
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/arcore_gl.cc
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/arcore_gl.h
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/arcore_gl_thread.cc
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/arcore_gl_thread.h
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/arcore_impl.cc
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/arcore_impl.h
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/arcore_java_utils.cc
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/arcore_java_utils.h
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/fake_arcore.cc
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/arcore_device/fake_arcore.h
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/android/vr/vr_shell_delegate.cc
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/chrome/browser/vr/service/xr_runtime_manager.cc
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/device/vr/android/arcore/arcore_device_provider_factory.cc
[modify] https://crrev.com/78c478cee8049a6915c1a5d8604e7125f0cf779e/device/vr/android/arcore/arcore_device_provider_factory.h

Comment 2 by ericde@google.com, Oct 30

Labels: -Proj-XR-AR Proj-XR-VR
Status: Available (was: Untriaged)
Ar part has been done, need to do Vr part.

Comment 3 by dtapu...@chromium.org, Nov 26

Components: Internals>XR

Comment 4 by cassew@google.com, Dec 18

Owner: cassew@google.com
Status: Started (was: Available)
►

Sign in to add a comment