Corp Profile is signed out without being deleted. |
|||||||||||||||||||||
Issue descriptionChrome Version: 69+ OS: Windows, but it should apply to Mac and Linux. What steps will reproduce the problem? (1) Open Chrome and sign in a corp account, enable sync. (2) Add RestrictSigninToPattern policy for a different domain and relaunch Chrome. What is the expected result? Profile is either not signed out or signed out and deleted. What happens instead? Chrome is signed out but the Profile is still there. User could sign in to this profile with the new domain Please note that: 1) When Chrome is running and RestrictSigninToPattern is updated (You could force that by goes to chrome://policy and click "Reload Policies"). Normal account is signed out right a way while corp account remains signed in because signed out is prohibited. 2) I only tested RestrictSigninToPattern policy with GOOGLE_SERVICE_NAME_PATTERN_CHANGED. But I'm afraid that this issue applies to other sign out reasons.
,
Oct 5
Chrome is completed signed out (You could sign in with a different account). I could create a video for this)
,
Oct 5
OK, got it. So the expected behavior should be that the account remains signed-in and syncing, since it was already signed in when the policy was applied? I'd like the Enterprise folks to chime in on preferred/expected behavior, since I don't have a good sense for what admins want here (either keeping the account signed-in or signing the account out and deleting the profile).
,
Oct 5
I found this issue when looking at the CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1175797. I have asked chcunninghamto to email his proposal to the enterprise team and sign in team. Hopefully we could come up with a plan of how to handle sign out that is triggered by internal reason.
,
Oct 5
And here is the screen captor of the issue.
,
Oct 8
Owen/Georges: Would you expect us to remove the profile is signin is not allowed? If so, is this a blocker for M70? And should we give any warning to the user that flipping that toggle in settings will remove their profile from disk?
,
Oct 8
I don't think this should block M70. But we need guidance from the Enterprise folks on what desired behavior here is.
,
Oct 9
I see the following possibilities: 1. Disable the "Allow browser sign-in" toggle for users that have enabled sync (at least for an enterprise users). And have a footer informing the user they first need to "Turn off sync" before being able to interact with the "Allow browser sign-in" toggle. 2. Wipe the profile on start-up without any user warning if signinAllowed pref is set to false.
,
Oct 9
I've taken a look to wipe the profile and the code is complex and risky (not yet ready either). I would prefer to avoid merging the fix to M70 if possible.
,
Oct 9
Mihai, the original bug report talks about RestrictSigninToPattern, not the "Allow Chrome sign in" toggle. I guess you're point is that they both have the same issue, where if sign in becomes disallowed for the current account during the middle of a session, then the user just gets signed out of their profile without the profile being deleted? I would argue that this is not blocking for M70, but would like to hear from the Enterprise folks on what desired behavior is. Note that this isn't a new regression with the new "Allow Chrome sign in" setting, since this bug existed before with the RestrictSigninToPattern policy (see original bug description).
,
Oct 10
Issue 893479 has been merged into this issue.
,
Oct 10
Note that Issue 893479 also tracks another way that Dasher users might get signed out of their profile without deleting local data. This is now being tracked in a doc by Owen here: https://docs.google.com/document/d/1QqWoV1I7WgrzeHJwm9agG56ZqXD_Q2L3LB3K7Ck89GI/edit?disco=AAAACJwNvDI&ts=5bbe33a0
,
Oct 11
Our understanding as of today is that we need a solution for M70 for enterprise users that can interact with the new preference in settings. Thomas has a potential UI fix that we belive can be merged to M70, but it is still discussed with UX and PM. I am marking this bug as RBS for M70 to make sure it has the proper visibility. Assigning it to Thomas as he is actively working on it now.
,
Oct 11
,
Oct 11
Updated the email thread with the desired spec per offline conversation with Alex. Copying here for reference: - The setting should always be configurable (even when the user is syncing) - If a syncing user tries to turn the setting off, the following should happen: -- When the user clicks the setting to turn it off, we should present the "Turn off sync?" modal confirmation dialogue. This has both a "consumer" and an "Enterprise" version, and we should show the right one depending on what type of account the user is syncing to. -- If the user clicks "Cancel" in that confirmation dialogue, it should be dismissed, the setting should remain turned on, and no "relaunch" toast should be shown -- If the user confirms the "turn off sync" and elects to clear their local data (or is forced to clear their local data because they're an Enterprise user), the profile will be deleted -- If the user confirms the "turn off sync" and doesn't elect to clear their local data (consumer only), then sync should be turned off, the setting should be turned off, and we should show the toast after the modal dialogue disappears informing the user that they need to relaunch Chrome to have the new setting take effect.
,
Oct 11
Just FYI, calling the "Turn off sync" dialog happens asynchronous and right now idk how to handle a response from this dialog (or idk whether it's possible at all). So at this point, I don't think I can make this change for M70. But I'll try to give it a shot tmr.
,
Oct 11
OK, thanks for the info Thomas. I discussed with Alex, and if this isn't doable for M70, then we can fall back on your other proposed solution (just forcing the toggle ON while the user is syncing, without providing any explanatory text underneath it). That should be sufficient for M70, if the above is too difficult.
,
Oct 11
Also, don't get me wrong. I actually like your behavior(c#16) from a user experience perspective! :) I'd say we try to implement this for M71. I'll go ahead and land the change to disable the toggle for syncing users then. And hopefully will merge back tomorrow.
,
Oct 11
Cool, sounds good. Yeah, maybe take a quick look to see whether it's not too hard to do the proposed behavior above for M70. But fully agreed that if it looks tricky, we should just land the CL to disable the toggle and merge that back to M70.
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f696e77df78a51eff611f3b8983fbe361a54f85 commit 2f696e77df78a51eff611f3b8983fbe361a54f85 Author: Thomas Tangl <tangltom@chromium.org> Date: Thu Oct 11 19:58:34 2018 [signin] Disable signin-allowed toggle for sync users When the user is signed in and syncing, the signin-allowed toggle is now disabled. Note: This CL is adapted from crrev.com/c/1273517 and removes the hint, i.e. there are no string changes here. Bug: 892745 Change-Id: I1778115390518860fca4b4f11588d5ca7c7b9210 Reviewed-on: https://chromium-review.googlesource.com/c/1275849 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#598901} [modify] https://crrev.com/2f696e77df78a51eff611f3b8983fbe361a54f85/chrome/browser/resources/settings/privacy_page/BUILD.gn [modify] https://crrev.com/2f696e77df78a51eff611f3b8983fbe361a54f85/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/2f696e77df78a51eff611f3b8983fbe361a54f85/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/2f696e77df78a51eff611f3b8983fbe361a54f85/chrome/test/data/webui/settings/privacy_page_test.js
,
Oct 11
I landed it for now and will look into the behavior for c#16 tomorrow!
,
Oct 12
Verified the change from c#21. Requesting merge.
,
Oct 12
This bug requires manual review: We are only 3 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 12
Approving merge in #21.
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8e57473c61d919743920f086344cec94c856f1c commit b8e57473c61d919743920f086344cec94c856f1c Author: Thomas Tangl <tangltom@chromium.org> Date: Fri Oct 12 12:43:24 2018 [signin] Disable signin-allowed toggle for sync users When the user is signed in and syncing, the signin-allowed toggle is now disabled. Note: This CL is adapted from crrev.com/c/1273517 and removes the hint, i.e. there are no string changes here. Bug: 892745 Change-Id: I1778115390518860fca4b4f11588d5ca7c7b9210 Reviewed-on: https://chromium-review.googlesource.com/c/1275849 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#598901}(cherry picked from commit 2f696e77df78a51eff611f3b8983fbe361a54f85) Reviewed-on: https://chromium-review.googlesource.com/c/1278169 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#981} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/b8e57473c61d919743920f086344cec94c856f1c/chrome/browser/resources/settings/privacy_page/BUILD.gn [modify] https://crrev.com/b8e57473c61d919743920f086344cec94c856f1c/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/b8e57473c61d919743920f086344cec94c856f1c/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/b8e57473c61d919743920f086344cec94c856f1c/chrome/test/data/webui/settings/privacy_page_test.js
,
Oct 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8e57473c61d919743920f086344cec94c856f1c Commit: b8e57473c61d919743920f086344cec94c856f1c Author: tangltom@chromium.org Commiter: tangltom@chromium.org Date: 2018-10-12 12:43:24 +0000 UTC [signin] Disable signin-allowed toggle for sync users When the user is signed in and syncing, the signin-allowed toggle is now disabled. Note: This CL is adapted from crrev.com/c/1273517 and removes the hint, i.e. there are no string changes here. Bug: 892745 Change-Id: I1778115390518860fca4b4f11588d5ca7c7b9210 Reviewed-on: https://chromium-review.googlesource.com/c/1275849 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#598901}(cherry picked from commit 2f696e77df78a51eff611f3b8983fbe361a54f85) Reviewed-on: https://chromium-review.googlesource.com/c/1278169 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#981} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a75477ad4731366a27e14849c7d64af556b028ec commit a75477ad4731366a27e14849c7d64af556b028ec Author: Thomas Tangl <tangltom@chromium.org> Date: Sun Oct 14 15:01:04 2018 Show sign-out dialog when signin-allowed is toggled off This CL changes the behavior of the signin-allowed toggle on the privacy page: - When the user is syncing and tries to turn the toggle off, the toggle remains on and the sign-out dialog is opened. - When the user turns off sync, they can normally use the toggle. TBR= scottchen@chromium.org, jochen@chromium.org Bug: 892745 Change-Id: If606532345645ae91a93212abc8ba7e521db56ed Reviewed-on: https://chromium-review.googlesource.com/c/1278637 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#599538} [modify] https://crrev.com/a75477ad4731366a27e14849c7d64af556b028ec/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/a75477ad4731366a27e14849c7d64af556b028ec/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/a75477ad4731366a27e14849c7d64af556b028ec/chrome/test/data/webui/settings/privacy_page_test.js
,
Oct 14
As already mentioned offline, implementing all specs from c#16 turns out to be quite tricky (or at least quite a big change to make so late in). Alternatively, I landed a change (c#28) to implement the specs with a small twist: - When the user is syncing, clicks the toggle, the sign-out dialog opens and the user confirms to sign out without deleting the profile, the signin-allowed toggle *won't* be turned off automatically. I.e. the user has to click the toggle again after going through the sign-out dialog. Apart from that all the other specs are in. So generally, I think this implementation is not a much worse experience than c#16. Eli, please let me know if I should go ahead and merge this change to Stable once I have the LGTM from Scott.
,
Oct 14
Thanks Thomas! I am a little worried about the UX pattern of leaving the setting turned ON after the user clicks it (and also clicks through the modal confirmation dialogue we present). Requiring a second click sounds a little wonky from a UX perspective. I understand it makes it much more technically complex, but I think I would prefer the existing behavior we have merged to 70 (just keeping the toggle forced on while you're syncing). However, let me run this past Alex and see what he says. I'll update this bug after speaking with him.
,
Oct 15
As discussed in the email thread, we'll keep the change from #c21 and I'll work on the spec from #c16 in a follow-up, targeting M71.
,
Oct 18
Issue 896473 has been merged into this issue.
,
Oct 18
Thomas is working on a CL for this. The CL is in progress https://chromium-review.googlesource.com/c/chromium/src/+/1280542 and is quite complex. The code reviewers are in LA and we hope to have it reviewed and submitted by tomorrow evening. I will start an internal email thread to double check whether we want this for M70 or not.
,
Oct 18
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bca45527fcd1ef23db1a8e399faeddb62be6b1a3 commit bca45527fcd1ef23db1a8e399faeddb62be6b1a3 Author: Thomas Tangl <tangltom@chromium.org> Date: Fri Oct 19 00:35:35 2018 Turn off signin-allowed toggle after sign-out from dialog When a sync user confirms to sign out after trying to turn off the signin-allowed toggle, the toggle is now turned off. Additional change: - The code related to the sign-out dialog in settings is extracted into its own element and refactored. Bug: 892745 Change-Id: I9d638d8c77b1f4318fc592cc88f4be95e5eab7c8 Reviewed-on: https://chromium-review.googlesource.com/c/1280542 Reviewed-by: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#600997} [modify] https://crrev.com/bca45527fcd1ef23db1a8e399faeddb62be6b1a3/chrome/browser/resources/settings/people_page/BUILD.gn [modify] https://crrev.com/bca45527fcd1ef23db1a8e399faeddb62be6b1a3/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/bca45527fcd1ef23db1a8e399faeddb62be6b1a3/chrome/browser/resources/settings/people_page/people_page.js [add] https://crrev.com/bca45527fcd1ef23db1a8e399faeddb62be6b1a3/chrome/browser/resources/settings/people_page/signout_dialog.html [add] https://crrev.com/bca45527fcd1ef23db1a8e399faeddb62be6b1a3/chrome/browser/resources/settings/people_page/signout_dialog.js [modify] https://crrev.com/bca45527fcd1ef23db1a8e399faeddb62be6b1a3/chrome/browser/resources/settings/privacy_page/BUILD.gn [modify] https://crrev.com/bca45527fcd1ef23db1a8e399faeddb62be6b1a3/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/bca45527fcd1ef23db1a8e399faeddb62be6b1a3/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/bca45527fcd1ef23db1a8e399faeddb62be6b1a3/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/bca45527fcd1ef23db1a8e399faeddb62be6b1a3/chrome/test/data/webui/settings/people_page_test.js [modify] https://crrev.com/bca45527fcd1ef23db1a8e399faeddb62be6b1a3/chrome/test/data/webui/settings/privacy_page_test.js
,
Oct 19
,
Oct 19
I just merged the CLs from #c28 and #c35 back locally: - The CLs apply cleanly, i.e. there are no merge conflicts. - I built it and tested the changes -> WAI. - All settings tests pass. Conclusion: It looks good if we want to merge the changes back to M70. If there is an okay from product, we could potentially merge this back without much trouble.
,
Oct 19
Adding merge request labels for M71 and M72 (per comment above). Eli/Abdul: Please let us know if we should proceed with the merge or not. Thank you.
,
Oct 22
Hey Krishna, could you please address the previous comment(s)? I think Abdul is OOO today.
,
Oct 22
Approving for both M70 and M71. Confirmed with tangltom@, this is a fairly safe change, there is no string translation required, and has no chances of introing new regressions. This has been validated locally.
,
Oct 22
Pls merge to M71 branch 3578 ASAP so we can pick it up for tomorrow's dev release.
,
Oct 22
To be clear, we're also merging to M70 right? What's the right branch number for that? Or is it the same as the M71 branch number?
,
Oct 22
M71 branch is 3578. M70 branch is 3538.
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e43f2a113b1a5eb5d378372cd8cf18e6cc9c219d commit e43f2a113b1a5eb5d378372cd8cf18e6cc9c219d Author: Thomas Tangl <tangltom@chromium.org> Date: Mon Oct 22 18:57:40 2018 Show sign-out dialog when signin-allowed is toggled off This CL changes the behavior of the signin-allowed toggle on the privacy page: - When the user is syncing and tries to turn the toggle off, the toggle remains on and the sign-out dialog is opened. - When the user turns off sync, they can normally use the toggle. TBR= scottchen@chromium.org, jochen@chromium.org Bug: 892745 Change-Id: If606532345645ae91a93212abc8ba7e521db56ed Reviewed-on: https://chromium-review.googlesource.com/c/1278637 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599538}(cherry picked from commit a75477ad4731366a27e14849c7d64af556b028ec) Reviewed-on: https://chromium-review.googlesource.com/c/1294509 Cr-Commit-Position: refs/branch-heads/3578@{#235} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/e43f2a113b1a5eb5d378372cd8cf18e6cc9c219d/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/e43f2a113b1a5eb5d378372cd8cf18e6cc9c219d/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/e43f2a113b1a5eb5d378372cd8cf18e6cc9c219d/chrome/test/data/webui/settings/privacy_page_test.js
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2efb8455d78b4069b8b9ee4a5e29dfed6f1eca44 commit 2efb8455d78b4069b8b9ee4a5e29dfed6f1eca44 Author: Thomas Tangl <tangltom@chromium.org> Date: Mon Oct 22 19:01:07 2018 Show sign-out dialog when signin-allowed is toggled off This CL changes the behavior of the signin-allowed toggle on the privacy page: - When the user is syncing and tries to turn the toggle off, the toggle remains on and the sign-out dialog is opened. - When the user turns off sync, they can normally use the toggle. TBR= scottchen@chromium.org, jochen@chromium.org Bug: 892745 Change-Id: If606532345645ae91a93212abc8ba7e521db56ed Reviewed-on: https://chromium-review.googlesource.com/c/1278637 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599538}(cherry picked from commit a75477ad4731366a27e14849c7d64af556b028ec) Reviewed-on: https://chromium-review.googlesource.com/c/1294510 Cr-Commit-Position: refs/branch-heads/3538@{#1026} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/2efb8455d78b4069b8b9ee4a5e29dfed6f1eca44/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/2efb8455d78b4069b8b9ee4a5e29dfed6f1eca44/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/2efb8455d78b4069b8b9ee4a5e29dfed6f1eca44/chrome/test/data/webui/settings/privacy_page_test.js
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2efb8455d78b4069b8b9ee4a5e29dfed6f1eca44 Commit: 2efb8455d78b4069b8b9ee4a5e29dfed6f1eca44 Author: tangltom@chromium.org Commiter: tangltom@chromium.org Date: 2018-10-22 19:01:07 +0000 UTC Show sign-out dialog when signin-allowed is toggled off This CL changes the behavior of the signin-allowed toggle on the privacy page: - When the user is syncing and tries to turn the toggle off, the toggle remains on and the sign-out dialog is opened. - When the user turns off sync, they can normally use the toggle. TBR= scottchen@chromium.org, jochen@chromium.org Bug: 892745 Change-Id: If606532345645ae91a93212abc8ba7e521db56ed Reviewed-on: https://chromium-review.googlesource.com/c/1278637 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599538}(cherry picked from commit a75477ad4731366a27e14849c7d64af556b028ec) Reviewed-on: https://chromium-review.googlesource.com/c/1294510 Cr-Commit-Position: refs/branch-heads/3538@{#1026} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ad32d0719d1419082f9a4556a500134a070b6c2 commit 0ad32d0719d1419082f9a4556a500134a070b6c2 Author: Thomas Tangl <tangltom@chromium.org> Date: Mon Oct 22 19:02:14 2018 Turn off signin-allowed toggle after sign-out from dialog When a sync user confirms to sign out after trying to turn off the signin-allowed toggle, the toggle is now turned off. Additional change: - The code related to the sign-out dialog in settings is extracted into its own element and refactored. Bug: 892745 Change-Id: I9d638d8c77b1f4318fc592cc88f4be95e5eab7c8 Reviewed-on: https://chromium-review.googlesource.com/c/1280542 Reviewed-by: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600997}(cherry picked from commit bca45527fcd1ef23db1a8e399faeddb62be6b1a3) Reviewed-on: https://chromium-review.googlesource.com/c/1294511 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#237} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/0ad32d0719d1419082f9a4556a500134a070b6c2/chrome/browser/resources/settings/people_page/BUILD.gn [modify] https://crrev.com/0ad32d0719d1419082f9a4556a500134a070b6c2/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/0ad32d0719d1419082f9a4556a500134a070b6c2/chrome/browser/resources/settings/people_page/people_page.js [add] https://crrev.com/0ad32d0719d1419082f9a4556a500134a070b6c2/chrome/browser/resources/settings/people_page/signout_dialog.html [add] https://crrev.com/0ad32d0719d1419082f9a4556a500134a070b6c2/chrome/browser/resources/settings/people_page/signout_dialog.js [modify] https://crrev.com/0ad32d0719d1419082f9a4556a500134a070b6c2/chrome/browser/resources/settings/privacy_page/BUILD.gn [modify] https://crrev.com/0ad32d0719d1419082f9a4556a500134a070b6c2/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/0ad32d0719d1419082f9a4556a500134a070b6c2/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/0ad32d0719d1419082f9a4556a500134a070b6c2/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/0ad32d0719d1419082f9a4556a500134a070b6c2/chrome/test/data/webui/settings/people_page_test.js [modify] https://crrev.com/0ad32d0719d1419082f9a4556a500134a070b6c2/chrome/test/data/webui/settings/privacy_page_test.js
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d9ffda8464ead533b501a6a36a0a438b8e5e5c2 commit 9d9ffda8464ead533b501a6a36a0a438b8e5e5c2 Author: Thomas Tangl <tangltom@chromium.org> Date: Mon Oct 22 19:03:24 2018 Turn off signin-allowed toggle after sign-out from dialog When a sync user confirms to sign out after trying to turn off the signin-allowed toggle, the toggle is now turned off. Additional change: - The code related to the sign-out dialog in settings is extracted into its own element and refactored. Bug: 892745 Change-Id: I9d638d8c77b1f4318fc592cc88f4be95e5eab7c8 Reviewed-on: https://chromium-review.googlesource.com/c/1280542 Reviewed-by: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600997}(cherry picked from commit bca45527fcd1ef23db1a8e399faeddb62be6b1a3) Reviewed-on: https://chromium-review.googlesource.com/c/1294531 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#1027} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/9d9ffda8464ead533b501a6a36a0a438b8e5e5c2/chrome/browser/resources/settings/people_page/BUILD.gn [modify] https://crrev.com/9d9ffda8464ead533b501a6a36a0a438b8e5e5c2/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/9d9ffda8464ead533b501a6a36a0a438b8e5e5c2/chrome/browser/resources/settings/people_page/people_page.js [add] https://crrev.com/9d9ffda8464ead533b501a6a36a0a438b8e5e5c2/chrome/browser/resources/settings/people_page/signout_dialog.html [add] https://crrev.com/9d9ffda8464ead533b501a6a36a0a438b8e5e5c2/chrome/browser/resources/settings/people_page/signout_dialog.js [modify] https://crrev.com/9d9ffda8464ead533b501a6a36a0a438b8e5e5c2/chrome/browser/resources/settings/privacy_page/BUILD.gn [modify] https://crrev.com/9d9ffda8464ead533b501a6a36a0a438b8e5e5c2/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/9d9ffda8464ead533b501a6a36a0a438b8e5e5c2/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/9d9ffda8464ead533b501a6a36a0a438b8e5e5c2/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/9d9ffda8464ead533b501a6a36a0a438b8e5e5c2/chrome/test/data/webui/settings/people_page_test.js [modify] https://crrev.com/9d9ffda8464ead533b501a6a36a0a438b8e5e5c2/chrome/test/data/webui/settings/privacy_page_test.js
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d9ffda8464ead533b501a6a36a0a438b8e5e5c2 Commit: 9d9ffda8464ead533b501a6a36a0a438b8e5e5c2 Author: tangltom@chromium.org Commiter: tangltom@chromium.org Date: 2018-10-22 19:03:24 +0000 UTC Turn off signin-allowed toggle after sign-out from dialog When a sync user confirms to sign out after trying to turn off the signin-allowed toggle, the toggle is now turned off. Additional change: - The code related to the sign-out dialog in settings is extracted into its own element and refactored. Bug: 892745 Change-Id: I9d638d8c77b1f4318fc592cc88f4be95e5eab7c8 Reviewed-on: https://chromium-review.googlesource.com/c/1280542 Reviewed-by: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600997}(cherry picked from commit bca45527fcd1ef23db1a8e399faeddb62be6b1a3) Reviewed-on: https://chromium-review.googlesource.com/c/1294531 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#1027} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ad32d0719d1419082f9a4556a500134a070b6c2 Commit: 0ad32d0719d1419082f9a4556a500134a070b6c2 Author: tangltom@chromium.org Commiter: tangltom@chromium.org Date: 2018-10-22 19:02:14 +0000 UTC Turn off signin-allowed toggle after sign-out from dialog When a sync user confirms to sign out after trying to turn off the signin-allowed toggle, the toggle is now turned off. Additional change: - The code related to the sign-out dialog in settings is extracted into its own element and refactored. Bug: 892745 Change-Id: I9d638d8c77b1f4318fc592cc88f4be95e5eab7c8 Reviewed-on: https://chromium-review.googlesource.com/c/1280542 Reviewed-by: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600997}(cherry picked from commit bca45527fcd1ef23db1a8e399faeddb62be6b1a3) Reviewed-on: https://chromium-review.googlesource.com/c/1294511 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#237} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e43f2a113b1a5eb5d378372cd8cf18e6cc9c219d Commit: e43f2a113b1a5eb5d378372cd8cf18e6cc9c219d Author: tangltom@chromium.org Commiter: tangltom@chromium.org Date: 2018-10-22 18:57:40 +0000 UTC Show sign-out dialog when signin-allowed is toggled off This CL changes the behavior of the signin-allowed toggle on the privacy page: - When the user is syncing and tries to turn the toggle off, the toggle remains on and the sign-out dialog is opened. - When the user turns off sync, they can normally use the toggle. TBR= scottchen@chromium.org, jochen@chromium.org Bug: 892745 Change-Id: If606532345645ae91a93212abc8ba7e521db56ed Reviewed-on: https://chromium-review.googlesource.com/c/1278637 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599538}(cherry picked from commit a75477ad4731366a27e14849c7d64af556b028ec) Reviewed-on: https://chromium-review.googlesource.com/c/1294509 Cr-Commit-Position: refs/branch-heads/3578@{#235} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 24
Just verified changes on latest Dev. Everything's WAI! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ew...@chromium.org
, Oct 5