New issue
Advanced search Search tips

Issue 892743 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Quick launch application doesn't have a window frame

Project Member Reported by jamescook@chromium.org, Oct 5

Issue description

ToT at 95d304a7d7d3bf6dff15b4c79d3d1852063dc0ff

1. chrome --ash-dev-shortcuts --ash-debug-shortcuts
2. Hit Ctrl-Alt-Shift-Q to open quick launch

Application opens, but does not have a window frame

 
quick-launch-no-frame.png
26.4 KB View Download
Cc: est...@chromium.org
Owner: jamescook@chromium.org
Status: Started (was: Assigned)
I found a fix while working on a11y. I'll upload shortly.

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6db68f859da56f940b92077e2e571881901c013

commit e6db68f859da56f940b92077e2e571881901c013
Author: James Cook <jamescook@chromium.org>
Date: Fri Oct 05 22:20:54 2018

Add accessibility support to quick_launch test app, fix window frame

This allows testing ChromeVox with multiple simultaneous mash apps.

* Turn on a11y support in AuraInit::InitParams
* Initialize ash window property transport

Bug: 888147,  892743 
Change-Id: I3114787aa687dd6a233b7411739fa3f938cf4399
Reviewed-on: https://chromium-review.googlesource.com/c/1265535
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597341}
[modify] https://crrev.com/e6db68f859da56f940b92077e2e571881901c013/ash/components/quick_launch/BUILD.gn
[modify] https://crrev.com/e6db68f859da56f940b92077e2e571881901c013/ash/components/quick_launch/quick_launch_application.cc
[modify] https://crrev.com/e6db68f859da56f940b92077e2e571881901c013/ash/components/shortcut_viewer/shortcut_viewer_application.cc
[modify] https://crrev.com/e6db68f859da56f940b92077e2e571881901c013/ash/public/cpp/BUILD.gn
[add] https://crrev.com/e6db68f859da56f940b92077e2e571881901c013/ash/public/cpp/ash_client.cc
[add] https://crrev.com/e6db68f859da56f940b92077e2e571881901c013/ash/public/cpp/ash_client.h

Status: Fixed (was: Started)

Sign in to add a comment