New issue
Advanced search Search tips

Issue 892717 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Update fake_openvr_impl_api argument names to match Chromium style guidelines

Project Member Reported by bsheedy@chromium.org, Oct 5

Issue description

fake_openvr_impl_api currently uses the same argument names as in the OpenVR header. These do not match the naming convention specified in the Chromium style guideline, and should be updated to match the rest of the code in Chromium.
 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/129ebfdfee5b85aca4346378769cce6daec250db

commit 129ebfdfee5b85aca4346378769cce6daec250db
Author: bsheedy <bsheedy@chromium.org>
Date: Thu Nov 01 19:49:27 2018

Rename fake_openvr_impl_api variables

Renames the variables in fake_openvr_impl_api.cc to be consistent with
Chromium style guidelines instead of using the original names from
openvr.h.

Also drive-by fixes a timeout that was flakily getting hit.

Bug:  892717 
Change-Id: Id6f25826df26212be5e0fae659cc4715c459f093
Reviewed-on: https://chromium-review.googlesource.com/c/1312195
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604677}
[modify] https://crrev.com/129ebfdfee5b85aca4346378769cce6daec250db/chrome/browser/vr/webxr_vr_pixel_browser_test.cc
[modify] https://crrev.com/129ebfdfee5b85aca4346378769cce6daec250db/device/vr/openvr/test/fake_openvr_impl_api.cc

Status: Fixed (was: Available)

Sign in to add a comment