Tweak initial signin tooltip string to be more clear |
|||
Issue descriptionAfter enabling Signin for Smart Lock for the first time, and signing out to the signin screen, Smart Lock's icon tooltip reads "Enter your password to turn on Smart Lock. Next time, your phone will unlock your Chromebook...". It's a bit confusing to the user to say "...to turn on Smart Lock", since the user just went through multidevice setup flow to turn it on, and just explicitly enabled the Signin for Smart Lock toggle in Settings. Shiba has initially suggested that we "replace 'turn on' with 'enable' in the string". (This is a fairly low priority UI fix right now)
,
Oct 9
Is the only change required here "turn on" > "enable"?
,
Oct 9
Yes
,
Oct 9
OK that's trivial. Done in https://chromium-review.googlesource.com/c/chromium/src/+/1272018.
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f61acd8746ea7b5241bce27723e80df9e53118a commit 5f61acd8746ea7b5241bce27723e80df9e53118a Author: Jeremy Klein <jlklein@google.com> Date: Tue Oct 09 22:16:19 2018 Small string change for SmartLock. At the sign in screen, before SmartLock has been fully enabled for the first time, change the tooltip from "to turn on Smart Lock..." to "to enable Smart Lock...". Bug: 892698 Change-Id: I8528d3d5688e3716b33dbc2954c7f40a8d96b84c Reviewed-on: https://chromium-review.googlesource.com/c/1272018 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#598105} [modify] https://crrev.com/5f61acd8746ea7b5241bce27723e80df9e53118a/chrome/app/chromeos_strings.grdp
,
Oct 9
|
|||
►
Sign in to add a comment |
|||
Comment 1 by shibasheikh@chromium.org
, Oct 9