Issue metadata
Sign in to add a comment
|
Hit assertion "Check failed: (old_visual_rect_.IsEmpty() && new_visual_rect.IsEmpty())..." |
||||||||||||||||||||
Issue descriptionToT 1531f36734e9293a2fa3ba89b9050bfafd2413c1 on Mac, when visiting https://bugs.chromium.org/p/chromium/issues/detail?id=708604#c19 $ out/gnrelease/Chromium.app/Contents/MacOS/Chromium https://bugs.chromium.org/p/chromium/issues/detail?id=708604#c19 [73655:775:1005/181130.097206:WARNING:account_consistency_mode_manager.cc(296)] Desktop Identity Consistency cannot be enabled as no OAuth client ID and client secret have been configured. [73655:775:1005/181130.097423:WARNING:account_consistency_mode_manager.cc(296)] Desktop Identity Consistency cannot be enabled as no OAuth client ID and client secret have been configured. [73655:775:1005/181130.097475:WARNING:account_consistency_mode_manager.cc(296)] Desktop Identity Consistency cannot be enabled as no OAuth client ID and client secret have been configured. [73655:775:1005/181130.097523:WARNING:account_consistency_mode_manager.cc(296)] Desktop Identity Consistency cannot be enabled as no OAuth client ID and client secret have been configured. [73655:775:1005/181130.100681:WARNING:account_consistency_mode_manager.cc(296)] Desktop Identity Consistency cannot be enabled as no OAuth client ID and client secret have been configured. [73655:775:1005/181130.158798:WARNING:account_consistency_mode_manager.cc(296)] Desktop Identity Consistency cannot be enabled as no OAuth client ID and client secret have been configured. [73655:775:1005/181130.182292:WARNING:account_consistency_mode_manager.cc(296)] Desktop Identity Consistency cannot be enabled as no OAuth client ID and client secret have been configured. [73655:775:1005/181130.184120:WARNING:account_consistency_mode_manager.cc(296)] Desktop Identity Consistency cannot be enabled as no OAuth client ID and client secret have been configured. [73655:775:1005/181130.520205:WARNING:account_consistency_mode_manager.cc(296)] Desktop Identity Consistency cannot be enabled as no OAuth client ID and client secret have been configured. [73655:775:1005/181130.586448:ERROR:delegated_frame_host.cc(174)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool) [73655:775:1005/181130.629340:ERROR:web_contents_view_mac.mm(487)] Failed to look up NSViewBridgeFactoryHost! [73655:775:1005/181131.520538:ERROR:native_view_host_mac.mm(198)] Not implemented reached in virtual void views::NativeViewHostMac::ShowWidget(int, int, int, int, int, int) [73655:775:1005/181131.521008:ERROR:native_view_host_mac.mm(198)] Not implemented reached in virtual void views::NativeViewHostMac::ShowWidget(int, int, int, int, int, int) [73655:775:1005/181131.521087:ERROR:native_view_host_mac.mm(198)] Not implemented reached in virtual void views::NativeViewHostMac::ShowWidget(int, int, int, int, int, int) [73655:775:1005/181131.521150:ERROR:native_view_host_mac.mm(198)] Not implemented reached in virtual void views::NativeViewHostMac::ShowWidget(int, int, int, int, int, int) [73655:775:1005/181131.521222:ERROR:native_view_host_mac.mm(198)] Not implemented reached in virtual void views::NativeViewHostMac::ShowWidget(int, int, int, int, int, int) [73655:775:1005/181138.228573:INFO:CONSOLE(2174)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source: https://bugs.chromium.org/p/chromium/issues/detail?id=708604#c19 (2174) [73667:775:1005/181138.643811:FATAL:find_paint_offset_and_visual_rect_needing_update.h(113)] Check failed: (old_visual_rect_.IsEmpty() && new_visual_rect.IsEmpty()) || object_.EnclosingLayer()->SubtreeIsInvisible() || old_visual_rect_ == new_visual_rect || (InflatedRect(old_visual_rect_).Contains(new_visual_rect) && InflatedRect(new_visual_rect).Contains(old_visual_rect_)). Visual rect changed without needing update object="LayoutTableRow TR" old="4,59 1061x2668" new="4,59 1061x2687" 0 libbase.dylib 0x000000010488057e base::debug::StackTrace::StackTrace(unsigned long) + 174 1 libbase.dylib 0x000000010488063d base::debug::StackTrace::StackTrace(unsigned long) + 29 2 libbase.dylib 0x0000000104451dea base::debug::StackTrace::StackTrace() + 26 3 libbase.dylib 0x00000001044bfe6d logging::LogMessage::~LogMessage() + 461 4 libbase.dylib 0x00000001044bda05 logging::LogMessage::~LogMessage() + 21 5 libblink_core.dylib 0x000000014f289821 blink::FindVisualRectNeedingUpdateScopeBase::CheckVisualRect(blink::LayoutRect const&) + 769 6 libblink_core.dylib 0x0000000150679eaa blink::FindObjectVisualRectNeedingUpdateScope::~FindObjectVisualRectNeedingUpdateScope() + 74 7 libblink_core.dylib 0x00000001506789c5 blink::FindObjectVisualRectNeedingUpdateScope::~FindObjectVisualRectNeedingUpdateScope() + 21 8 libblink_core.dylib 0x000000015067780b blink::PaintInvalidator::InvalidatePaint(blink::LayoutObject const&, blink::PaintPropertyTreeBuilderContext const*, blink::PaintInvalidatorContext&) + 1387 9 libblink_core.dylib 0x00000001506f780d blink::PrePaintTreeWalk::WalkInternal(blink::LayoutObject const&, blink::PrePaintTreeWalk::PrePaintTreeWalkContext&) + 285 10 libblink_core.dylib 0x00000001506f68df blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&) + 575 11 libblink_core.dylib 0x00000001506f694a blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&) + 682 12 libblink_core.dylib 0x00000001506f694a blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&) + 682 13 libblink_core.dylib 0x00000001506f694a blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&) + 682 14 libblink_core.dylib 0x00000001506f694a blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&) + 682 15 libblink_core.dylib 0x00000001506f694a blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&) + 682 16 libblink_core.dylib 0x00000001506f694a blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&) + 682 17 libblink_core.dylib 0x00000001506f694a blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&) + 682 18 libblink_core.dylib 0x00000001506f5fa6 blink::PrePaintTreeWalk::Walk(blink::LocalFrameView&) + 902 19 libblink_core.dylib 0x00000001506f56e1 blink::PrePaintTreeWalk::WalkTree(blink::LocalFrameView&) + 673 20 libblink_core.dylib 0x000000014f736811 blink::LocalFrameView::RunPrePaintLifecyclePhase(blink::DocumentLifecycle::LifecycleState) + 385 21 libblink_core.dylib 0x000000014f735d44 blink::LocalFrameView::UpdateLifecyclePhasesInternal(blink::DocumentLifecycle::LifecycleState) + 1460 22 libblink_core.dylib 0x000000014f73465c blink::LocalFrameView::UpdateLifecyclePhases(blink::DocumentLifecycle::LifecycleState) + 972 23 libblink_core.dylib 0x000000014f734282 blink::LocalFrameView::UpdateAllLifecyclePhases() + 50 24 libblink_core.dylib 0x0000000150542725 blink::PageAnimator::UpdateAllLifecyclePhases(blink::LocalFrame&) + 85 25 libblink_core.dylib 0x000000015054b820 blink::PageWidgetDelegate::UpdateLifecycle(blink::Page&, blink::LocalFrame&, blink::WebWidget::LifecycleUpdate) + 112 26 libblink_core.dylib 0x000000014f5625c2 blink::WebViewImpl::UpdateLifecycle(blink::WebWidget::LifecycleUpdate) + 386 27 libblink_core.dylib 0x000000014f8358f7 blink::WebViewFrameWidget::UpdateLifecycle(blink::WebWidget::LifecycleUpdate) + 39 28 libcontent.dylib 0x00000001286bbf57 content::RenderWidget::UpdateVisualState() + 71 29 libcontent.dylib 0x000000012804f5ea content::LayerTreeView::UpdateLayerTreeHost() + 26 30 libcc.dylib 0x0000000134f124ea cc::LayerTreeHost::RequestMainFrameUpdate() + 26 31 libcc.dylib 0x0000000135098557 cc::ProxyMain::BeginMainFrame(std::__1::unique_ptr<cc::BeginMainF
,
Oct 5
Also reproduced on Linux.
,
Oct 5
Bisected to https://chromium-review.googlesource.com/1237246. Seems a case that some object does need visual rect update but not marked as itself needing visual rect update. vmpstr@ can you take a look?
,
Oct 5
Issue 892762 has been merged into this issue.
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6224f325689fce9f236aec1eb21162178e84f78 commit e6224f325689fce9f236aec1eb21162178e84f78 Author: Vladimir Levin <vmpstr@chromium.org> Date: Fri Oct 05 22:31:38 2018 Ensure to check for paint invalidation on tablerow vis rect changes. When the visual rect of the table row changes due to the cell's frame rect changing, we don't current invalidate the visual rect. This patch addresses that. R=wangxianzhu@chromium.org Bug: 892647 Change-Id: Iaf5de6f4b801175bb6e0a4e3e6df92468400451e Reviewed-on: https://chromium-review.googlesource.com/c/1265896 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597349} [modify] https://crrev.com/e6224f325689fce9f236aec1eb21162178e84f78/third_party/blink/renderer/core/layout/layout_table_row.cc
,
Oct 5
Still need to write a test for this, but it should be fixed other than that. Keeping it open for now.
,
Oct 7
Good work, big thanks for the quick fix!
,
Oct 8
chrishtr@ is doing some refactors in this area of the code. I'm going to wait until that's more or less done and write the test then, since right now function names and code location is changing :P |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by schenney@chromium.org
, Oct 5Status: Assigned (was: Untriaged)