Issue metadata
Sign in to add a comment
|
NetExportFileWriter doesn't handle Network Service crashes |
||||||||||||||||||||||||
Issue descriptionIf the network process crashes while NetExportFileWriter is logging, the FileWriter won't notice. If it's then stopped, the FileWriter will get stuck in STATE_STOPPING_LOG. This is not exactly the most critical bug out there, but it would be nice to improve things a bit.
,
Oct 8
,
Oct 11
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08214762f5d53f814650305d16da869bfc2aaaef commit 08214762f5d53f814650305d16da869bfc2aaaef Author: Maks Orlovich <morlovich@chromium.org> Date: Wed Oct 17 00:52:17 2018 NetLogExporter: handle network service crashes Bug: 892645 Change-Id: I53f9def5f23d45346b060e0cbb8138e6616b07ac Reviewed-on: https://chromium-review.googlesource.com/c/1283838 Reviewed-by: Eric Roman <eroman@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#600213} [modify] https://crrev.com/08214762f5d53f814650305d16da869bfc2aaaef/components/net_log/BUILD.gn [modify] https://crrev.com/08214762f5d53f814650305d16da869bfc2aaaef/components/net_log/DEPS [modify] https://crrev.com/08214762f5d53f814650305d16da869bfc2aaaef/components/net_log/net_export_file_writer.cc [modify] https://crrev.com/08214762f5d53f814650305d16da869bfc2aaaef/components/net_log/net_export_file_writer.h [modify] https://crrev.com/08214762f5d53f814650305d16da869bfc2aaaef/components/net_log/net_export_file_writer_unittest.cc
,
Oct 17
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by fhyka...@gmail.com
, Oct 5