Dexdump used by catapult/devil is out of date |
|||||||||
Issue descriptionDexdump that catapult uses (supplied in [1]) is out of date. It fails with an error on new dex file (update to dex in cl/1258059). $ third_party/catapult/devil/bin/deps/linux2/x86_64/bin/dexdump /tmp/tmpoFJSSh_dex_extract/classes2.dex -f Processing '/tmp/tmpoFJSSh_dex_extract/classes2.dex'... E/libdex (36041): ERROR: unsupported dex version (30 33 37 00) E/libdex (36041): ERROR: Byte swap + verify failed ERROR: Failed structural verification of '/tmp/tmpoFJSSh_dex_extract/classes2.dex' Link to failing binary size trybot (which uses catapult dexdump) in [2]. dexdump that is supplied by the sdk in third_party/android_tools/sdk/build-tools/27.0.3/dexdump work correctly on the same dex file. [1] https://cs.chromium.org/chromium/src/third_party/catapult/devil/devil/devil_dependencies.json?rcl=56216d7832a46730d5d9d6bba7fa5742d9601390&l=44 [2] https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-binary-size/69123
,
Oct 5
ICC doesn't really handle catapult bugs right now.... Ned, do you know where this should go?
,
Oct 5
perf dashboard team or chrome speed metrics team, I think
,
Oct 5
Actually for catapult/devil/, I think John or Ben Pastenee is still the owner?
,
Oct 5
,
Oct 5
Assigning to John for now, feel free to change.
,
Oct 8
Yeah, I'm the right owner for this. Devil's binaries generally need updating :(
,
Oct 9
,
Nov 6
Hey jbudorick@ any updates on this bug.
,
Nov 29
,
Nov 29
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/35457f076227dce062ece5b51f3655223af1788f commit 35457f076227dce062ece5b51f3655223af1788f Author: John Budorick <jbudorick@chromium.org> Date: Fri Nov 30 17:46:45 2018 devil: update to build-tools 27.0.3. Note that this will only affect the binaries devil uses by default, not those injected by most of chromium. Bug: chromium:892644 Change-Id: I0df428f9dbd498dbab87709548cb69f3ae44e402 Reviewed-on: https://chromium-review.googlesource.com/c/1355968 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/35457f076227dce062ece5b51f3655223af1788f/devil/devil/devil_dependencies.json
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2d301e2acf69cdde0e06fc1ec151b4665a00ffc commit b2d301e2acf69cdde0e06fc1ec151b4665a00ffc Author: John Budorick <jbudorick@chromium.org> Date: Fri Nov 30 18:52:59 2018 android: update build-tools used by devil to 27.0.3. Bug: 892644 Change-Id: Ib888cb9f6f5db2bea89d3e300d86d0b797f8eacb Reviewed-on: https://chromium-review.googlesource.com/c/1357006 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#612712} [modify] https://crrev.com/b2d301e2acf69cdde0e06fc1ec151b4665a00ffc/build/android/devil_chromium.json
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afb685eada072d2a7001207c64fa4f81ccf3aceb commit afb685eada072d2a7001207c64fa4f81ccf3aceb Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Nov 30 19:32:12 2018 Roll src/third_party/catapult 1b98245e3cb7..35457f076227 (1 commits) https://chromium.googlesource.com/catapult.git/+log/1b98245e3cb7..35457f076227 git log 1b98245e3cb7..35457f076227 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 jbudorick@chromium.org devil: update to build-tools 27.0.3. Created with: gclient setdep -r src/third_party/catapult@35457f076227 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:892644 TBR=sullivan@chromium.org Change-Id: I58deab311d3612bfd8a623305e49f122ab46a0e6 Reviewed-on: https://chromium-review.googlesource.com/c/1356635 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612725} [modify] https://crrev.com/afb685eada072d2a7001207c64fa4f81ccf3aceb/DEPS
,
Nov 30
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mheikal@chromium.org
, Oct 5